Skip to content

Q
qgroundcontrol
Commit 728b350e authored by Anton Matosov's avatar Anton Matosov
Browse files
Options

Reworked code to reduce number of unnecessary virtual function calls

parent e4baa3ce
Hide whitespace changes
Inline Side-by-side
Showing with 6 additions and 5 deletions
src/ui/px4_configuration/PX4RCCalibration.cc
View file @ 728b350e
...@@ -163,32 +163,33 @@ void PX4RCCalibration::_setInternalCalibrationValuesFromParameters(void) ...@@ -163,32 +163,33 @@ void PX4RCCalibration::_setInternalCalibrationValuesFromParameters(void)
QVariant value; QVariant value;
bool paramFound; bool paramFound;
bool convertOk; bool convertOk;
int componentId = _paramMgr->getDefaultComponentId();
for (int i = 0; i < _chanMax; ++i) { for (int i = 0; i < _chanMax; ++i) {
struct ChannelInfo* info = &_rgChannelInfo[i]; struct ChannelInfo* info = &_rgChannelInfo[i];
paramFound = _paramMgr->getParameterValue(_paramMgr->getDefaultComponentId(), trimTpl.arg(i+1), value); paramFound = _paramMgr->getParameterValue(componentId, trimTpl.arg(i+1), value);
Q_ASSERT(paramFound); Q_ASSERT(paramFound);
if (paramFound) { if (paramFound) {
info->rcTrim = value.toInt(&convertOk); info->rcTrim = value.toInt(&convertOk);
Q_ASSERT(convertOk); Q_ASSERT(convertOk);
} }
paramFound = _paramMgr->getParameterValue(_paramMgr->getDefaultComponentId(), minTpl.arg(i+1), value); paramFound = _paramMgr->getParameterValue(componentId, minTpl.arg(i+1), value);
Q_ASSERT(paramFound); Q_ASSERT(paramFound);
if (paramFound) { if (paramFound) {
info->rcMin = value.toInt(&convertOk); info->rcMin = value.toInt(&convertOk);
Q_ASSERT(convertOk); Q_ASSERT(convertOk);
} }
paramFound = _paramMgr->getParameterValue(_paramMgr->getDefaultComponentId(), maxTpl.arg(i+1), value); paramFound = _paramMgr->getParameterValue(componentId, maxTpl.arg(i+1), value);
Q_ASSERT(paramFound); Q_ASSERT(paramFound);
if (paramFound) { if (paramFound) {
info->rcMax = value.toInt(&convertOk); info->rcMax = value.toInt(&convertOk);
Q_ASSERT(convertOk); Q_ASSERT(convertOk);
} }
paramFound = _paramMgr->getParameterValue(_paramMgr->getDefaultComponentId(), revTpl.arg(i+1), value); paramFound = _paramMgr->getParameterValue(componentId, revTpl.arg(i+1), value);
Q_ASSERT(paramFound); Q_ASSERT(paramFound);
if (paramFound) { if (paramFound) {
float floatReversed = value.toFloat(&convertOk); float floatReversed = value.toFloat(&convertOk);
...@@ -201,7 +202,7 @@ void PX4RCCalibration::_setInternalCalibrationValuesFromParameters(void) ...@@ -201,7 +202,7 @@ void PX4RCCalibration::_setInternalCalibrationValuesFromParameters(void)
for (int i=0; i<rcCalFunctionMax; i++) { for (int i=0; i<rcCalFunctionMax; i++) {
int32_t paramChannel; int32_t paramChannel;
paramFound = _paramMgr->getParameterValue(_paramMgr->getDefaultComponentId(), _rgFunctionInfo[i].parameterName, value); paramFound = _paramMgr->getParameterValue(componentId, _rgFunctionInfo[i].parameterName, value);
Q_ASSERT(paramFound); Q_ASSERT(paramFound);
if (paramFound) { if (paramFound) {
paramChannel = value.toInt(&convertOk); paramChannel = value.toInt(&convertOk);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment