From 728b350e45d83dce9cd91b91dccb45be6efa2eda Mon Sep 17 00:00:00 2001 From: Anton Matosov Date: Tue, 14 Oct 2014 09:59:52 +0300 Subject: [PATCH] Reworked code to reduce number of unnecessary virtual function calls --- src/ui/px4_configuration/PX4RCCalibration.cc | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/ui/px4_configuration/PX4RCCalibration.cc b/src/ui/px4_configuration/PX4RCCalibration.cc index 455c4dbcf..efdab85ed 100644 --- a/src/ui/px4_configuration/PX4RCCalibration.cc +++ b/src/ui/px4_configuration/PX4RCCalibration.cc @@ -163,32 +163,33 @@ void PX4RCCalibration::_setInternalCalibrationValuesFromParameters(void) QVariant value; bool paramFound; bool convertOk; + int componentId = _paramMgr->getDefaultComponentId(); for (int i = 0; i < _chanMax; ++i) { struct ChannelInfo* info = &_rgChannelInfo[i]; - paramFound = _paramMgr->getParameterValue(_paramMgr->getDefaultComponentId(), trimTpl.arg(i+1), value); + paramFound = _paramMgr->getParameterValue(componentId, trimTpl.arg(i+1), value); Q_ASSERT(paramFound); if (paramFound) { info->rcTrim = value.toInt(&convertOk); Q_ASSERT(convertOk); } - paramFound = _paramMgr->getParameterValue(_paramMgr->getDefaultComponentId(), minTpl.arg(i+1), value); + paramFound = _paramMgr->getParameterValue(componentId, minTpl.arg(i+1), value); Q_ASSERT(paramFound); if (paramFound) { info->rcMin = value.toInt(&convertOk); Q_ASSERT(convertOk); } - paramFound = _paramMgr->getParameterValue(_paramMgr->getDefaultComponentId(), maxTpl.arg(i+1), value); + paramFound = _paramMgr->getParameterValue(componentId, maxTpl.arg(i+1), value); Q_ASSERT(paramFound); if (paramFound) { info->rcMax = value.toInt(&convertOk); Q_ASSERT(convertOk); } - paramFound = _paramMgr->getParameterValue(_paramMgr->getDefaultComponentId(), revTpl.arg(i+1), value); + paramFound = _paramMgr->getParameterValue(componentId, revTpl.arg(i+1), value); Q_ASSERT(paramFound); if (paramFound) { float floatReversed = value.toFloat(&convertOk); @@ -201,7 +202,7 @@ void PX4RCCalibration::_setInternalCalibrationValuesFromParameters(void) for (int i=0; igetParameterValue(_paramMgr->getDefaultComponentId(), _rgFunctionInfo[i].parameterName, value); + paramFound = _paramMgr->getParameterValue(componentId, _rgFunctionInfo[i].parameterName, value); Q_ASSERT(paramFound); if (paramFound) { paramChannel = value.toInt(&convertOk); -- 2.22.0