Merge pull request #2513 from DonLakeFlyer/ParamEditWork

Parameter editor work

src/QmlControls/ParameterEditor.qml

@@ -290,7 +290,7 @@ QGCView {
                             id:     valueLabel
                             width:  ScreenTools.defaultFontPixelWidth  * 20
                             color:  factRow.modelFact.defaultValueAvailable ? (factRow.modelFact.valueEqualsDefault ? __qgcPal.text : __qgcPal.warningText) : __qgcPal.text
-                            text:   factRow.modelFact.valueString + " " + factRow.modelFact.units
+                            text:   factRow.modelFact.enumStrings.length == 0 ? factRow.modelFact.valueString + " " + factRow.modelFact.units : factRow.modelFact.enumStringValue
                         }
                         QGCLabel {
                             text:   factRow.modelFact.shortDescription

src/QmlControls/ParameterEditorDialog.qml

@@ -35,6 +35,8 @@ import QGroundControl.FactControls  1.0
 import QGroundControl.ScreenTools   1.0
 
 QGCViewDialog {
+    id: root
+
     property Fact   fact
     property bool   validate:       false
     property string validateValue
@@ -42,14 +44,19 @@ QGCViewDialog {
     ParameterEditorController { id: controller; factPanel: parent }
 
     function accept() {
-        var errorString = fact.validate(valueField.text, forceSave.checked)
-        if (errorString == "") {
-            fact.value = valueField.text
-            fact.valueChanged(fact.value)
+        if (factCombo.visible) {
+            fact.enumIndex = factCombo.currentIndex
             hideDialog()
         } else {
-            validationError.text = errorString
-            forceSave.visible = true
+            var errorString = fact.validate(valueField.text, forceSave.checked)
+            if (errorString == "") {
+                fact.value = valueField.text
+                fact.valueChanged(fact.value)
+                hideDialog()
+            } else {
+                validationError.text = errorString
+                forceSave.visible = true
+            }
         }
     }
 
@@ -80,14 +87,30 @@ QGCViewDialog {
         }
 
         QGCTextField {
-            id:     valueField
-            text:   validate ? validateValue : fact.valueString
+            id:         valueField
+            text:       validate ? validateValue : fact.valueString
+            visible:    fact.enumStrings.length == 0 || validate
             //focus:  true
 
             // At this point all Facts are numeric
             inputMethodHints:   Qt.ImhFormattedNumbersOnly
         }
 
+        QGCComboBox {
+            id:             factCombo
+            width:          valueField.width
+            visible:        fact.enumStrings.length != 0 && !validate
+            model:          fact.enumStrings
+
+            Component.onCompleted: {
+                // We can't bind directly to fact.enumIndex since that would add an unknown value
+                // if there are no enum strings.
+                if (visible) {
+                    currentIndex = fact.enumIndex
+                }
+            }
+        }
+
         QGCLabel { text: fact.name }
 
         Row {