UASParameterCommsMgr.cc 20.7 KB
Newer Older
1 2
#include "UASParameterCommsMgr.h"

tstellanova's avatar
tstellanova committed
3 4
#include <QSettings>

5 6 7
#include "QGCUASParamManager.h"
#include "UASInterface.h"

8 9
#define RC_CAL_CHAN_MAX 8

10
UASParameterCommsMgr::UASParameterCommsMgr(QObject *parent) :
tstellanova's avatar
tstellanova committed
11
    QObject(parent),
12
    mav(NULL),
13
    paramDataModel(NULL),
tstellanova's avatar
tstellanova committed
14 15 16
    transmissionListMode(false),
    transmissionActive(false),
    transmissionTimeout(0),
17 18
    retransmissionTimeout(1000),
    rewriteTimeout(1000),
tstellanova's avatar
tstellanova committed
19
    retransmissionBurstRequestSize(5)
20
{
21 22 23 24 25 26 27


}

UASParameterCommsMgr* UASParameterCommsMgr::initWithUAS(UASInterface* uas)
{
    mav = uas;
28
    paramDataModel = mav->getParamManager()->dataModel();
tstellanova's avatar
tstellanova committed
29 30 31 32 33
    loadParamCommsSettings();

    //Requesting parameters one-by-one from mav
    connect(this, SIGNAL(parameterUpdateRequestedById(int,int)),
            mav, SLOT(requestParameter(int,int)));
34 35

    // Sending params to the UAS
36
    connect(this, SIGNAL(commitPendingParameter(int,QString,QVariant)),
37
            mav, SLOT(setParameter(int,QString,QVariant)));
38

39
    // Received parameter updates from UAS
40 41
    connect(mav, SIGNAL(parameterChanged(int,int,int,int,QString,QVariant)),
            this, SLOT(receivedParameterUpdate(int,int,int,int,QString,QVariant)));
42

43
    //connect to retransmissionTimer
44 45
    connect(&retransmissionTimer, SIGNAL(timeout()),
            this, SLOT(retransmissionGuardTick()));
tstellanova's avatar
tstellanova committed
46

47
    return this;
48 49 50
}


tstellanova's avatar
tstellanova committed
51 52 53 54 55

void UASParameterCommsMgr::loadParamCommsSettings()
{
    QSettings settings;
    settings.beginGroup("QGC_MAVLINK_PROTOCOL");
tstellanova's avatar
tstellanova committed
56
    bool ok;
tstellanova's avatar
tstellanova committed
57
    int val = settings.value("PARAMETER_RETRANSMISSION_TIMEOUT", retransmissionTimeout).toInt(&ok);
tstellanova's avatar
tstellanova committed
58 59
    if (ok) {
        retransmissionTimeout = val;
60
        qDebug() << "retransmissionTimeout" << retransmissionTimeout;
tstellanova's avatar
tstellanova committed
61 62
    }
    val = settings.value("PARAMETER_REWRITE_TIMEOUT", rewriteTimeout).toInt(&ok);
tstellanova's avatar
tstellanova committed
63 64
    if (ok) {
        rewriteTimeout = val;
tstellanova's avatar
tstellanova committed
65 66 67 68
    }
    settings.endGroup();
}

69 70


71 72 73 74 75 76 77 78 79 80 81 82 83
/**
 * Send a request to deliver the list of onboard parameters
 * from the MAV.
 */
void UASParameterCommsMgr::requestParameterList()
{
    if (!mav) {
        return;
    }

    //TODO check: no need to cause datamodel to forget params here?
//    paramDataModel->forgetAllOnboardParameters();

84 85 86 87 88 89
    if (!transmissionListMode) {
        // Clear transmission state
        receivedParamsList.clear();
        transmissionListSizeKnown.clear();

        transmissionListMode = true;
90 91
        foreach (int key, missingReadPackets.keys()) {
            missingReadPackets.value(key)->clear();
92 93 94 95
        }
        transmissionActive = true;

        setParameterStatusMsg(tr("Requested param list.. waiting"));
96
        listRecvTimeout = QGC::groundTimeMilliseconds() + 10000;
97
        mav->requestParameters();
98
        setRetransmissionGuardEnabled(true);
99 100 101
    }
    else {
        qDebug() << __FILE__ << __LINE__ << "Ignoring requestParameterList because we're receiving params list";
102 103 104 105 106
    }

}


107 108 109 110
/*
 Empty read retransmission list
 Empty write retransmission list
*/
tstellanova's avatar
tstellanova committed
111
void UASParameterCommsMgr::clearRetransmissionLists(int& missingReadCount, int& missingWriteCount )
112 113 114
{
    qDebug() << __FILE__ << __LINE__ << "clearRetransmissionLists";

tstellanova's avatar
tstellanova committed
115
    missingReadCount = 0;
116
    QList<int> readKeys = missingReadPackets.keys();
117
    foreach (int compId, readKeys) {
118 119
        missingReadCount += missingReadPackets.value(compId)->count();
        missingReadPackets.value(compId)->clear();
120 121
    }

tstellanova's avatar
tstellanova committed
122
    missingWriteCount = 0;
123
    QList<int> writeKeys = missingWriteAckPackets.keys();
124
    foreach (int compId, writeKeys) {
125 126
        missingWriteCount += missingWriteAckPackets.value(compId)->count();
        missingWriteAckPackets.value(compId)->clear();
127 128 129 130 131
    }

}


132
void UASParameterCommsMgr::emitPendingParameterCommit(int compId, const QString& key, QVariant& value)
133 134 135 136 137 138 139
{
    int paramType = (int)value.type();
    switch (paramType)
    {
    case QVariant::Char:
    {
        QVariant fixedValue(QChar((unsigned char)value.toInt()));
140
        emit commitPendingParameter(compId, key, fixedValue);
141 142 143 144 145
    }
        break;
    case QVariant::Int:
    {
        QVariant fixedValue(value.toInt());
146
        emit commitPendingParameter(compId, key, fixedValue);
147 148 149 150 151
    }
        break;
    case QVariant::UInt:
    {
        QVariant fixedValue(value.toUInt());
152
        emit commitPendingParameter(compId, key, fixedValue);
153 154 155 156 157
    }
        break;
    case QMetaType::Float:
    {
        QVariant fixedValue(value.toFloat());
158
        emit commitPendingParameter(compId, key, fixedValue);
159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178
    }
        break;
    default:
        qCritical() << "ABORTED PARAM SEND, NO VALID QVARIANT TYPE";
        return;
    }

    setParameterStatusMsg(tr("Requested write of: %1: %2").arg(key).arg(value.toDouble()));

}


void UASParameterCommsMgr::resendReadWriteRequests()
{
    int compId;
    QList<int> compIds;

    // Re-request at maximum retransmissionBurstRequestSize parameters at once
    // to prevent link flooding'
    int requestedReadCount = 0;
179
    compIds = missingReadPackets.keys();
180 181
    foreach (compId, compIds) {
        // Request n parameters from this component (at maximum)
182 183
        QList<int>* missingReadParams = missingReadPackets.value(compId, NULL);
        qDebug() << "missingReadParams:" << missingReadParams->count();
184 185
        foreach (int paramId, *missingReadParams) {
            if (requestedReadCount < retransmissionBurstRequestSize) {
186
                //qDebug() << __FILE__ << __LINE__ << "RETRANSMISSION GUARD REQUESTS RETRANSMISSION OF PARAM #" << paramId << "FROM COMPONENT #" << compId;
187 188 189 190 191 192 193 194 195 196 197 198 199 200
                emit parameterUpdateRequestedById(compId, paramId);
                setParameterStatusMsg(tr("Requested retransmission of #%1").arg(paramId+1));
                requestedReadCount++;
            }
            else {
                qDebug() << "Throttling read retransmit requests at" << requestedReadCount;
                break;
            }
        }
    }

    // Re-request at maximum retransmissionBurstRequestSize parameters at once
    // to prevent write-request link flooding
    int requestedWriteCount = 0;
201
    compIds = missingWriteAckPackets.keys();
202
    foreach (compId, compIds) {
203
        QMap <QString, QVariant>* missingParams = missingWriteAckPackets.value(compId);
204 205 206 207
        foreach (QString key, missingParams->keys()) {
            if (requestedWriteCount < retransmissionBurstRequestSize) {
                // Re-request write operation
                QVariant value = missingParams->value(key);
208
                emitPendingParameterCommit(compId, key, value);
209 210 211 212 213 214 215 216 217 218 219
                requestedWriteCount++;
            }
            else {
                qDebug() << "Throttling write retransmit requests at" << requestedWriteCount;
                break;
            }
        }
    }

    if ((0 == requestedWriteCount) && (0 == requestedReadCount) ) {
        qDebug() << __FILE__ << __LINE__ << "NO re-read or rewrite requests??";
220 221 222 223
        if (!transmissionListMode) {
            setRetransmissionGuardEnabled(false);
            transmissionActive = false;
        }
224
    }
225 226 227 228
    else {
        //restart the timer now that we've sent
        setRetransmissionGuardEnabled(true);
    }
229 230
}

231 232 233 234 235
void UASParameterCommsMgr::resetAfterListReceive()
{
    transmissionListMode = false;
    transmissionListSizeKnown.clear();

236
    //We shouldn't clear missingPackets because other transactions might be using them?
237 238 239

}

240 241
void UASParameterCommsMgr::retransmissionGuardTick()
{
242 243 244
    quint64 curTime = QGC::groundTimeMilliseconds();

    //Workaround for an apparent Qt bug that causes retransmission guard timer to fire prematurely (350ms)
245
    int elapsed = (int)(curTime - lastTimerReset);
tstellanova's avatar
tstellanova committed
246
    if (elapsed < retransmissionTimeout) {
247 248 249 250 251
        qDebug() << "retransmissionGuardTick elapsed:" << (curTime - lastTimerReset);
        //reset the guard timer: it fired prematurely
        setRetransmissionGuardEnabled(true);
        return;
    }
252 253
    qDebug() << __FILE__ << __LINE__ << "RETRANSMISSION GUARD ACTIVE after" << elapsed;

254

255
    if (transmissionActive) {
256 257 258

        if (transmissionListMode && transmissionListSizeKnown.isEmpty() ) {
            //we are still waitin for the first parameter list response
259
            if (curTime > this->listRecvTimeout) {
260 261
                //re-request parameters
                setParameterStatusMsg(tr("TIMEOUT: Re-requesting param list"),ParamCommsStatusLevel_Warning);
262
                listRecvTimeout = curTime + 10000;
263
                mav->requestParameters();
264 265
                //reset the timer
                setRetransmissionGuardEnabled(true);
266 267 268 269
            }
            return;
        }

270 271
        // Check for timeout
        // stop retransmission attempts on timeout
272
        if (curTime > transmissionTimeout) {
273
            setRetransmissionGuardEnabled(false);
274 275
            resetAfterListReceive();

tstellanova's avatar
tstellanova committed
276 277 278 279 280 281 282
            int missingReadCount, missingWriteCount;
            clearRetransmissionLists(missingReadCount,missingWriteCount);
            if ((missingReadCount > 0) || (missingWriteCount > 0)) {
                setParameterStatusMsg(tr("TIMEOUT! MISSING: %1 read, %2 write.").arg(missingReadCount).arg(missingWriteCount),
                                      ParamCommsStatusLevel_Warning);
            }

283
            return;
284 285
        }

286 287 288
        resendReadWriteRequests();
    }
    else {
289
        qDebug() << __FILE__ << __LINE__ << "STOPPING RETRANSMISSION GUARD GRACEFULLY";
290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307
        setRetransmissionGuardEnabled(false);
    }
}



/**
 * Enabling the retransmission guard enables the parameter widget to track
 * dropped parameters and to re-request them. This works for both individual
 * parameter reads as well for whole list requests.
 *
 * @param enabled True if retransmission checking should be enabled, false else
 */

void UASParameterCommsMgr::setRetransmissionGuardEnabled(bool enabled)
{
    if (enabled) {
        retransmissionTimer.start(retransmissionTimeout);
308
        lastTimerReset = QGC::groundTimeMilliseconds() ;
309 310 311 312 313 314 315 316 317 318 319 320
    } else {
        retransmissionTimer.stop();
    }
}

void UASParameterCommsMgr::requestParameterUpdate(int component, const QString& parameter)
{
    if (mav) {
        mav->requestParameter(component, parameter);
    }
}

321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349
void UASParameterCommsMgr::requestRcCalibrationParamsUpdate()
{
    if (!transmissionListMode) {
        QString minTpl("RC%1_MIN");
        QString maxTpl("RC%1_MAX");
        QString trimTpl("RC%1_TRIM");
        QString revTpl("RC%1_REV");

        // Do not request the RC type, as these values depend on this
        // active onboard parameter

        for (unsigned int i = 1; i < (RC_CAL_CHAN_MAX+1); ++i)  {
            qDebug() << "Request RC " << i;
            mav->requestParameter(0, minTpl.arg(i));
            QGC::SLEEP::usleep(5000);
            mav->requestParameter(0, trimTpl.arg(i));
            QGC::SLEEP::usleep(5000);
            mav->requestParameter(0, maxTpl.arg(i));
            QGC::SLEEP::usleep(5000);
            mav->requestParameter(0, revTpl.arg(i));
            QGC::SLEEP::usleep(5000);
        }
    }
    else {
        qDebug() << __FILE__ << __LINE__ << "Ignoring requestRcCalibrationParamsUpdate because we're receiving params list";
    }
}


350 351 352 353 354 355 356 357 358 359 360 361 362 363
/**
 * @param component the subsystem which has the parameter
 * @param parameterName name of the parameter, as delivered by the system
 * @param value value of the parameter
 */
void UASParameterCommsMgr::setParameter(int component, QString parameterName, QVariant value)
{
    if (parameterName.isEmpty()) {
        return;
    }

    double dblValue = value.toDouble();

    if (paramDataModel->isValueLessThanParamMin(parameterName,dblValue)) {
tstellanova's avatar
tstellanova committed
364 365 366
        setParameterStatusMsg(tr("REJ. %1, %2 < min").arg(parameterName).arg(dblValue),
                              ParamCommsStatusLevel_Error
                              );
367 368 369
        return;
    }
    if (paramDataModel->isValueGreaterThanParamMax(parameterName,dblValue)) {
tstellanova's avatar
tstellanova committed
370 371 372
        setParameterStatusMsg(tr("REJ. %1, %2 > max").arg(parameterName).arg(dblValue),
                              ParamCommsStatusLevel_Error
                              );
373 374
        return;
    }
375

376
    QVariant onboardVal;
377
    paramDataModel->getOnboardParamValue(component,parameterName,onboardVal);
378
    if (onboardVal == value) {
tstellanova's avatar
tstellanova committed
379 380 381
        setParameterStatusMsg(tr("REJ. %1 already %2").arg(parameterName).arg(dblValue),
                              ParamCommsStatusLevel_Warning
                              );
382 383 384
        return;
    }

385
    emitPendingParameterCommit(component, parameterName, value);
386 387 388

    // Wait for parameter to be written back
    // mark it therefore as missing
389 390
    if (!missingWriteAckPackets.contains(component)) {
        missingWriteAckPackets.insert(component, new QMap<QString, QVariant>());
391 392 393
    }

    // Insert it in missing write ACK list
394
    missingWriteAckPackets.value(component)->insert(parameterName, value);
395 396

    // Set timeouts
397
    if (transmissionActive) {
398 399
        transmissionTimeout += rewriteTimeout;
    }
400
    else {
401
        quint64 newTransmissionTimeout = QGC::groundTimeMilliseconds() + rewriteTimeout;
402
        if (newTransmissionTimeout > transmissionTimeout) {
403 404 405 406 407 408 409 410 411
            transmissionTimeout = newTransmissionTimeout;
        }
        transmissionActive = true;
    }

    // Enable guard / reset timeouts
    setRetransmissionGuardEnabled(true);
}

tstellanova's avatar
tstellanova committed
412
void UASParameterCommsMgr::setParameterStatusMsg(const QString& msg, ParamCommsStatusLevel_t level)
413 414 415
{
    qDebug() << "parameterStatusMsg: " << msg;
    parameterStatusMsg = msg;
tstellanova's avatar
tstellanova committed
416

tstellanova's avatar
tstellanova committed
417
    emit parameterStatusMsgUpdated(msg,level);
418
}
tstellanova's avatar
tstellanova committed
419 420 421 422 423 424 425 426 427


/**
 * @param uas System which has the component
 * @param component id of the component
 * @param parameterName human friendly name of the parameter
 */
void UASParameterCommsMgr::receivedParameterUpdate(int uas, int compId, int paramCount, int paramId, QString paramName, QVariant value)
{
428 429 430
    Q_UNUSED(uas); //this object is assigned to one UAS only

    //notify the data model that we have an updated param
431
    paramDataModel->handleParamUpdate(compId,paramName,value);
tstellanova's avatar
tstellanova committed
432 433

    // Missing packets list has to be instantiated for all components
434 435
    if (!missingReadPackets.contains(compId)) {
        missingReadPackets.insert(compId, new QList<int>());
tstellanova's avatar
tstellanova committed
436 437
    }

438
    QList<int>* compMissReadPackets =  missingReadPackets.value(compId);
439

tstellanova's avatar
tstellanova committed
440 441 442 443 444 445 446 447
    // List mode is different from single parameter transfers
    if (transmissionListMode) {
        // Only accept the list size once on the first packet from
        // each component
        if (!transmissionListSizeKnown.contains(compId)) {
            // Mark list size as known
            transmissionListSizeKnown.insert(compId, true);

448
            qDebug() << "Mark all parameters as missing: " << paramCount;
449
            for (int i = 1; i < paramCount; ++i) { //TODO check: param Id 0 is  "all parameters" and not valid ?
450 451
                if (!compMissReadPackets->contains(i)) {
                    compMissReadPackets->append(i);
tstellanova's avatar
tstellanova committed
452 453 454 455 456 457
                }
            }

            // There is only one transmission timeout for all components
            // since components do not manage their transmission,
            // the longest timeout is safe for all components.
458
            quint64 thisTransmissionTimeout = QGC::groundTimeMilliseconds() + (paramCount*retransmissionTimeout);
tstellanova's avatar
tstellanova committed
459 460 461 462 463 464 465 466
            if (thisTransmissionTimeout > transmissionTimeout) {
                transmissionTimeout = thisTransmissionTimeout;
            }
        }

    }

    // Mark this parameter as received in read list
467
    int index = compMissReadPackets->indexOf(paramId);
tstellanova's avatar
tstellanova committed
468
    if (index != -1) {
469
        compMissReadPackets->removeAt(index);
tstellanova's avatar
tstellanova committed
470 471 472 473
    }

    bool justWritten = false;
    bool writeMismatch = false;
474

tstellanova's avatar
tstellanova committed
475
    // Mark this parameter as received in write ACK list
476 477
    QMap<QString, QVariant>* compMissWritePackets = missingWriteAckPackets.value(compId);
    if (compMissWritePackets && compMissWritePackets->contains(paramName)) {
tstellanova's avatar
tstellanova committed
478
        justWritten = true;
479
        if (compMissWritePackets->value(paramName) != value) {
tstellanova's avatar
tstellanova committed
480 481
            writeMismatch = true;
        }
482
        compMissWritePackets->remove(paramName);
tstellanova's avatar
tstellanova committed
483 484
    }

485
    int missReadCount = 0;
486 487
    foreach (int key, missingReadPackets.keys()) {
        missReadCount +=  missingReadPackets.value(key)->count();
tstellanova's avatar
tstellanova committed
488 489 490
    }

    int missWriteCount = 0;
491 492
    foreach (int key, missingWriteAckPackets.keys()) {
        missWriteCount += missingWriteAckPackets.value(key)->count();
tstellanova's avatar
tstellanova committed
493 494 495
    }

    //TODO simplify this if-else tree
496 497
    if (justWritten) {
        if (!writeMismatch) {
498
            setParameterStatusMsg(tr("SUCCESS: Wrote %2 (#%1/%4): %3 [%5]").arg(paramId+1).arg(paramName).arg(value.toDouble()).arg(paramCount).arg(missWriteCount));
499 500 501 502 503 504
            if (0 == missWriteCount) {
                setParameterStatusMsg(tr("SUCCESS: WROTE ALL PARAMETERS"));
            }
        }
        else  {
            // Mismatch, tell user
505
            setParameterStatusMsg(tr("FAILURE: Wrote %1: sent %2 != onboard %3").arg(paramName).arg(compMissWritePackets->value(paramName).toDouble()).arg(value.toDouble()),
506 507
                                  ParamCommsStatusLevel_Warning);
        }
tstellanova's avatar
tstellanova committed
508 509
    }
    else {
510
        if (missReadCount == 0) {
tstellanova's avatar
tstellanova committed
511 512 513 514 515 516 517
            // Transmission done
            QTime time = QTime::currentTime();
            QString timeString = time.toString();
            setParameterStatusMsg(tr("All received. (updated at %1)").arg(timeString));
        }
        else {
            // Transmission in progress
518 519
            QString val = QString("%1").arg(value.toFloat(), 5, 'f', 1, QChar(' '));
            setParameterStatusMsg(tr("OK: %1 %2 (%3/%4)").arg(paramName).arg(val).arg(paramCount-missReadCount).arg(paramCount),
tstellanova's avatar
tstellanova committed
520
                                  ParamCommsStatusLevel_Warning);
521
            //transmissionMissingPackets
tstellanova's avatar
tstellanova committed
522 523 524 525
        }
    }

    // Check if last parameter was received
526
    if (missReadCount == 0 && missWriteCount == 0) {
527
        resetAfterListReceive();
528
        setRetransmissionGuardEnabled(false);
tstellanova's avatar
tstellanova committed
529 530 531
        //all parameters have been received, broadcast to UI
        emit parameterListUpToDate();
    }
532
    else {
533 534
        //reset the timeout timer since we received one
        setRetransmissionGuardEnabled(true);
535

536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557
        //qDebug() << "missCount:" << missCount << "missWriteCount:" << missWriteCount;
        //if (missCount < 4) {
        //    foreach (int key, transmissionMissingPackets.keys()) {
        //        QList<int>* list = transmissionMissingPackets.value(key);

        //        if (list && list->count()) {
        //            QString yazza = QString().sprintf("Component %d missing %d: ",key,list->count());

        //            for (int i = 0; i < list->count(); i++) {
        //                int val = list->at(i);
        //                yazza.append( QString().sprintf("%d,",val) );
        //            }

        //            qDebug() << yazza;
        //        }
        //        else {
        //            //very suspicious...no actual missing items??
        //            transmissionMissingPackets.remove(key);
        //            break;
        //        }
        //    }
        //}
558
    }
tstellanova's avatar
tstellanova committed
559 560 561 562 563 564 565 566 567 568 569 570 571 572 573
}


void UASParameterCommsMgr::writeParamsToPersistentStorage()
{
    if (mav) {
        mav->writeParametersToStorage(); //TODO track timeout, retransmit etc?
    }
}


void UASParameterCommsMgr::sendPendingParameters()
{
    // Iterate through all components, through all pending parameters and send them to UAS
    int parametersSent = 0;
574
    QMap<int, QMap<QString, QVariant>*>* changedValues = paramDataModel->getAllPendingParams();
tstellanova's avatar
tstellanova committed
575
    QMap<int, QMap<QString, QVariant>*>::iterator i;
576
    for (i = changedValues->begin(); i != changedValues->end(); ++i) {
tstellanova's avatar
tstellanova committed
577
        // Iterate through the parameters of the component
tstellanova's avatar
tstellanova committed
578 579 580 581 582 583 584 585 586
        int compId = i.key();
        QMap<QString, QVariant>* paramList = i.value();
        QMap<QString, QVariant>::iterator j;
        setParameterStatusMsg(tr("%1 pending params for component %2").arg(paramList->count()).arg(compId));

        for (j = paramList->begin(); j != paramList->end(); ++j) {
            //TODO mavlink command for "set parameter list" ?
            setParameter(compId, j.key(), j.value());
            parametersSent++;
tstellanova's avatar
tstellanova committed
587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607
        }
    }

    // Change transmission status if necessary
    if (parametersSent == 0) {
        setParameterStatusMsg(tr("No transmission: No changed values."),ParamCommsStatusLevel_Warning);
    } else {
        setParameterStatusMsg(tr("Transmitting %1 parameters.").arg(parametersSent));
        // Set timeouts
        if (transmissionActive) {
            transmissionTimeout += parametersSent*rewriteTimeout;
        }
        else {
            transmissionActive = true;
            quint64 newTransmissionTimeout = QGC::groundTimeMilliseconds() + parametersSent*rewriteTimeout;
            if (newTransmissionTimeout > transmissionTimeout) {
                transmissionTimeout = newTransmissionTimeout;
            }
        }
        // Enable guard
        setRetransmissionGuardEnabled(true);
608 609

        qDebug() << "Pending parameters now:" << paramDataModel->countPendingParams();
tstellanova's avatar
tstellanova committed
610 611 612
    }
}

613 614 615
UASParameterCommsMgr::~UASParameterCommsMgr()
{
    setRetransmissionGuardEnabled(false);
616 617 618 619 620

    QString ptrStr;
    ptrStr.sprintf("%8p", this);
    qDebug() <<  "UASParameterCommsMgr destructor: " << ptrStr ;

621 622
}