• Alex Wilkinson's avatar
    Correctly set parent of QGCCorePlugin · 1893a920
    Alex Wilkinson authored
    QGCCorePlugin is currently constructed with a QGCToolbox* toolbx parameter of null. This is because at the time QGCCorePlugin (or an actual custom plugin) is constructed app->toolbox() is null.
    _scanAndLoadPlugins() is called as part of the QGCToolbox constructor where all toolbox classes use the same format:
    _class = new Class(app, this);
    
    The creation of QGCCorePlugin should follow the same pattern.
    
    The practical issue I had with this is that because the parent is not set correctly, QGCCorePlugin is not destructed when the app is closed. This means any code in the destructor is not run. (QGCCorePlugin itself has as a destructor which is currently not being called).
    1893a920
Name
Last commit
Last update
.github/ISSUE_TEMPLATE Loading commit data...
VideoReceiverApp Loading commit data...
android Loading commit data...
cmake Loading commit data...
custom-example Loading commit data...
debian Loading commit data...
deploy Loading commit data...
doc Loading commit data...
ios Loading commit data...
libs Loading commit data...
localization Loading commit data...
resources Loading commit data...
snap Loading commit data...
src Loading commit data...
test Loading commit data...
tools Loading commit data...
.ackrc Loading commit data...
.appveyor.yml Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.travis.yml Loading commit data...
.vagrantconfig.yml Loading commit data...
.ycm_extra_conf.py Loading commit data...
CMakeLists.txt Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
CONTRIBUTING.md Loading commit data...
COPYING.md Loading commit data...
CentOS.md Loading commit data...
ChangeLog.md Loading commit data...
CodingStyle.cc Loading commit data...
CodingStyle.h Loading commit data...
CodingStyle.qml Loading commit data...
Custom-Info.plist Loading commit data...
HackAndroidFileDialog.qrc Loading commit data...
HackFileDialog.qrc Loading commit data...
ISSUE_TEMPLATE.md Loading commit data...
Makefile Loading commit data...
PULL_REQUEST_TEMPLATE.md Loading commit data...
QGCCommon.pri Loading commit data...
QGCExternalLibs.pri Loading commit data...
QGCInstaller.pri Loading commit data...
QGCSetup.pri Loading commit data...
README.md Loading commit data...
UnitTest.qrc Loading commit data...
Vagrantfile Loading commit data...
WindowsQGC.ico Loading commit data...
android.pri Loading commit data...
android_environment.sh Loading commit data...
backup-Jenkinsfile Loading commit data...
build_ios.sh Loading commit data...
installheader.bmp Loading commit data...
qgcimages.qrc Loading commit data...
qgcresources.qrc Loading commit data...
qgroundcontrol.pro Loading commit data...
qgroundcontrol.qrc Loading commit data...
qmlglsink.pri Loading commit data...