- 29 Oct, 2015 8 commits
-
-
Don Gagne authored
-
dogmaphobic authored
-
Don Gagne authored
-
Don Gagne authored
-
Daniel Agar authored
-
Daniel Agar authored
-
Daniel Agar authored
-
dogmaphobic authored
-
- 28 Oct, 2015 11 commits
-
-
dogmaphobic authored
-
Don Gagne authored
Too unstable for CI at the moment
-
dogmaphobic authored
-
dogmaphobic authored
-
dogmaphobic authored
-
dogmaphobic authored
-
dogmaphobic authored
-
dogmaphobic authored
-
dogmaphobic authored
It was kind of big...
-
Don Gagne authored
-
Pritam Ghanghas authored
-
- 27 Oct, 2015 21 commits
-
-
dogmaphobic authored
-
Tomaz Canabrava authored
Signed-off-by:
Tomaz Canabrava <tomaz.canabrava@intel.com>
-
Tomaz Canabrava authored
Too used to Kernel Formatting Style. Signed-off-by:
Tomaz Canabrava <tomaz.canabrava@intel.com>
-
Tomaz Canabrava authored
The dock widget opening system had several issues, 1 - it didn't deal with translations 2 - it didn't deal with accelerator keys 3 - it crashed if passed a invalid string (like when using KDE, happened for all options) This new way of using the views are slightly different: 1 - no more string comparissons, use integer comparissons (much faster) 2 - do not use a convoluted if/else - switch simplify. 3 - do not create two different static variable strings for the same stuff 4 - create an enum / an vector of strings (the enums bein an index of it) to acess the correct view. The overall code is clear than the old one, and faster. the only point where the code isn't as clear is on the call to showDockWidgetAction, since we passed a string that had the name of the Widget, but now the action only holds the index for the name in the string vector, I first need to get the correct string and send it. Tested here closing and reopening the app and verifying that the dock widgets that where left open are still open when reopening the application. Signed-off-by:
Tomaz Canabrava <tomaz.canabrava@intel.com>
-
Tomaz Canabrava authored
The text can be translated, the text can have accelerator-special key, so the text is unrealiable. the only thing reliable is the data, wich stores a pointer to a fixed , unmutable, string. Signed-off-by:
Tomaz Canabrava <tomaz.canabrava@intel.com>
-
Tomaz Canabrava authored
We where passing the QActions untranslated. Signed-off-by:
Tomaz Canabrava <tomaz.canabrava@intel.com>
-
Tomaz Canabrava authored
Since the Static const char * items are private and nothing should access them besides the MainWindow class, declare them inside of the .cpp file with static linkage, this way a few good things happen: they are not exported as symbols to any other class (not even with private linkage) and also if we need to add a new one, on the .cpp, the only compiled file will be the cpp, instead of the tons of files that include mainwindow.h Signed-off-by:
Tomaz Canabrava <tomaz.canabrava@intel.com>
-
Tomaz Canabrava authored
If you choosed View->Fullscreen, the app would go to fullscreen, but if you then go again to View->Fullscreen, the app would still be fullscreen but the menu item would be unselected - leaving UI and settings inconsistent. Signed-off-by:
Tomaz Canabrava <tomaz.canabrava@intel.com>
-
Tomaz Canabrava authored
qobject_cast doesn't use RTTI to figure out the type, it uses an internally stored relationship, wich is much faster than RTTI. I grepped the code for dynamic_cast and there are lots besides this one, so I'll later try to figure out wich ones are QObject inheritances and change acordingly. Signed-off-by:
Tomaz Canabrava <tomaz.canabrava@intel.com>
-
Don Gagne authored
-
dogmaphobic authored
-
Don Gagne authored
-
dogmaphobic authored
-
dogmaphobic authored
-
Don Gagne authored
-
Don Gagne authored
-
dogmaphobic authored
-
dogmaphobic authored
-
David Goodman authored
-
David Goodman authored
-
David Goodman authored
-