Fix dangling pointer access

ed6d4bd4 · Stefan Dunca · e706b4c4 · ed6d4bd4
Commit ed6d4bd4 authored Jun 28, 2019 by Stefan Dunca
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

Vehicle.cc src/Vehicle/Vehicle.cc +4 -1

No files found.
--- a/src/Vehicle/Vehicle.cc
+++ b/src/Vehicle/Vehicle.cc
@@ -551,8 +551,11 @@ Vehicle::~Vehicle()
 void Vehicle::prepareDelete()
 {
    if(_cameras) {
-        delete _cameras;
+        // because of _cameras QML bindings check for nullptr won't work in the binding pipeline
+        // the dangling pointer access will cause a runtime fault
+        auto tmpCameras = _cameras;
        _cameras = nullptr;
+        delete tmpCameras;
        emit dynamicCamerasChanged();
        qApp->processEvents();
    }