Merge pull request #1073 from DonLakeFlyer/activeUASSet

Remove multiple overrides of activeUASSet signal

src/qgcunittest/MockUASManager.cc

@@ -50,7 +50,6 @@ void MockUASManager::setMockActiveUAS(MockUAS* mockUAS)
     {
         // We don't support swiching between different UAS
         //_mockUAS->setSelected();
-        emit activeUASSet(_mockUAS->getUASID());
         emit activeUASStatusChanged(_mockUAS, true);
         emit activeUASStatusChanged(_mockUAS->getUASID(), true);
     }

src/qgcunittest/MockUASManager.h

@@ -41,7 +41,6 @@ class MockUASManager : public UASManagerInterface
 signals:
     // The following signals from UASManager interface are supported:
     //      void activeUASSet(UASInterface* UAS);
-    //      void activeUASSet(int systemId);
     //      void activeUASStatusChanged(UASInterface* UAS, bool active);
     //      void activeUASStatusChanged(int systemId, bool active);
     

src/uas/UASManager.cc

@@ -473,7 +473,6 @@ void UASManager::setActiveUAS(UASInterface* uas)
     if (activeUAS)
     {
         activeUAS->setSelected();
-        emit activeUASSet(activeUAS->getUASID());
         emit activeUASSetListIndex(systems.indexOf(activeUAS));
         emit activeUASStatusChanged(activeUAS, true);
         emit activeUASStatusChanged(activeUAS->getUASID(), true);

src/uas/UASManagerInterface.h

@@ -105,8 +105,6 @@ signals:
     /** @brief The UAS currently under main operator control changed */
     void activeUASSet(UASInterface* UAS);
     /** @brief The UAS currently under main operator control changed */
-    void activeUASSet(int systemId);
-    /** @brief The UAS currently under main operator control changed */
     void activeUASSetListIndex(int listIndex);
     /** @brief The UAS currently under main operator control changed */
     void activeUASStatusChanged(UASInterface* UAS, bool active);

src/ui/QGCWaypointListMulti.cc

@@ -9,8 +9,8 @@ QGCWaypointListMulti::QGCWaypointListMulti(QWidget *parent) :
 {
     ui->setupUi(this);
     setMinimumSize(600, 80);
-    connect(UASManager::instance(), SIGNAL(UASCreated(UASInterface*)), this, SLOT(systemCreated(UASInterface*)));
-    connect(UASManager::instance(), SIGNAL(activeUASSet(int)), this, SLOT(systemSetActive(int)));
+    connect(UASManager::instance(), &UASManager::UASCreated, this, &QGCWaypointListMulti::systemCreated);
+    connect(UASManager::instance(), &UASManager::activeUASSet, this, &QGCWaypointListMulti::systemSetActive);
 
     WaypointList* list = new WaypointList(ui->stackedWidget, UASManager::instance()->getActiveUASWaypointManager());
     lists.insert(offline_uas_id, list);
@@ -18,7 +18,7 @@ QGCWaypointListMulti::QGCWaypointListMulti(QWidget *parent) :
 
     if (UASManager::instance()->getActiveUAS()) {
         systemCreated(UASManager::instance()->getActiveUAS());
-        systemSetActive(UASManager::instance()->getActiveUAS()->getUASID());
+        systemSetActive(UASManager::instance()->getActiveUAS());
     }
 
 }
@@ -50,9 +50,9 @@ void QGCWaypointListMulti::systemCreated(UASInterface* uas)
     connect(uas, SIGNAL(destroyed(QObject*)), this, SLOT(systemDeleted(QObject*)));
 }
 
-void QGCWaypointListMulti::systemSetActive(int uas)
+void QGCWaypointListMulti::systemSetActive(UASInterface* uas)
 {
-    WaypointList* list = lists.value(uas, NULL);
+    WaypointList* list = lists.value(uas->getUASID(), NULL);
     if (list) {
         ui->stackedWidget->setCurrentWidget(list);
     }

src/ui/QGCWaypointListMulti.h

@@ -23,7 +23,7 @@ public:
 public slots:
     void systemDeleted(QObject* uas);
     void systemCreated(UASInterface* uas);
-    void systemSetActive(int uas);
+    void systemSetActive(UASInterface* uas);
 
 protected:
     quint16 offline_uas_id;

src/ui/linechart/Linecharts.cc

@@ -18,10 +18,7 @@ Linecharts::Linecharts(QWidget *parent) :
     foreach (UASInterface* sys, systems) {
         addSystem(sys);
     }
-    connect(UASManager::instance(), SIGNAL(UASCreated(UASInterface*)),
-            this, SLOT(addSystem(UASInterface*)));
-    connect(UASManager::instance(), SIGNAL(activeUASSet(int)),
-            this, SLOT(selectSystem(int)));
+    connect(UASManager::instance(), &UASManager::UASCreated, this, &Linecharts::addSystem);
 }
 
 void Linecharts::showEvent(QShowEvent* event)
@@ -59,32 +56,6 @@ void Linecharts::hideEvent(QHideEvent* event)
     emit visibilityChanged(false);
 }
 
-void Linecharts::selectSystem(int systemid)
-{
-	Q_UNUSED(systemid);
-//    QWidget* prevWidget = currentWidget();
-//    if (prevWidget)
-//    {
-//        LinechartWidget* chart = dynamic_cast<LinechartWidget*>(prevWidget);
-//        if (chart)
-//        {
-//            chart->setActive(false);
-//            chart->setActiveSystem(systemid);
-//        }
-//    }
-//    QWidget* widget = plots.value(systemid, NULL);
-//    if (widget)
-//    {
-//        setCurrentWidget(widget);
-//        LinechartWidget* chart = dynamic_cast<LinechartWidget*>(widget);
-//        if (chart)
-//        {
-//            chart->setActive(true);
-//            chart->setActiveSystem(systemid);
-//        }
-//    }
-}
-
 void Linecharts::addSystem(UASInterface* uas)
 {
     // FIXME Add removeSystem() call

src/ui/linechart/Linecharts.h

@@ -20,8 +20,6 @@ signals:
     void visibilityChanged(bool visible);
 
 public slots:
-    /** @brief Select plot for one system */
-    void selectSystem(int systemid);
     /** @brief Add a new system to the list of plots */
     void addSystem(UASInterface* uas);
     /** @brief Add a new generic message source (not a system) */