Commit a3490362 authored by Don Gagne's avatar Don Gagne Committed by GitHub

Merge pull request #5546 from DonLakeFlyer/ForceSaveResetDefaultAdvanced

Parameter force save and default disabled in non-advanced mode
parents bb25081b d2b7b785
...@@ -36,7 +36,7 @@ QGCTextField { ...@@ -36,7 +36,7 @@ QGCTextField {
fact.value = text fact.value = text
} else { } else {
_validateString = text _validateString = text
qgcView.showDialog(validationErrorDialogComponent, qsTr("Invalid Value"), qgcView.showDialogDefaultWidth, StandardButton.Save) qgcView.showDialog(validationErrorDialogComponent, qsTr("Invalid Value"), qgcView.showDialogDefaultWidth, StandardButton.Save | StandardButton.Cancel)
} }
} else { } else {
fact.value = text fact.value = text
......
...@@ -11,6 +11,7 @@ import QtQuick 2.3 ...@@ -11,6 +11,7 @@ import QtQuick 2.3
import QtQuick.Controls 1.2 import QtQuick.Controls 1.2
import QtQuick.Layouts 1.2 import QtQuick.Layouts 1.2
import QGroundControl 1.0
import QGroundControl.Controls 1.0 import QGroundControl.Controls 1.0
import QGroundControl.Palette 1.0 import QGroundControl.Palette 1.0
import QGroundControl.Controllers 1.0 import QGroundControl.Controllers 1.0
...@@ -28,6 +29,9 @@ QGCViewDialog { ...@@ -28,6 +29,9 @@ QGCViewDialog {
property real _editFieldWidth: ScreenTools.defaultFontPixelWidth * 20 property real _editFieldWidth: ScreenTools.defaultFontPixelWidth * 20
property bool _longDescriptionAvailable: fact.longDescription != "" property bool _longDescriptionAvailable: fact.longDescription != ""
property bool _editingParameter: fact.componentId != 0
property bool _allowForceSave: QGroundControl.corePlugin.showAdvancedUI || !_editingParameter
property bool _allowDefaultReset: fact.defaultValueAvailable && (QGroundControl.corePlugin.showAdvancedUI || !_editingParameter)
ParameterEditorController { id: controller; factPanel: parent } ParameterEditorController { id: controller; factPanel: parent }
...@@ -49,11 +53,18 @@ QGCViewDialog { ...@@ -49,11 +53,18 @@ QGCViewDialog {
hideDialog() hideDialog()
} else { } else {
validationError.text = errorString validationError.text = errorString
forceSave.visible = true if (_allowForceSave) {
forceSave.visible = true
}
} }
} }
} }
function reject() {
fact.valueChanged(fact.value)
hideDialog();
}
function bitmaskValue() { function bitmaskValue() {
var value = 0; var value = 0;
for (var i = 0; i < fact.bitmaskValues.length; ++i) { for (var i = 0; i < fact.bitmaskValues.length; ++i) {
...@@ -68,7 +79,9 @@ QGCViewDialog { ...@@ -68,7 +79,9 @@ QGCViewDialog {
Component.onCompleted: { Component.onCompleted: {
if (validate) { if (validate) {
validationError.text = fact.validate(validateValue, false /* convertOnly */) validationError.text = fact.validate(validateValue, false /* convertOnly */)
forceSave.visible = true if (_allowForceSave) {
forceSave.visible = true
}
} }
} }
...@@ -109,7 +122,7 @@ QGCViewDialog { ...@@ -109,7 +122,7 @@ QGCViewDialog {
QGCButton { QGCButton {
anchors.baseline: valueField.baseline anchors.baseline: valueField.baseline
visible: fact.defaultValueAvailable visible: _allowDefaultReset
text: qsTr("Reset to default") text: qsTr("Reset to default")
onClicked: { onClicked: {
...@@ -195,7 +208,7 @@ QGCViewDialog { ...@@ -195,7 +208,7 @@ QGCViewDialog {
QGCLabel { QGCLabel {
text: qsTr("Default: ") + fact.defaultValueString text: qsTr("Default: ") + fact.defaultValueString
visible: fact.defaultValueAvailable visible: _allowDefaultReset
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment