Commit 90fb522e authored by Don Gagne's avatar Don Gagne

No need to call UnitTest::[init|cleanup]TestCase

parent 6592a881
...@@ -31,21 +31,11 @@ ...@@ -31,21 +31,11 @@
UT_REGISTER_TEST(MessageBoxTest) UT_REGISTER_TEST(MessageBoxTest)
MessageBoxTest::MessageBoxTest(void) : MessageBoxTest::MessageBoxTest(void)
_expectMissedMessageBox(false)
{ {
} }
void MessageBoxTest::cleanup(void)
{
if (_expectMissedMessageBox) {
_expectMissedMessageBox = false;
QEXPECT_FAIL("", "Supposed to fail in cleanup with a missed message box", Continue);
}
UnitTest::cleanup();
}
void MessageBoxTest::_messageBoxExpected_test(void) void MessageBoxTest::_messageBoxExpected_test(void)
{ {
setExpectedMessageBox(QMessageBox::Ok); setExpectedMessageBox(QMessageBox::Ok);
...@@ -57,7 +47,7 @@ void MessageBoxTest::_messageBoxExpected_test(void) ...@@ -57,7 +47,7 @@ void MessageBoxTest::_messageBoxExpected_test(void)
void MessageBoxTest::_messageBoxUnexpected_test(void) void MessageBoxTest::_messageBoxUnexpected_test(void)
{ {
// This should cause the test to fail in the cleanup method // This should cause an expected failure in the cleanup method
QGCMessageBox::information(QString(), QString()); QGCMessageBox::information(QString(), QString());
_expectMissedMessageBox = true; _expectMissedMessageBox = true;
} }
...@@ -75,7 +65,7 @@ void MessageBoxTest::_previousMessageBox_test(void) ...@@ -75,7 +65,7 @@ void MessageBoxTest::_previousMessageBox_test(void)
void MessageBoxTest::_noMessageBox_test(void) void MessageBoxTest::_noMessageBox_test(void)
{ {
setExpectedMessageBox(QMessageBox::Ok); setExpectedMessageBox(QMessageBox::Ok);
checkExpectedMessageBox(expectFailNoMessageBox); checkExpectedMessageBox(expectFailNoDialog);
} }
void MessageBoxTest::_badResponseButton_test(void) void MessageBoxTest::_badResponseButton_test(void)
......
...@@ -39,16 +39,11 @@ public: ...@@ -39,16 +39,11 @@ public:
MessageBoxTest(void); MessageBoxTest(void);
private slots: private slots:
void cleanup(void);
void _messageBoxExpected_test(void); void _messageBoxExpected_test(void);
void _messageBoxUnexpected_test(void); void _messageBoxUnexpected_test(void);
void _previousMessageBox_test(void); void _previousMessageBox_test(void);
void _noMessageBox_test(void); void _noMessageBox_test(void);
void _badResponseButton_test(void); void _badResponseButton_test(void);
private:
bool _expectMissedMessageBox;
}; };
#endif #endif
...@@ -139,8 +139,6 @@ PX4RCCalibrationTest::PX4RCCalibrationTest(void) : ...@@ -139,8 +139,6 @@ PX4RCCalibrationTest::PX4RCCalibrationTest(void) :
/// @brief Called one time before any test cases are run. /// @brief Called one time before any test cases are run.
void PX4RCCalibrationTest::initTestCase(void) void PX4RCCalibrationTest::initTestCase(void)
{ {
UnitTest::initTestCase();
// Validate that our function to channel mapping is still correct. // Validate that our function to channel mapping is still correct.
for (int function=0; function<PX4RCCalibration::rcCalFunctionMax; function++) { for (int function=0; function<PX4RCCalibration::rcCalFunctionMax; function++) {
int chanIndex = _rgFunctionChannelMap[function]; int chanIndex = _rgFunctionChannelMap[function];
......
...@@ -42,8 +42,6 @@ QGCUASFileManagerUnitTest::QGCUASFileManagerUnitTest(void) : ...@@ -42,8 +42,6 @@ QGCUASFileManagerUnitTest::QGCUASFileManagerUnitTest(void) :
// Called once before all test cases are run // Called once before all test cases are run
void QGCUASFileManagerUnitTest::initTestCase(void) void QGCUASFileManagerUnitTest::initTestCase(void)
{ {
UnitTest::initTestCase();
_mockUAS.setMockSystemId(_systemIdServer); _mockUAS.setMockSystemId(_systemIdServer);
_mockUAS.setMockMavlinkPlugin(&_mockFileServer); _mockUAS.setMockMavlinkPlugin(&_mockFileServer);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment