Remove obsolete AutomaticMissionUpload

src/Settings/App.SettingsGroup.json

@@ -116,13 +116,6 @@
     "type":             "bool",
     "defaultValue":     false
 },
-{
-    "name":             "AutomaticMissionUpload",
-    "shortDescription": "Automatic mission upload",
-    "longDescription":  "Automatically upload mission to vehicle after changes",
-    "type":             "bool",
-    "defaultValue":     true
-},
 {
     "name":             "SavePath",
     "shortDescription": "Application save directory",

src/Settings/AppSettings.cc

@@ -31,7 +31,6 @@ const char* AppSettings::indoorPaletteName =                            "StyleIs
 const char* AppSettings::showLargeCompassName =                         "ShowLargeCompass";
 const char* AppSettings::savePathName =                                 "SavePath";
 const char* AppSettings::autoLoadMissionsName =                         "AutoLoadMissions";
-const char* AppSettings::automaticMissionUploadName =                   "AutomaticMissionUpload";
 
 const char* AppSettings::parameterFileExtension =   "params";
 const char* AppSettings::planFileExtension =        "plan";
@@ -62,7 +61,6 @@ AppSettings::AppSettings(QObject* parent)
     , _showLargeCompassFact(NULL)
     , _savePathFact(NULL)
     , _autoLoadMissionsFact(NULL)
-    , _automaticMissionUpload(NULL)
 {
     QQmlEngine::setObjectOwnership(this, QQmlEngine::CppOwnership);
     qmlRegisterUncreatableType<AppSettings>("QGroundControl.SettingsManager", 1, 0, "AppSettings", "Reference only");
@@ -280,15 +278,6 @@ Fact* AppSettings::autoLoadMissions(void)
     return _autoLoadMissionsFact;
 }
 
-Fact* AppSettings::automaticMissionUpload(void)
-{
-    if (!_automaticMissionUpload) {
-        _automaticMissionUpload = _createSettingsFact(automaticMissionUploadName);
-    }
-
-    return _automaticMissionUpload;
-}
-
 MAV_AUTOPILOT AppSettings::offlineEditingFirmwareTypeFromFirmwareType(MAV_AUTOPILOT firmwareType)
 {
     if (firmwareType != MAV_AUTOPILOT_PX4 && firmwareType != MAV_AUTOPILOT_ARDUPILOTMEGA) {

src/Settings/AppSettings.h

@@ -35,7 +35,6 @@ public:
     Q_PROPERTY(Fact* showLargeCompass                   READ showLargeCompass                   CONSTANT)
     Q_PROPERTY(Fact* savePath                           READ savePath                           CONSTANT)
     Q_PROPERTY(Fact* autoLoadMissions                   READ autoLoadMissions                   CONSTANT)
-    Q_PROPERTY(Fact* automaticMissionUpload             READ automaticMissionUpload             CONSTANT)
 
     Q_PROPERTY(QString missionSavePath      READ missionSavePath    NOTIFY savePathsChanged)
     Q_PROPERTY(QString parameterSavePath    READ parameterSavePath  NOTIFY savePathsChanged)
@@ -62,7 +61,6 @@ public:
     Fact* showLargeCompass                  (void);
     Fact* savePath                          (void);
     Fact* autoLoadMissions                  (void);
-    Fact* automaticMissionUpload            (void);
 
     QString missionSavePath     (void);
     QString parameterSavePath   (void);
@@ -88,7 +86,6 @@ public:
     static const char* showLargeCompassName;
     static const char* savePathName;
     static const char* autoLoadMissionsName;
-    static const char* automaticMissionUploadName;
 
     // Application wide file extensions
     static const char* parameterFileExtension;
@@ -127,7 +124,6 @@ private:
     SettingsFact* _showLargeCompassFact;
     SettingsFact* _savePathFact;
     SettingsFact* _autoLoadMissionsFact;
-    SettingsFact* _automaticMissionUpload;
 };
 
 #endif