Use parsebin for automatic stream demuxing and parsing; Automatically insert...

Use parsebin for automatic stream demuxing and parsing; Automatically insert rtpjitterbuffer for RTP streams to avoid video stuttering

custom-example/src/CustomVideoManager.cc

@@ -24,16 +24,6 @@ CustomVideoManager::_updateSettings()
 {
     if(!_videoSettings || !_videoReceiver)
         return;
-    //-- Check encoding
-    if(_activeVehicle && _activeVehicle->dynamicCameras()) {
-        auto* pCamera = qobject_cast<CustomCameraControl*>(_activeVehicle->dynamicCameras()->currentCameraInstance());
-        if(pCamera) {
-            Fact *fact = pCamera->videoEncoding();
-            if (fact) {
-                _videoReceiver->setVideoDecoder(static_cast<VideoReceiver::VideoEncoding>(fact->rawValue().toInt()));
-            }
-        }
-    }
     VideoManager::_updateSettings();
 }
 

custom-example/src/FirmwarePlugin/CustomCameraControl.cc

@@ -19,7 +19,6 @@ QGC_LOGGING_CATEGORY(CustomCameraVerboseLog, "CustomCameraVerboseLog")
 
 static const char* kCAM_IRPALETTE            = "CAM_IRPALETTE";
 static const char* kCAM_NEXTVISION_IRPALETTE = "IR_SENS_POL";
-static const char* kCAM_ENC                  = "CAM_ENC";
 
 //-----------------------------------------------------------------------------
 CustomCameraControl::CustomCameraControl(const mavlink_camera_information_t *info, Vehicle* vehicle, int compID, QObject* parent)
@@ -117,13 +116,6 @@ CustomCameraControl::irPalette()
     return nullptr;
 }
 
-//-----------------------------------------------------------------------------
-Fact*
-CustomCameraControl::videoEncoding()
-{
-    return _paramComplete ? getFact(kCAM_ENC) : nullptr;
-}
-
 //-----------------------------------------------------------------------------
 void
 CustomCameraControl::setThermalMode(ThermalViewMode mode)

custom-example/src/FirmwarePlugin/CustomCameraControl.h

@@ -29,10 +29,8 @@ public:
     CustomCameraControl(const mavlink_camera_information_t* info, Vehicle* vehicle, int compID, QObject* parent = nullptr);
 
     Q_PROPERTY(Fact*        irPalette       READ    irPalette           NOTIFY parametersReady)
-    Q_PROPERTY(Fact*        videoEncoding   READ    videoEncoding       NOTIFY parametersReady)
 
     Fact*       irPalette           ();
-    Fact*       videoEncoding       ();
 
     bool        takePhoto           () override;
     bool        stopTakePhoto       () override;

src/FlightDisplay/VideoManager.cc

@@ -345,13 +345,6 @@ VideoManager::_makeVideoSink(gpointer widget)
 
         g_object_set(qmlglsink, "widget", widget, NULL);
 
-// FIXME: AV: temporally disable any sort of QoS due to unknow (yet) timing issues
-#if defined(__android__) || defined(__ios__)
-        //g_object_set(qmlglsink, "max-lateness", -1, NULL);
-        g_object_set(qmlglsink, "qos", FALSE, NULL);
-        g_object_set(qmlglsink, "sync", FALSE, NULL);
-#endif
-
         if ((bin = gst_bin_new("videosink")) == nullptr) {
             qCritical() << "VideoManager::_makeVideoSink() failed. Error with gst_bin_new('videosink')";
             break;

src/VideoStreaming/VideoReceiver.h

@@ -32,12 +32,6 @@ class VideoReceiver : public QObject
 {
     Q_OBJECT
 public:
-    enum VideoEncoding {
-        H264_SW = 1,
-        H264_HW = 2,
-        H265_SW = 3,
-        H265_HW = 4
-    };
 
 #if defined(QGC_GST_STREAMING)
     Q_PROPERTY(bool             recording           READ    recording           NOTIFY recordingChanged)
@@ -63,7 +57,6 @@ public:
 
     virtual void        setShowFullScreen   (bool show) { _showFullScreen = show; emit showFullScreenChanged(); }
 
-    void                  setVideoDecoder   (VideoEncoding encoding);
 #if defined(QGC_GST_STREAMING)
     void                  setVideoSink      (GstElement* videoSink);
 #endif
@@ -91,6 +84,7 @@ public slots:
 protected slots:
     virtual void _updateTimer               ();
 #if defined(QGC_GST_STREAMING)
+    GstElement*  _makeSource                (const QString& uri);
     virtual void _restart_timeout           ();
     virtual void _tcp_timeout               ();
     virtual void _connected                 ();