QGCUASFileManagerTest.cc 15.2 KB
Newer Older
Don Gagne's avatar
Don Gagne committed
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26
/*=====================================================================
 
 QGroundControl Open Source Ground Control Station
 
 (c) 2009 - 2014 QGROUNDCONTROL PROJECT <http://www.qgroundcontrol.org>
 
 This file is part of the QGROUNDCONTROL project
 
 QGROUNDCONTROL is free software: you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
 the Free Software Foundation, either version 3 of the License, or
 (at your option) any later version.
 
 QGROUNDCONTROL is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU General Public License for more details.
 
 You should have received a copy of the GNU General Public License
 along with QGROUNDCONTROL. If not, see <http://www.gnu.org/licenses/>.
 
 ======================================================================*/

#include "QGCUASFileManagerTest.h"

/// @file
27 28 29
///     @brief QGCUASFileManager unit test. Note: All code here assumes all work between
///             the unit test, mack mavlink file server and file manager is happening on
///             the same thread.
Don Gagne's avatar
Don Gagne committed
30 31 32
///
///     @author Don Gagne <don@thegagnes.com>

Don Gagne's avatar
Don Gagne committed
33 34
UT_REGISTER_TEST(QGCUASFileManagerUnitTest)

Don Gagne's avatar
Don Gagne committed
35
QGCUASFileManagerUnitTest::QGCUASFileManagerUnitTest(void) :
36
    _mockFileServer(_systemIdQGC, _systemIdServer),
Don Gagne's avatar
Don Gagne committed
37 38 39 40 41 42 43 44
    _fileManager(NULL),
    _multiSpy(NULL)
{
}

// Called once before all test cases are run
void QGCUASFileManagerUnitTest::initTestCase(void)
{
45
    _mockUAS.setMockSystemId(_systemIdServer);
Don Gagne's avatar
Don Gagne committed
46 47 48 49 50 51
    _mockUAS.setMockMavlinkPlugin(&_mockFileServer);
}

// Called before every test case
void QGCUASFileManagerUnitTest::init(void)
{
Don Gagne's avatar
Don Gagne committed
52 53
    UnitTest::init();
    
Don Gagne's avatar
Don Gagne committed
54 55
    Q_ASSERT(_multiSpy == NULL);
    
56
    _fileManager = new QGCUASFileManager(NULL, &_mockUAS, _systemIdQGC);
Don Gagne's avatar
Don Gagne committed
57 58
    Q_CHECK_PTR(_fileManager);
    
59 60 61 62
    // Reset any internal state back to normal
    _mockFileServer.setErrorMode(MockMavlinkFileServer::errModeNone);
    _fileListReceived.clear();
    
63
    connect(&_mockFileServer, &MockMavlinkFileServer::messageReceived, _fileManager, &QGCUASFileManager::receiveMessage);
Don Gagne's avatar
Don Gagne committed
64

65
    connect(_fileManager, &QGCUASFileManager::listEntry, this, &QGCUASFileManagerUnitTest::listEntry);
Don Gagne's avatar
Don Gagne committed
66

67
    _rgSignals[listEntrySignalIndex] = SIGNAL(listEntry(const QString&));
68
    _rgSignals[listCompleteSignalIndex] = SIGNAL(listComplete(void));
69 70 71

    _rgSignals[downloadFileLengthSignalIndex] = SIGNAL(downloadFileLength(unsigned int));
    _rgSignals[downloadFileCompleteSignalIndex] = SIGNAL(downloadFileComplete(void));
Don Gagne's avatar
Don Gagne committed
72
    
73 74
    _rgSignals[errorMessageSignalIndex] = SIGNAL(errorMessage(const QString&));

Don Gagne's avatar
Don Gagne committed
75 76 77 78 79 80 81 82
    _multiSpy = new MultiSignalSpy();
    Q_CHECK_PTR(_multiSpy);
    QCOMPARE(_multiSpy->init(_fileManager, _rgSignals, _cSignals), true);
}

// Called after every test case
void QGCUASFileManagerUnitTest::cleanup(void)
{
Don Gagne's avatar
Don Gagne committed
83 84
    UnitTest::cleanup();
    
Don Gagne's avatar
Don Gagne committed
85 86 87 88 89 90 91 92 93 94
    Q_ASSERT(_multiSpy);
    Q_ASSERT(_fileManager);
    
    delete _fileManager;
    delete _multiSpy;
    
    _fileManager = NULL;
    _multiSpy = NULL;
}

95 96
/// @brief Connected to QGCUASFileManager listEntry signal in order to catch list entries
void QGCUASFileManagerUnitTest::listEntry(const QString& entry)
Don Gagne's avatar
Don Gagne committed
97 98
{
    // Keep a list of all names received so we can test it for correctness
99
    _fileListReceived += entry;
Don Gagne's avatar
Don Gagne committed
100 101 102 103 104 105 106 107 108 109 110 111
}


void QGCUASFileManagerUnitTest::_ackTest(void)
{
    Q_ASSERT(_fileManager);
    Q_ASSERT(_multiSpy);
    Q_ASSERT(_multiSpy->checkNoSignals() == true);
    
    // If the file manager doesn't receive an ack it will timeout and emit an error. So make sure
    // we don't get any error signals.
    QVERIFY(_fileManager->_sendCmdTestAck());
112
    QTest::qWait(_ackTimerTimeoutMsecs); // Let the file manager timeout
Don Gagne's avatar
Don Gagne committed
113
    QVERIFY(_multiSpy->checkNoSignals());
114
    
115
    // Setup for no response from ack. This should cause a timeout error
116 117 118 119
    _mockFileServer.setErrorMode(MockMavlinkFileServer::errModeNoResponse);
    QVERIFY(_fileManager->_sendCmdTestAck());
    QTest::qWait(_ackTimerTimeoutMsecs); // Let the file manager timeout
    QCOMPARE(_multiSpy->checkOnlySignalByMask(errorMessageSignalMask), true);
120 121 122 123 124 125 126
    _multiSpy->clearAllSignals();

    // Setup for a bad sequence number in the ack. This should cause an error;
    _mockFileServer.setErrorMode(MockMavlinkFileServer::errModeBadSequence);
    QVERIFY(_fileManager->_sendCmdTestAck());
    QCOMPARE(_multiSpy->checkOnlySignalByMask(errorMessageSignalMask), true);
    _multiSpy->clearAllSignals();
Don Gagne's avatar
Don Gagne committed
127 128 129 130 131 132 133 134 135 136
}

void QGCUASFileManagerUnitTest::_noAckTest(void)
{
    Q_ASSERT(_fileManager);
    Q_ASSERT(_multiSpy);
    Q_ASSERT(_multiSpy->checkNoSignals() == true);
    
    // This should not get the ack back and timeout.
    QVERIFY(_fileManager->_sendCmdTestNoAck());
137
    QTest::qWait(_ackTimerTimeoutMsecs); // Let the file manager timeout
Don Gagne's avatar
Don Gagne committed
138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158
    QCOMPARE(_multiSpy->checkOnlySignalByMask(errorMessageSignalMask), true);
}

void QGCUASFileManagerUnitTest::_resetTest(void)
{
    Q_ASSERT(_fileManager);
    Q_ASSERT(_multiSpy);
    Q_ASSERT(_multiSpy->checkNoSignals() == true);
    
    // Send a reset command
    //  We should not get any signals back from this
    QVERIFY(_fileManager->_sendCmdReset());
    QVERIFY(_multiSpy->checkNoSignals());
}

void QGCUASFileManagerUnitTest::_listTest(void)
{
    Q_ASSERT(_fileManager);
    Q_ASSERT(_multiSpy);
    Q_ASSERT(_multiSpy->checkNoSignals() == true);
    
159
    // QGCUASFileManager::listDirectory signalling as follows:
160
    //  Emits a listEntry signal for each list entry
161 162 163 164 165
    //  Emits an errorMessage signal if:
    //      It gets a Nak back
    //      Sequence number is incorrrect on any response
    //      CRC is incorrect on any responses
    //      List entry is formatted incorrectly
166
    //  It is possible to get a number of good listEntry signals, followed by an errorMessage signal
167 168 169
    //  Emits listComplete after it receives the final list entry
    //      If an errorMessage signal is signalled no listComplete is signalled
    
Don Gagne's avatar
Don Gagne committed
170 171 172
    // Send a bogus path
    //  We should get a single resetStatusMessages signal
    //  We should get a single errorMessage signal
173
    _fileManager->listDirectory("/bogus");
174
    QCOMPARE(_multiSpy->checkOnlySignalByMask(errorMessageSignalMask), true);
Don Gagne's avatar
Don Gagne committed
175 176
    _multiSpy->clearAllSignals();

177
    // Setup the mock file server with a valid directory list
Don Gagne's avatar
Don Gagne committed
178 179 180 181
    QStringList fileList;
    fileList << "Ddir" << "Ffoo" << "Fbar";
    _mockFileServer.setFileList(fileList);
    
182 183 184 185 186 187 188 189 190 191 192 193 194
    // Run through the various server side failure modes
    for (size_t i=0; i<MockMavlinkFileServer::cFailureModes; i++) {
        MockMavlinkFileServer::ErrorMode_t errMode = MockMavlinkFileServer::rgFailureModes[i];
        qDebug() << "Testing failure mode:" << errMode;
        _mockFileServer.setErrorMode(errMode);
        
        _fileManager->listDirectory("/");
        QTest::qWait(_ackTimerTimeoutMsecs); // Let the file manager timeout
        
        if (errMode == MockMavlinkFileServer::errModeNoSecondResponse || errMode == MockMavlinkFileServer::errModeNakSecondResponse) {
            // For simulated server errors on subsequent Acks, the first Ack will go through. This means we should have gotten some
            // partial results. In the case of the directory list test set, all entries fit into the first ack, so we should have
            // gotten back all of them.
195 196
            QCOMPARE(_multiSpy->getSpyByIndex(listEntrySignalIndex)->count(), fileList.count());
            _multiSpy->clearSignalByIndex(listEntrySignalIndex);
197 198
            
            // And then it should have errored out because the next list Request would have failed.
199
            QCOMPARE(_multiSpy->checkOnlySignalByMask(errorMessageSignalMask), true);
200 201 202
        } else {
            // For the simulated errors which failed the intial response we should not have gotten any results back at all.
            // Just an error.
203
            QCOMPARE(_multiSpy->checkOnlySignalByMask(errorMessageSignalMask), true);
204 205 206 207 208 209 210 211
        }

        // Set everything back to initial state
        _fileListReceived.clear();
        _multiSpy->clearAllSignals();
        _mockFileServer.setErrorMode(MockMavlinkFileServer::errModeNone);
    }

212
    // Send a list command at the root of the directory tree which should succeed    
213
    _fileManager->listDirectory("/");
214
    QCOMPARE(_multiSpy->checkSignalByMask(listCompleteSignalMask), true);
215
    QCOMPARE(_multiSpy->checkNoSignalByMask(errorMessageSignalMask), true);
216
    QCOMPARE(_multiSpy->getSpyByIndex(listEntrySignalIndex)->count(), fileList.count());
217
    QVERIFY(_fileListReceived == fileList);
Don Gagne's avatar
Don Gagne committed
218
}
219 220 221 222

void QGCUASFileManagerUnitTest::_validateFileContents(const QString& filePath, uint8_t length)
{
    QFile file(filePath);
223 224 225 226 227

    // Make sure file size is correct
    QCOMPARE(file.size(), (qint64)length);

    // Read data
228 229 230 231
    QVERIFY(file.open(QIODevice::ReadOnly));
    QByteArray bytes = file.readAll();
    file.close();
    
232 233
    // Validate file contents:
    //      Repeating 0x00, 0x01 .. 0xFF until file is full
234 235
    for (uint8_t i=0; i<bytes.length(); i++) {
        QCOMPARE((uint8_t)bytes[i], (uint8_t)(i & 0xFF));
236 237 238
    }
}

239
void QGCUASFileManagerUnitTest::_downloadTest(void)
240 241 242 243 244
{
    Q_ASSERT(_fileManager);
    Q_ASSERT(_multiSpy);
    Q_ASSERT(_multiSpy->checkNoSignals() == true);
    
245 246 247 248
    // QGCUASFileManager::downloadPath works as follows:
    //  Sends an Open Command to the server
    //      Expects an Ack Response back from the server with the correct sequence numner
    //          Emits an errorMessage signal if it gets a Nak back
249
    //      Emits an downloadFileLength signal with the file length if it gets back a good Ack
250
    //  Sends subsequent Read commands to the server until it gets the full file contents back
251
    //      Emits a downloadFileProgress for each read command ack it gets back
252 253
    //  Sends Terminate command to server when download is complete to close Open command
    //      Mock file server will signal terminateCommandReceived when it gets a Terminate command
254
    //  Sends downloadFileComplete signal to indicate the download is complete
255 256 257 258
    //  Emits an errorMessage signal if sequence number is incorrrect on any response
    //  Emits an errorMessage signal if CRC is incorrect on any responses
    
    // Expected signals if the Open command fails for any reason
259
    quint16 signalMaskOpenFailure = errorMessageSignalMask;
260 261

    // Expected signals if the Read command fails for any reason
262
    quint16 signalMaskReadFailure = downloadFileLengthSignalMask | errorMessageSignalMask;
263 264
    
    // Expected signals if the downloadPath command succeeds
265
    quint16 signalMaskDownloadSuccess = downloadFileLengthSignalMask | downloadFileCompleteSignalMask;
266

267 268 269 270
    // Send a bogus path
    //  We should get a single resetStatusMessages signal
    //  We should get a single errorMessage signal
    _fileManager->downloadPath("bogus", QDir::temp());
271
    QCOMPARE(_multiSpy->checkOnlySignalByMask(signalMaskOpenFailure), true);
272 273 274
    _multiSpy->clearAllSignals();
    
    // Clean previous downloads
275 276 277 278 279
    for (size_t i=0; i<MockMavlinkFileServer::cFileTestCases; i++) {
        QString filePath = QDir::temp().absoluteFilePath(MockMavlinkFileServer::rgFileTestCases[i].filename);
        if (QFile::exists(filePath)) {
            Q_ASSERT(QFile::remove(filePath));
        }
280
    }
281
    
282 283
    // We setup a spy on the Terminate command signal of the mock file server so that we can determine that a
    // Terminate command was correctly sent after the Open/Read commands complete.
284 285
    QSignalSpy terminateSpy(&_mockFileServer, SIGNAL(terminateCommandReceived()));
    
286
    // Run through the set of file test cases
287
    for (size_t i=0; i<MockMavlinkFileServer::cFileTestCases; i++) {
288
        const MockMavlinkFileServer::FileTestCase* testCase = &MockMavlinkFileServer::rgFileTestCases[i];
289 290 291
        
        // Run through the various failure modes for this test case
        for (size_t j=0; j<MockMavlinkFileServer::cFailureModes; j++) {
292
            
293 294 295 296
            MockMavlinkFileServer::ErrorMode_t errMode = MockMavlinkFileServer::rgFailureModes[j];
            qDebug() << "Testing failure mode:" << errMode;
            _mockFileServer.setErrorMode(errMode);
            
297
            _fileManager->downloadPath(testCase->filename, QDir::temp());
298 299 300 301 302
            QTest::qWait(_ackTimerTimeoutMsecs); // Let the file manager timeout
            
            if (errMode == MockMavlinkFileServer::errModeNoSecondResponse || errMode == MockMavlinkFileServer::errModeNakSecondResponse) {
                // For simulated server errors on subsequent Acks, the first Ack will go through. We must handle things differently depending
                // on whether the downloaded file requires multiple packets to complete the download.
303
                if (testCase->fMultiPacketResponse) {
304 305
                    // The downloaded file requires multiple Acks to complete. Hence first Read should have succeeded and sent one downloadFileComplete.
                    // Second Read should have failed.
306
                    QCOMPARE(_multiSpy->checkOnlySignalByMask(signalMaskReadFailure), true);
307 308 309 310 311 312

                    // Open command succeeded, so we should get a Terminate for the open
                    QCOMPARE(terminateSpy.count(), 1);
                } else {
                    // The downloaded file fits within a single Ack response, hence there is no second Read issued.
                    // This should result in a successful download.
313
                    QCOMPARE(_multiSpy->checkOnlySignalByMask(signalMaskDownloadSuccess), true);
314 315 316 317 318
                    
                    // We should get a single Terminate command to close the Open session
                    QCOMPARE(terminateSpy.count(), 1);
                    
                    // Validate file contents
319 320
                    QString filePath = QDir::temp().absoluteFilePath(testCase->filename);
                    _validateFileContents(filePath, testCase->length);
321 322 323 324
                }
            } else {
                // For all the other simulated server errors the Open command should have failed. Since the Open failed
                // there is no session to terminate, hence no Terminate in this case.
325
                QCOMPARE(_multiSpy->checkOnlySignalByMask(signalMaskOpenFailure), true);
326 327 328 329 330 331 332 333 334 335
                QCOMPARE(terminateSpy.count(), 0);
            }

            // Cleanup for next iteration
            _multiSpy->clearAllSignals();
            terminateSpy.clear();
            _mockFileServer.setErrorMode(MockMavlinkFileServer::errModeNone);
        }

        // Run what should be a successful file download test case. No servers errors are being simulated.
336 337 338 339 340 341
        _fileManager->downloadPath(testCase->filename, QDir::temp());

        // This should be a succesful download
        QCOMPARE(_multiSpy->checkOnlySignalByMask(signalMaskDownloadSuccess), true);
        
        // Make sure the file length coming back through the openFileLength signal is correct
342
        QVERIFY(_multiSpy->getSpyByIndex(downloadFileLengthSignalIndex)->takeFirst().at(0).toInt() == testCase->length);
343 344 345

        _multiSpy->clearAllSignals();
        
346
        // We should get a single Terminate command to close the session
347 348 349
        QCOMPARE(terminateSpy.count(), 1);
        terminateSpy.clear();
        
350
        // Validate file contents
351 352 353
        QString filePath = QDir::temp().absoluteFilePath(MockMavlinkFileServer::rgFileTestCases[i].filename);
        _validateFileContents(filePath, MockMavlinkFileServer::rgFileTestCases[i].length);
    }
354
}