PX4RCCalibrationTest.cc 33.6 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
/*=====================================================================
 
 QGroundControl Open Source Ground Control Station
 
 (c) 2009 - 2014 QGROUNDCONTROL PROJECT <http://www.qgroundcontrol.org>
 
 This file is part of the QGROUNDCONTROL project
 
 QGROUNDCONTROL is free software: you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
 the Free Software Foundation, either version 3 of the License, or
 (at your option) any later version.
 
 QGROUNDCONTROL is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU General Public License for more details.
 
 You should have received a copy of the GNU General Public License
 along with QGROUNDCONTROL. If not, see <http://www.gnu.org/licenses/>.
 
 ======================================================================*/

#include "PX4RCCalibrationTest.h"
#include "UASManager.h"
#include "MockQGCUASParamManager.h"

/// @file
Don Gagne's avatar
Don Gagne committed
29
///     @brief QPX4RCCalibration Widget unit test
30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52
///
///     @author Don Gagne <don@thegagnes.com>

// This will check for the wizard buttons being enabled of disabled according to the mask you pass in.
// We use a macro instead of a method so that we get better line number reporting on failure.
#define CHK_BUTTONS(mask) \
{ \
    if (_nextButton->isEnabled() != !!((mask) & nextButtonMask) || \
        _skipButton->isEnabled() != !!((mask) & skipButtonMask) || \
        _cancelButton->isEnabled() != !!((mask) & cancelButtonMask) || \
        _tryAgainButton->isEnabled() != !!((mask) & tryAgainButtonMask)) { \
        qDebug() << _statusLabel->text(); \
    } \
    QCOMPARE(_nextButton->isEnabled(), !!((mask) & nextButtonMask)); \
    QCOMPARE(_skipButton->isEnabled(), !!((mask) & skipButtonMask)); \
    QCOMPARE(_cancelButton->isEnabled(), !!((mask) & cancelButtonMask)); \
    QCOMPARE(_tryAgainButton->isEnabled(), !!((mask) & tryAgainButtonMask)); \
}

// This allows you to write unit tests which will click the Cancel button the first time through, followed
// by the Next button on the second iteration.
#define NEXT_OR_CANCEL(cancelNum) \
{ \
Don Gagne's avatar
Don Gagne committed
53
    if (mode == testModeStandalone && tryCancel ## cancelNum) { \
54 55 56 57 58 59 60 61 62
        QTest::mouseClick(_cancelButton, Qt::LeftButton); \
        QCOMPARE(_calWidget->_rcCalState, PX4RCCalibration::rcCalStateChannelWait); \
        tryCancel ## cancelNum = false; \
        goto StartOver; \
    } else { \
        QTest::mouseClick(_nextButton, Qt::LeftButton); \
    } \
}

Don Gagne's avatar
Don Gagne committed
63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121
const int PX4RCCalibrationTest::_testMinValue = PX4RCCalibration::_rcCalPWMDefaultMinValue + 10;
const int PX4RCCalibrationTest::_testMaxValue = PX4RCCalibration::_rcCalPWMDefaultMaxValue - 10;
const int PX4RCCalibrationTest::_testTrimValue = PX4RCCalibration::_rcCalPWMDefaultTrimValue + 10;
const int PX4RCCalibrationTest::_testThrottleTrimValue = PX4RCCalibration::_rcCalPWMDefaultMinValue + 10;

const struct PX4RCCalibrationTest::ChannelSettings PX4RCCalibrationTest::_rgChannelSettingsPreValidate[PX4RCCalibrationTest::_availableChannels] = {
    //Min Value                                 Max Value                                   Trim Value                                      Reversed    MinMaxShown MinValid MaxValid
    // Channel 0 : rcCalFunctionRoll
    { PX4RCCalibrationTest::_testMinValue,      PX4RCCalibrationTest::_testMaxValue,        PX4RCCalibrationTest::_testTrimValue,           false,      true,   true,   true },
    // Channel 1 : rcCalFunctionPitch
    { PX4RCCalibrationTest::_testMinValue,      PX4RCCalibrationTest::_testMaxValue,        PX4RCCalibrationTest::_testTrimValue,           false,      true,   true,   true },
    // Channel 2 : rcCalFunctionYaw
    { PX4RCCalibrationTest::_testMinValue,      PX4RCCalibrationTest::_testMaxValue,        PX4RCCalibrationTest::_testTrimValue,           false,      true,   true,   true },
    // Channel 3 : rcCalFunctionThrottle
    { PX4RCCalibrationTest::_testMinValue,      PX4RCCalibrationTest::_testMaxValue,        PX4RCCalibrationTest::_testThrottleTrimValue,   false,      true,   true,   true },
    // Channel 4 : rcCalFunctionModeSwitch
    { PX4RCCalibrationTest::_testMinValue,      PX4RCCalibrationTest::_testMaxValue,        PX4RCCalibration::_rcCalPWMCenterPoint,         false,      true,   true,   true },
    
    // Channel 5 : Simulate invalid Min, valid Max
    { PX4RCCalibration::_rcCalPWMCenterPoint,   PX4RCCalibration::_rcCalPWMDefaultMaxValue, PX4RCCalibration::_rcCalPWMCenterPoint,         false,      true,   false,  true },
    
    // Channels 6-7: Invalid Min/Max, since available channel Min/Max is still shown
    { PX4RCCalibration::_rcCalPWMCenterPoint,   PX4RCCalibration::_rcCalPWMCenterPoint,     PX4RCCalibration::_rcCalPWMCenterPoint,         false,      true,   false,  false },
    { PX4RCCalibration::_rcCalPWMCenterPoint,   PX4RCCalibration::_rcCalPWMCenterPoint,     PX4RCCalibration::_rcCalPWMCenterPoint,         false,      true,   false,  false },
};

const struct PX4RCCalibrationTest::ChannelSettings PX4RCCalibrationTest::_rgChannelSettingsPostValidate[PX4RCCalibration::_chanMax] = {
    //                                Min Value                                     Max Value                                   Trim Value                                  Reversed    MinMaxShown MinValid MaxValid
    // Channel 0 : rcCalFunctionRoll
    { PX4RCCalibrationTest::_testMinValue,      PX4RCCalibrationTest::_testMaxValue,        PX4RCCalibrationTest::_testTrimValue,           false,      true,   true,   true },
    // Channel 1 : rcCalFunctionPitch
    { PX4RCCalibrationTest::_testMinValue,      PX4RCCalibrationTest::_testMaxValue,        PX4RCCalibrationTest::_testTrimValue,           false,      true,   true,   true },
    // Channel 2 : rcCalFunctionYaw
    { PX4RCCalibrationTest::_testMinValue,      PX4RCCalibrationTest::_testMaxValue,        PX4RCCalibrationTest::_testTrimValue,           false,      true,   true,   true },
    // Channel 3 : rcCalFunctionThrottle
    { PX4RCCalibrationTest::_testMinValue,      PX4RCCalibrationTest::_testMaxValue,        PX4RCCalibrationTest::_testThrottleTrimValue,   false,      true,   true,   true },
    // Channel 4 : rcCalFunctionModeSwitch
    { PX4RCCalibrationTest::_testMinValue,      PX4RCCalibrationTest::_testMaxValue,        PX4RCCalibration::_rcCalPWMCenterPoint,         false,      true,   true,   true },
    
    // Channel 5 : Simulate invalid Min, valid Max, validation should switch back to defaults
    { PX4RCCalibration::_rcCalPWMDefaultMinValue,   PX4RCCalibration::_rcCalPWMDefaultMaxValue, PX4RCCalibration::_rcCalPWMDefaultTrimValue,         false,      true,   true,  true },
    
    // Channels 6-7: Invalid Min/Max, since available channel Min/Max is still shown, validation will set to defaults
    { PX4RCCalibration::_rcCalPWMDefaultMinValue,   PX4RCCalibration::_rcCalPWMDefaultMaxValue,     PX4RCCalibration::_rcCalPWMDefaultTrimValue,         false,      true,   true,  true },
    { PX4RCCalibration::_rcCalPWMDefaultMinValue,   PX4RCCalibration::_rcCalPWMDefaultMaxValue,     PX4RCCalibration::_rcCalPWMDefaultTrimValue,         false,      true,   true,  true },
    
    // We are simulating an 8-channel radio, all other channel should be defaulted
    { PX4RCCalibration::_rcCalPWMDefaultMinValue,       PX4RCCalibration::_rcCalPWMDefaultMaxValue,     PX4RCCalibration::_rcCalPWMDefaultTrimValue,         false,      false,   false, false },
    { PX4RCCalibration::_rcCalPWMDefaultMinValue,       PX4RCCalibration::_rcCalPWMDefaultMaxValue,     PX4RCCalibration::_rcCalPWMDefaultTrimValue,         false,      false,   false, false },
    { PX4RCCalibration::_rcCalPWMDefaultMinValue,       PX4RCCalibration::_rcCalPWMDefaultMaxValue,     PX4RCCalibration::_rcCalPWMDefaultTrimValue,         false,      false,   false, false },
    { PX4RCCalibration::_rcCalPWMDefaultMinValue,       PX4RCCalibration::_rcCalPWMDefaultMaxValue,     PX4RCCalibration::_rcCalPWMDefaultTrimValue,         false,      false,   false, false },
    { PX4RCCalibration::_rcCalPWMDefaultMinValue,       PX4RCCalibration::_rcCalPWMDefaultMaxValue,     PX4RCCalibration::_rcCalPWMDefaultTrimValue,         false,      false,   false, false },
    { PX4RCCalibration::_rcCalPWMDefaultMinValue,       PX4RCCalibration::_rcCalPWMDefaultMaxValue,     PX4RCCalibration::_rcCalPWMDefaultTrimValue,         false,      false,   false, false },
    { PX4RCCalibration::_rcCalPWMDefaultMinValue,       PX4RCCalibration::_rcCalPWMDefaultMaxValue,     PX4RCCalibration::_rcCalPWMDefaultTrimValue,         false,      false,   false, false },
    { PX4RCCalibration::_rcCalPWMDefaultMinValue,       PX4RCCalibration::_rcCalPWMDefaultMaxValue,     PX4RCCalibration::_rcCalPWMDefaultTrimValue,         false,      false,   false, false },
    { PX4RCCalibration::_rcCalPWMDefaultMinValue,       PX4RCCalibration::_rcCalPWMDefaultMaxValue,     PX4RCCalibration::_rcCalPWMDefaultTrimValue,         false,      false,   false, false },
    { PX4RCCalibration::_rcCalPWMDefaultMinValue,       PX4RCCalibration::_rcCalPWMDefaultMaxValue,     PX4RCCalibration::_rcCalPWMDefaultTrimValue,         false,      false,   false, false },
};

122 123 124 125
PX4RCCalibrationTest::PX4RCCalibrationTest(void) :
    _mockUASManager(NULL),
    _calWidget(NULL)
{
Don Gagne's avatar
Don Gagne committed
126 127 128 129 130 131 132 133 134 135 136 137 138 139

}

/// @brief Called one time before any test cases are run.
void PX4RCCalibrationTest::initTestCase(void)
{
    // The test case code makes the following assumptions about PX4RCCalibration class internals.
    // Make sure these don't change out from under us.
    
    Q_ASSERT(PX4RCCalibration::rcCalFunctionRoll == 0);
    Q_ASSERT(PX4RCCalibration::rcCalFunctionPitch == 1);
    Q_ASSERT(PX4RCCalibration::rcCalFunctionYaw == 2);
    Q_ASSERT(PX4RCCalibration::rcCalFunctionThrottle == 3);
    Q_ASSERT(PX4RCCalibration::rcCalFunctionModeSwitch == 4);
140
    
Don Gagne's avatar
Don Gagne committed
141 142 143 144 145 146 147 148 149 150
    // We only set min/max for required channels. Make sure the set of required channels doesn't change out from under us.
    for (int chanFunction=0; chanFunction<PX4RCCalibration::rcCalFunctionMax; chanFunction++) {
        if (PX4RCCalibration::_rgFunctionInfo[chanFunction].required) {
            Q_ASSERT(chanFunction == PX4RCCalibration::rcCalFunctionRoll ||
                     chanFunction == PX4RCCalibration::rcCalFunctionPitch ||
                     chanFunction == PX4RCCalibration::rcCalFunctionYaw ||
                     chanFunction == PX4RCCalibration::rcCalFunctionThrottle ||
                     chanFunction == PX4RCCalibration::rcCalFunctionModeSwitch);
        }
    }
151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186
}

void PX4RCCalibrationTest::init(void)
{
    _mockUASManager = new MockUASManager();
    Q_ASSERT(_mockUASManager);
    
    UASManager::setMockUASManager(_mockUASManager);
    
    _mockUAS = new MockUAS();
    Q_CHECK_PTR(_mockUAS);
    
    // This will instatiate the widget with no active UAS set
    _calWidget = new PX4RCCalibration();
    Q_CHECK_PTR(_calWidget);
    
    _mockUASManager->setMockActiveUAS(_mockUAS);

    // Get pointers to the push buttons
    _cancelButton = _calWidget->findChild<QPushButton*>("rcCalCancel");
    _nextButton = _calWidget->findChild<QPushButton*>("rcCalNext");
    _skipButton = _calWidget->findChild<QPushButton*>("rcCalSkip");
    _tryAgainButton = _calWidget->findChild<QPushButton*>("rcCalTryAgain");
    
    Q_ASSERT(_cancelButton);
    Q_ASSERT(_nextButton);
    Q_ASSERT(_skipButton);
    Q_ASSERT(_tryAgainButton);
    
    _statusLabel = _calWidget->findChild<QLabel*>("rcCalStatus");
    Q_ASSERT(_statusLabel);
 
    for (size_t i=0; i<PX4RCCalibration::_chanMax; i++) {
        QString radioWidgetName("radio%1Widget");
        QString radioWidgetUserName("Radio %1");
        
Don Gagne's avatar
Don Gagne committed
187
        RCChannelWidget* radioWidget = _calWidget->findChild<RCChannelWidget*>(radioWidgetName.arg(i+1));
188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224
        Q_ASSERT(radioWidget);
        
        _rgRadioWidget[i] = radioWidget;
    }
}

void PX4RCCalibrationTest::cleanup(void)
{
    Q_ASSERT(_mockUAS);
    delete _mockUAS;
    
    UASManager::setMockUASManager(NULL);

    Q_ASSERT(_mockUASManager);
    delete _mockUASManager;
    
    Q_ASSERT(_calWidget);
    delete _calWidget;
}

/// @brief Tests for correct behavior when active UAS is set into widget.
void PX4RCCalibrationTest::_setUAS_test(void)
{
    // Widget is initialized with UAS, so it should be enabled
    QCOMPARE(_calWidget->isEnabled(), true);

    // Take away the UAS and widget should disable
    _mockUASManager->setMockActiveUAS(NULL);
    QCOMPARE(_calWidget->isEnabled(), false);
}

/// @brief Test for correct behavior in determining minimum numbers of channels for fligth.
void PX4RCCalibrationTest::_minRCChannels_test(void)
{
    // Next button won't be enabled until we see the minimum number of channels.
    for (int i=0; i<PX4RCCalibration::_chanMinimum; i++) {
        _mockUAS->emitRemoteControlChannelRawChanged(i, (float)PX4RCCalibration::_rcCalPWMCenterPoint);
Don Gagne's avatar
Don Gagne committed
225 226 227 228 229
        
        // We use _chanCount internally so we should validate it
        QCOMPARE(_calWidget->_chanCount, i+1);
        
        // Validate Next button state
230 231 232 233 234 235 236
        if (i == PX4RCCalibration::_chanMinimum - 1) {
            // Last channel should trigger enable
            CHK_BUTTONS(nextButtonMask);
        } else {
            // Still less than the minimum channels
            CHK_BUTTONS(0);
        }
Don Gagne's avatar
Don Gagne committed
237 238 239 240 241 242

        // Only available channels should have enabled widget. A ui update cycle needs to have passed so we wait a little.
        QTest::qWait(PX4RCCalibration::_updateInterval * 2);
        for (int chanWidget=0; chanWidget<PX4RCCalibration::_chanMax; chanWidget++) {
            QCOMPARE(_rgRadioWidget[chanWidget]->isEnabled(), !!(chanWidget <= i));
        }
243 244 245 246 247 248 249 250 251 252 253 254
    }
}

#if 0
/// @brief Tests that even when not calibrating the channel display is live
void PX4RCCalibrationTest::_liveRC_test(void)
{
    for (int i=0; i<PX4RCCalibration::_chanMax; i++) {
        _mockUAS->emitRemoteControlChannelRawChanged(i, (float)PX4RCCalibration::_rcCalPWMValidMaxValue);        
    }
    
    for (int i=0; i<PX4RCCalibration::_chanMax; i++) {
Don Gagne's avatar
Don Gagne committed
255
        RCChannelWidget* radioWidget = _rgRadioWidget[i];
256 257 258 259 260 261 262 263
        Q_ASSERT(radioWidget);
        
        QCOMPARE(radioWidget->value(), PX4RCCalibration::_rcCalPWMValidMinValue);
        QCOMPARE(radioWidget->max(), PX4RCCalibration::_rcCalPWMValidMaxValue);
    }
}
#endif

Don Gagne's avatar
Don Gagne committed
264
void PX4RCCalibrationTest::_beginState_worker(enum TestMode mode)
265 266 267 268
{
    bool tryCancel1 = true;
    
StartOver:
Don Gagne's avatar
Don Gagne committed
269 270
    if (mode == testModeStandalone || mode == testModePrerequisite) {
        _centerChannels();
271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288

        _calWidget->_unitTestForceCalState(PX4RCCalibration::rcCalStateBegin);
    }

    // Next button is always enabled in this state
    CHK_BUTTONS(nextButtonMask | cancelButtonMask);

    // Click the next button:
    // We should now be waiting for movement on a channel to identify the first RC function. The Next button will stay
    // disabled until the sticks are moved enough to identify the channel. For required functions the Skip button is
    // disabled.
    NEXT_OR_CANCEL(1);
    QCOMPARE(_calWidget->_rcCalState, PX4RCCalibration::rcCalStateIdentify);
    CHK_BUTTONS(cancelButtonMask);
}

void PX4RCCalibrationTest::_beginState_test(void)
{
Don Gagne's avatar
Don Gagne committed
289
    _beginState_worker(testModeStandalone);
290 291
}

Don Gagne's avatar
Don Gagne committed
292
void PX4RCCalibrationTest::_identifyState_worker(enum TestMode mode)
293
{
Don Gagne's avatar
Don Gagne committed
294
    bool tryCancel1 = true;
295 296
    
StartOver:
Don Gagne's avatar
Don Gagne committed
297 298 299
    if (mode == testModeStandalone || mode == testModePrerequisite)
    {
        _centerChannels();
300 301 302 303 304
        
        _calWidget->_unitTestForceCalState(PX4RCCalibration::rcCalStateIdentify);
        
    }
    
Don Gagne's avatar
Don Gagne committed
305
    // Loop over all function idenitfying required channels
306 307
    for (int i=0; i<PX4RCCalibration::rcCalFunctionMax; i++) {
        // If this function is required you can't skip it
Don Gagne's avatar
Don Gagne committed
308 309
        bool skipNonRequired = !PX4RCCalibration::_rgFunctionInfo[i].required;
        int skipMask = skipNonRequired ? skipButtonMask : 0;
310 311 312 313 314 315
        
        // We should now be waiting for movement on a channel to identify the RC function. The Next button will stay
        // disabled until the sticks are moved enough to identify the channel. For required functions the Skip button is
        // disabled.
        CHK_BUTTONS(cancelButtonMask | skipMask);

Don Gagne's avatar
Don Gagne committed
316 317 318 319 320 321 322 323
        // Skip this mapping if allowed
        if (skipNonRequired) {
            QTest::mouseClick(_skipButton, Qt::LeftButton);
            continue;
        }
        
        // Move channel less than delta to make sure function is not identified
        _mockUAS->emitRemoteControlChannelRawChanged(i, (float)PX4RCCalibration::_rcCalPWMCenterPoint + (PX4RCCalibration::_rcCalMoveDelta - 2.0f));
324 325 326 327 328 329 330 331 332 333 334 335 336 337
        CHK_BUTTONS(cancelButtonMask | skipMask);

        if (i != 0) {
            // Try to assign a channel 0 to more than one function. This is not allowed so Next button should not enable.
            _mockUAS->emitRemoteControlChannelRawChanged(0, (float)PX4RCCalibration::_rcCalPWMValidMinValue);
            _mockUAS->emitRemoteControlChannelRawChanged(0, (float)PX4RCCalibration::_rcCalPWMValidMaxValue);
            CHK_BUTTONS(cancelButtonMask | skipMask);
        }

        if (tryCancel1) {
            NEXT_OR_CANCEL(1);
        }
        
        // Move channel larger than delta to identify channel. We should now be sitting in a found state.
Don Gagne's avatar
Don Gagne committed
338
        _mockUAS->emitRemoteControlChannelRawChanged(i, (float)PX4RCCalibration::_rcCalPWMCenterPoint + (PX4RCCalibration::_rcCalMoveDelta + 2.0f));
339 340 341 342 343 344 345 346 347
        CHK_BUTTONS(cancelButtonMask | tryAgainButtonMask | nextButtonMask);

        NEXT_OR_CANCEL(1);
    }
    
    // We should now be waiting for min/max values.
    QCOMPARE(_calWidget->_rcCalState, PX4RCCalibration::rcCalStateMinMax);
    CHK_BUTTONS(nextButtonMask | cancelButtonMask);
    
Don Gagne's avatar
Don Gagne committed
348
    if (mode == testModeStandalone) {
349
        _calWidget->_writeCalibration(false /* !trimsOnly */);
Don Gagne's avatar
Don Gagne committed
350
        _validateParameters(validateMappingMask);
351 352 353 354 355
    }
}

void PX4RCCalibrationTest::_identifyState_test(void)
{
Don Gagne's avatar
Don Gagne committed
356
    _identifyState_worker(testModeStandalone);
357 358
}

Don Gagne's avatar
Don Gagne committed
359
void PX4RCCalibrationTest::_minMaxState_worker(enum TestMode mode)
360 361 362 363
{
    bool tryCancel1 = true;
    
StartOver:
Don Gagne's avatar
Don Gagne committed
364
    if (mode == testModeStandalone || mode == testModePrerequisite) {
365
        // The Min/Max calibration updates the radio channel ui widgets with the min/max values as you move the sticks.
Don Gagne's avatar
Don Gagne committed
366
        // In order for the roll/pitch/yaw/throttle radio channel ui widgets to be updated correctly those functions
367 368
        // must be alread mapped to a channel. So we have to run the _identifyState_test first to set up the internal
        // state correctly.
Don Gagne's avatar
Don Gagne committed
369
        _identifyState_worker(testModePrerequisite);
370

Don Gagne's avatar
Don Gagne committed
371
        _centerChannels();
372 373 374 375 376 377
        
        _calWidget->_unitTestForceCalState(PX4RCCalibration::rcCalStateMinMax);
        
        // We should now be waiting for min/max values.
        CHK_BUTTONS(nextButtonMask | cancelButtonMask);
    }
Don Gagne's avatar
Don Gagne committed
378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395
    
    // Before we start sending rc values the widgets should all have min/max as invalid
    for (int chan=0; chan<PX4RCCalibration::_chanMax; chan++) {
        QCOMPARE(_rgRadioWidget[chan]->isMinValid(), false);
        QCOMPARE(_rgRadioWidget[chan]->isMaxValid(), false);
    }
    
    // Try setting a min/max value that is below the threshold to make sure min/max doesn't go valid
    _mockUAS->emitRemoteControlChannelRawChanged(0, (float)(PX4RCCalibration::_rcCalPWMValidMinValue + 1));
    _mockUAS->emitRemoteControlChannelRawChanged(0, (float)(PX4RCCalibration::_rcCalPWMValidMaxValue - 1));
    QCOMPARE(_rgRadioWidget[0]->isMinValid(), false);
    QCOMPARE(_rgRadioWidget[0]->isMaxValid(), false);

    // Send min/max values
    for (int chan=0; chan<_minMaxChannels; chan++) {
        // Send Min/Max
        _mockUAS->emitRemoteControlChannelRawChanged(chan, (float)_rgChannelSettingsPreValidate[chan].rcMin);
        _mockUAS->emitRemoteControlChannelRawChanged(chan, (float)_rgChannelSettingsPreValidate[chan].rcMax);
396 397
    }

Don Gagne's avatar
Don Gagne committed
398 399
    _validateWidgets(validateMinMaxMask, _rgChannelSettingsPreValidate);
    
400 401 402 403 404 405 406 407 408
    // Make sure throttle is at min
    _mockUAS->emitRemoteControlChannelRawChanged(PX4RCCalibration::rcCalFunctionThrottle, (float)PX4RCCalibration::_rcCalPWMValidMinValue);

    // Click the next button: We should now be waiting for center throttle in prep for inversion detection.
    // Throttle channel is at minimum so Next button should be disabled.
    NEXT_OR_CANCEL(1);
    QCOMPARE(_calWidget->_rcCalState, PX4RCCalibration::rcCalStateCenterThrottle);
    CHK_BUTTONS(cancelButtonMask);

Don Gagne's avatar
Don Gagne committed
409
    if (mode == testModeStandalone) {
410 411 412 413 414 415 416
        _calWidget->_writeCalibration(false /* !trimsOnly */);
        _validateParameters(validateMinMaxMask);
    }
}

void PX4RCCalibrationTest::_minMaxState_test(void)
{
Don Gagne's avatar
Don Gagne committed
417
    _minMaxState_worker(testModeStandalone);
418 419
}

Don Gagne's avatar
Don Gagne committed
420
void PX4RCCalibrationTest::_centerThrottleState_worker(enum TestMode mode)
421 422 423 424
{
    bool tryCancel1 = true;
    
StartOver:
Don Gagne's avatar
Don Gagne committed
425
    if (mode == testModeStandalone || mode == testModePrerequisite) {
426 427
        // In order to perform the center throttle state test the throttle channel has to have been identified.
        // So we have to run the _identifyState_test first to set up the internal state correctly.
Don Gagne's avatar
Don Gagne committed
428
        _identifyState_worker(testModePrerequisite);
429
        
Don Gagne's avatar
Don Gagne committed
430
        _centerChannels();
431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456
        _mockUAS->emitRemoteControlChannelRawChanged(PX4RCCalibration::rcCalFunctionThrottle, (float)PX4RCCalibration::_rcCalPWMValidMinValue);
        
        _calWidget->_unitTestForceCalState(PX4RCCalibration::rcCalStateCenterThrottle);
        
        // We should now be waiting for center throttle in prep for inversion detection.
        // Throttle channel is at minimum so Next button should be disabled.
        CHK_BUTTONS(cancelButtonMask);
    }

    // Move the throttle to just below rough center. Next should still be disabled
    _mockUAS->emitRemoteControlChannelRawChanged(PX4RCCalibration::rcCalFunctionThrottle, PX4RCCalibration::_rcCalPWMCenterPoint - PX4RCCalibration::_rcCalRoughCenterDelta - 1);
    CHK_BUTTONS(cancelButtonMask);
    
    // Center the throttle and make sure Next button gets enabled
    _mockUAS->emitRemoteControlChannelRawChanged(PX4RCCalibration::rcCalFunctionThrottle, PX4RCCalibration::_rcCalPWMCenterPoint);
    CHK_BUTTONS(cancelButtonMask | nextButtonMask);
    
    // Click the next button which should take us to our first channel inversion test. The Next button will stay disabled until
    // the stick for the specified channel is moved down.
    NEXT_OR_CANCEL(1);
    QCOMPARE(_calWidget->_rcCalState, PX4RCCalibration::rcCalStateDetectInversion);
    CHK_BUTTONS(cancelButtonMask);
}

void PX4RCCalibrationTest::_centerThrottleState_test(void)
{
Don Gagne's avatar
Don Gagne committed
457
    _centerThrottleState_worker(testModeStandalone);
458 459
}

Don Gagne's avatar
Don Gagne committed
460
void PX4RCCalibrationTest::_detectInversionState_worker(enum TestMode mode)
461 462 463 464 465
{
    bool tryCancel1 = true;
    bool tryCancel2 = true;
    
StartOver:
Don Gagne's avatar
Don Gagne committed
466
    if (mode == testModeStandalone || mode == testModePrerequisite) {
467 468
        // In order to perform the detect inversion test the roll/pitch/yaw/throttle functions must be mapped to a channel.
        // So we have to run the _identifyState_test first to set up the internal state correctly.
Don Gagne's avatar
Don Gagne committed
469
        _identifyState_worker(testModePrerequisite);
470
        
Don Gagne's avatar
Don Gagne committed
471
        _centerChannels();
472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488
        
        _calWidget->_unitTestForceCalState(PX4RCCalibration::rcCalStateDetectInversion);
        
        // We should now be at the first channel inversion test. The Next button will stay disabled until the stick for the specified
        // channel is moved in the appropriate direction.
        CHK_BUTTONS(cancelButtonMask);
    }

    // Loop over Attitude Control Functions (roll/yaw/pitch/throttle) to detect inversion
    for (int chanFunction=PX4RCCalibration::rcCalFunctionFirstAttitudeFunction; chanFunction<=PX4RCCalibration::rcCalFunctionLastAttitudeFunction; chanFunction++) {
        if (chanFunction != 0) {
            // Click next to move to next inversion to identify
            NEXT_OR_CANCEL(1);
            CHK_BUTTONS(cancelButtonMask);
        }
        
        // Move all channels except for the one we are trying to detect to min and max value to make sure there is no effect.
Don Gagne's avatar
Don Gagne committed
489
        for (int chan=0; chan<_availableChannels; chan++) {
490
            if (chanFunction != chan) {
Don Gagne's avatar
Don Gagne committed
491 492
                _mockUAS->emitRemoteControlChannelRawChanged(chan, (float)PX4RCCalibration::_rcCalPWMCenterPoint + (PX4RCCalibration::_rcCalMoveDelta + 2.0f));
                _mockUAS->emitRemoteControlChannelRawChanged(chan, (float)PX4RCCalibration::_rcCalPWMCenterPoint - (PX4RCCalibration::_rcCalMoveDelta + 2.0f));
493
                CHK_BUTTONS(cancelButtonMask);
Don Gagne's avatar
Don Gagne committed
494 495 496

                // Make sure to re-center for next inversion detect
                _mockUAS->emitRemoteControlChannelRawChanged(chan, (float)PX4RCCalibration::_rcCalPWMCenterPoint);
497 498 499 500 501
            }
        }
        
        // Move the channel we are detecting inversion on to the min value which should indicate no inversion.
        // This should put us in the found state and enable the Next button.
Don Gagne's avatar
Don Gagne committed
502
        _mockUAS->emitRemoteControlChannelRawChanged(chanFunction, (float)PX4RCCalibration::_rcCalPWMCenterPoint - (PX4RCCalibration::_rcCalMoveDelta + 2.0f));
503 504 505 506 507
        CHK_BUTTONS(cancelButtonMask | tryAgainButtonMask | nextButtonMask);
    }
    
    // Click the next button: We should now be waiting for low throttle in prep for trim detection.
    // Throttle channel is at minimum so Next button should be disabled.
Don Gagne's avatar
Don Gagne committed
508
    _centerChannels();
509 510 511 512
    NEXT_OR_CANCEL(2);
    QCOMPARE(_calWidget->_rcCalState, PX4RCCalibration::rcCalStateTrims);
    CHK_BUTTONS(cancelButtonMask);
    
Don Gagne's avatar
Don Gagne committed
513
    if (mode == testModeStandalone) {
514 515 516 517 518 519 520
        _calWidget->_writeCalibration(false /* !trimsOnly */);
        _validateParameters(validateMappingMask | validateReversedMask);
    }
}

void PX4RCCalibrationTest::_detectInversionState_test(void)
{
Don Gagne's avatar
Don Gagne committed
521
    _detectInversionState_worker(testModeStandalone);
522 523
}

Don Gagne's avatar
Don Gagne committed
524
void PX4RCCalibrationTest::_trimsState_worker(enum TestMode mode)
525 526 527 528
{
    bool tryCancel1 = true;
    
StartOver:
Don Gagne's avatar
Don Gagne committed
529
    if (mode == testModeStandalone || mode == testModePrerequisite) {
530
        // In order to perform the trim state test the functions must be mapped and the min/max values must be set.
Don Gagne's avatar
Don Gagne committed
531 532
        // So we have to run the _minMaxState_test first to set up the internal state correctly.
        _minMaxState_worker(testModePrerequisite);
533
        
Don Gagne's avatar
Don Gagne committed
534
        _centerChannels();
535 536 537 538 539 540 541
        
        _calWidget->_unitTestForceCalState(PX4RCCalibration::rcCalStateTrims);
        
        // We should now be waiting for low throttle.
        CHK_BUTTONS(cancelButtonMask);
    }

Don Gagne's avatar
Don Gagne committed
542 543 544 545 546 547 548 549
    // Send trim values to attitude control function channels
    for (int chan=0; chan<_attitudeChannels; chan++) {
        _mockUAS->emitRemoteControlChannelRawChanged(chan, _rgChannelSettingsPreValidate[chan].rcTrim);
    }
    
    _validateWidgets(validateTrimsMask, _rgChannelSettingsPreValidate);
    
    // Throttle trim was set, so next should be enabled
550 551 552 553 554 555
    CHK_BUTTONS(cancelButtonMask | nextButtonMask);
    
    // Click the next button which should set Trims and take us the Save step.
    NEXT_OR_CANCEL(1);
    QCOMPARE(_calWidget->_rcCalState, PX4RCCalibration::rcCalStateSave);
    CHK_BUTTONS(cancelButtonMask | nextButtonMask);
Don Gagne's avatar
Don Gagne committed
556
    _validateWidgets(validateTrimsMask, _rgChannelSettingsPostValidate);
557

Don Gagne's avatar
Don Gagne committed
558
    if (mode == testModeStandalone) {
559 560 561 562 563 564 565
        _calWidget->_writeCalibration(false /* !trimsOnly */);
        _validateParameters(validateTrimsMask);
    }
}

void PX4RCCalibrationTest::_trimsState_test(void)
{
Don Gagne's avatar
Don Gagne committed
566
    _trimsState_worker(testModeStandalone);
567 568 569
}

void PX4RCCalibrationTest::_fullCalibration_test(void) {
Don Gagne's avatar
Don Gagne committed
570
    _centerChannels();
571 572
    QTest::mouseClick(_nextButton, Qt::LeftButton);

Don Gagne's avatar
Don Gagne committed
573 574 575 576 577 578
    _beginState_worker(testModeFullSequence);
    _identifyState_worker(testModeFullSequence);
    _minMaxState_worker(testModeFullSequence);
    _centerThrottleState_worker(testModeFullSequence);
    _detectInversionState_worker(testModeFullSequence);
    _trimsState_worker(testModeFullSequence);
579 580 581 582 583

    // One more click and the parameters should get saved
    QTest::mouseClick(_nextButton, Qt::LeftButton);
    
    _validateParameters(validateAllMask);
Don Gagne's avatar
Don Gagne committed
584
    _validateWidgets(validateAllMask, _rgChannelSettingsPostValidate);
585 586
}

Don Gagne's avatar
Don Gagne committed
587 588
/// @brief Sends RC center point values on minimum set of channels.
void PX4RCCalibrationTest::_centerChannels(void)
589
{
Don Gagne's avatar
Don Gagne committed
590 591 592
    // Initialize available channels them to center point. This should also set the channel count above the
    // minimum such that we can enter the idle state.
    for (int i=0; i<_availableChannels; i++) {
593 594 595 596
        _mockUAS->emitRemoteControlChannelRawChanged(i, (float)PX4RCCalibration::_rcCalPWMCenterPoint);
    }
}

Don Gagne's avatar
Don Gagne committed
597
void PX4RCCalibrationTest::_validateParameters(int validateMask)
598 599 600 601 602 603 604 605 606
{
    MockQGCUASParamManager* paramMgr = _mockUAS->getMockQGCUASParamManager();
    MockQGCUASParamManager::ParamMap_t mapParamsSet = paramMgr->getMockSetParameters();

    QString minTpl("RC%1_MIN");
    QString maxTpl("RC%1_MAX");
    QString trimTpl("RC%1_TRIM");
    QString revTpl("RC%1_REV");
    
Don Gagne's avatar
Don Gagne committed
607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649
    // Check mapping for all fuctions
    for (int chanFunction=0; chanFunction<PX4RCCalibration::rcCalFunctionMax; chanFunction++) {
        int expectedParameterValue;
        
        if (PX4RCCalibration::_rgFunctionInfo[chanFunction].required) {
            // We only map the required functions. All functions should be mapped to the same channel index
            expectedParameterValue = chanFunction + 1; // 1-based parameter value
        } else {
            expectedParameterValue = 0;  // 0 signals no mapping
        }
        
        if (validateMask & validateMappingMask) {
            QCOMPARE(mapParamsSet.contains(PX4RCCalibration::_rgFunctionInfo[chanFunction].parameterName), true);
            QCOMPARE(mapParamsSet[PX4RCCalibration::_rgFunctionInfo[chanFunction].parameterName].toInt(), expectedParameterValue);
        }
    }

    // Validate the channel settings. Note the channels are 1-based in parameter names.
    for (int chan = 0; chan<PX4RCCalibration::_chanMax; chan++) {
        int oneBasedChannel = chan + 1;
        int rcMinExpected, rcMaxExpected, rcTrimExpected;
        bool convertOk;
        
        // Required channels have min/max set on them. Remaining channels are left to default.
        if (chan < PX4RCCalibration::_chanMinimum) {
            rcMinExpected = _testMinValue;
            rcMaxExpected = _testMaxValue;
        } else {
            rcMinExpected = PX4RCCalibration::_rcCalPWMDefaultMinValue;
            rcMaxExpected = PX4RCCalibration::_rcCalPWMDefaultMaxValue;
        }
        
        // Attitude control functions have trim set, other channels trim should be default
        if (chan >= PX4RCCalibration::rcCalFunctionFirstAttitudeFunction && chan <= PX4RCCalibration::rcCalFunctionLastAttitudeFunction) {
            if (chan == PX4RCCalibration::rcCalFunctionThrottle) {
                rcTrimExpected = _testThrottleTrimValue;
            } else {
                rcTrimExpected = _testTrimValue;
            }
        } else {
            rcTrimExpected = PX4RCCalibration::_rcCalPWMDefaultTrimValue;
        }

650
        if (validateMask & validateMinMaxMask) {
Don Gagne's avatar
Don Gagne committed
651 652 653 654 655 656 657 658 659 660 661 662
            QCOMPARE(mapParamsSet.contains(minTpl.arg(oneBasedChannel)), true);
            QCOMPARE(mapParamsSet.contains(maxTpl.arg(oneBasedChannel)), true);
            QCOMPARE(mapParamsSet[minTpl.arg(oneBasedChannel)].toInt(&convertOk), rcMinExpected);
            QCOMPARE(convertOk, true);
            QCOMPARE(mapParamsSet[maxTpl.arg(oneBasedChannel)].toInt(&convertOk), rcMaxExpected);
            QCOMPARE(convertOk, true);
        }
        
        if (validateMask & validateTrimsMask) {
            QCOMPARE(mapParamsSet.contains(trimTpl.arg(oneBasedChannel)), true);
            QCOMPARE(mapParamsSet[trimTpl.arg(oneBasedChannel)].toInt(&convertOk), rcTrimExpected);
            QCOMPARE(convertOk, true);
663 664
        }

Don Gagne's avatar
Don Gagne committed
665
        // No channels are reversed
666
        if (validateMask & validateReversedMask) {
Don Gagne's avatar
Don Gagne committed
667 668 669
            QCOMPARE(mapParamsSet.contains(revTpl.arg(oneBasedChannel)), true);
            QCOMPARE(mapParamsSet[revTpl.arg(oneBasedChannel)].toFloat(&convertOk), 1.0f /* not reversed */);
            QCOMPARE(convertOk, true);
670 671 672 673
        }
    }
    
    if (validateMask & validateMappingMask) {
Don Gagne's avatar
Don Gagne committed
674
        // Check mapping for all fuctions
675 676
        for (int chanFunction=0; chanFunction<PX4RCCalibration::rcCalFunctionMax; chanFunction++) {
            QCOMPARE(mapParamsSet.contains(PX4RCCalibration::_rgFunctionInfo[chanFunction].parameterName), true);
Don Gagne's avatar
Don Gagne committed
677 678

            // We only map the required functions
679
            int expectedValue;
Don Gagne's avatar
Don Gagne committed
680 681
            if (PX4RCCalibration::_rgFunctionInfo[chanFunction].required) {
                // All functions should be mapped to the same channel index
682
                expectedValue = chanFunction + 1; // 1-based
Don Gagne's avatar
Don Gagne committed
683 684
            } else {
                expectedValue = 0;  // 0 signals no mapping
685 686 687 688
            }
            QCOMPARE(mapParamsSet[PX4RCCalibration::_rgFunctionInfo[chanFunction].parameterName].toInt(), expectedValue);
        }
    }
Don Gagne's avatar
Don Gagne committed
689
}
690

Don Gagne's avatar
Don Gagne committed
691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710
void PX4RCCalibrationTest::_validateWidgets(int validateMask, const struct ChannelSettings* rgChannelSettings)
{
    // Radio channel widgets should be displaying the current min/max we just set. Wait a bit for ui to update before checking.
    
    QTest::qWait(PX4RCCalibration::_updateInterval * 2);
    
    for (int chan=0; chan<_availableChannels; chan++) {
        RCChannelWidget* radioWidget = _rgRadioWidget[chan];
        Q_ASSERT(radioWidget);

        if (validateMask & validateMinMaxMask) {
            QCOMPARE(radioWidget->isMinMaxShown(), rgChannelSettings[chan].isMinMaxShown);
            QCOMPARE(radioWidget->min(), rgChannelSettings[chan].rcMin);
            QCOMPARE(radioWidget->max(), rgChannelSettings[chan].rcMax);
            QCOMPARE(radioWidget->isMinValid(), rgChannelSettings[chan].isMinValid);
            QCOMPARE(radioWidget->isMaxValid(), rgChannelSettings[chan].isMaxValid);
        }
        
        if (validateMask & validateTrimsMask) {
            QCOMPARE(radioWidget->trim(), rgChannelSettings[chan].rcTrim);
711 712
        }
    }
Don Gagne's avatar
Don Gagne committed
713
    
Don Gagne's avatar
Don Gagne committed
714
    for (int chan=_availableChannels; chan<PX4RCCalibration::_chanMax; chan++) {
Don Gagne's avatar
Don Gagne committed
715 716 717
        QCOMPARE(_rgRadioWidget[chan]->isEnabled(), false);
    }
}