Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Q
qgroundcontrol
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Valentin Platzgummer
qgroundcontrol
Commits
438cf74c
Commit
438cf74c
authored
6 years ago
by
DonLakeFlyer
Browse files
Options
Downloads
Patches
Plain Diff
Carryover ArduPilot changes from stable
parent
e3833aa5
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/MissionManager/PlanManager.cc
+8
-0
8 additions, 0 deletions
src/MissionManager/PlanManager.cc
src/MissionManager/PlanManager.h
+1
-1
1 addition, 1 deletion
src/MissionManager/PlanManager.h
with
9 additions
and
1 deletion
src/MissionManager/PlanManager.cc
+
8
−
0
View file @
438cf74c
...
@@ -589,6 +589,14 @@ void PlanManager::_handleMissionAck(const mavlink_message_t& message)
...
@@ -589,6 +589,14 @@ void PlanManager::_handleMissionAck(const mavlink_message_t& message)
return
;
return
;
}
}
if
(
_vehicle
->
apmFirmware
()
&&
missionAck
.
type
==
MAV_MISSION_INVALID_SEQUENCE
)
{
// ArduPilot sends these Acks which can happen just due to noisy links causing duplicated requests being responded to.
// As far as I'm concerned this is incorrect protocol implementation but we need to deal with it anyway. So we just
// ignore it and if things really go haywire the timeouts will fire to fail the overall transaction.
qCDebug
(
PlanManagerLog
)
<<
QStringLiteral
(
"_handleMissionAck ArduPilot sending possibly bogus MAV_MISSION_INVALID_SEQUENCE"
).
arg
(
_planTypeString
())
<<
_planType
;
return
;
}
// Save the retry ack before calling _checkForExpectedAck since we'll need it to determine what
// Save the retry ack before calling _checkForExpectedAck since we'll need it to determine what
// type of a protocol sequence we are in.
// type of a protocol sequence we are in.
AckType_t
savedExpectedAck
=
_expectedAck
;
AckType_t
savedExpectedAck
=
_expectedAck
;
...
...
This diff is collapsed.
Click to expand it.
src/MissionManager/PlanManager.h
+
1
−
1
View file @
438cf74c
...
@@ -71,7 +71,7 @@ public:
...
@@ -71,7 +71,7 @@ public:
// These values are public so the unit test can set appropriate signal wait times
// These values are public so the unit test can set appropriate signal wait times
// When passively waiting for a mission process, use a longer timeout.
// When passively waiting for a mission process, use a longer timeout.
static
const
int
_ackTimeoutMilliseconds
=
1
0
00
;
static
const
int
_ackTimeoutMilliseconds
=
1
5
00
;
// When actively retrying to request mission items, use a shorter timeout instead.
// When actively retrying to request mission items, use a shorter timeout instead.
static
const
int
_retryTimeoutMilliseconds
=
250
;
static
const
int
_retryTimeoutMilliseconds
=
250
;
static
const
int
_maxRetryCount
=
5
;
static
const
int
_maxRetryCount
=
5
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment