From e6e826bd14c442e2fc1b36c222934cc4dcde640a Mon Sep 17 00:00:00 2001
From: Gus Grubba <mavlink@grubba.com>
Date: Mon, 6 Mar 2017 03:11:29 -0500
Subject: [PATCH] Making toolbar indicator list private.

---
 src/FirmwarePlugin/APM/ArduSubFirmwarePlugin.cc | 16 ++++++++--------
 src/FirmwarePlugin/APM/ArduSubFirmwarePlugin.h  |  3 ++-
 src/FirmwarePlugin/FirmwarePlugin.cc            |  2 +-
 src/FirmwarePlugin/FirmwarePlugin.h             |  6 ++----
 src/Vehicle/Vehicle.cc                          |  2 +-
 src/Vehicle/Vehicle.h                           |  4 ++--
 6 files changed, 16 insertions(+), 17 deletions(-)

diff --git a/src/FirmwarePlugin/APM/ArduSubFirmwarePlugin.cc b/src/FirmwarePlugin/APM/ArduSubFirmwarePlugin.cc
index 61c8acc54..3bc7ad2ca 100644
--- a/src/FirmwarePlugin/APM/ArduSubFirmwarePlugin.cc
+++ b/src/FirmwarePlugin/APM/ArduSubFirmwarePlugin.cc
@@ -107,16 +107,16 @@ bool ArduSubFirmwarePlugin::supportsMotorInterference(void)
     return false;
 }
 
-QVariantList& ArduSubFirmwarePlugin::toolBarIndicators(const Vehicle* vehicle)
+const QVariantList& ArduSubFirmwarePlugin::toolBarIndicators(const Vehicle* vehicle)
 {
     Q_UNUSED(vehicle);
     //-- Sub specific list of indicators (Enter your modified list here)
-    if(_toolBarIndicatorList.size() == 0) {
-        _toolBarIndicatorList.append(QVariant::fromValue(QUrl::fromUserInput("qrc:/toolbar/MessageIndicator.qml")));
-        _toolBarIndicatorList.append(QVariant::fromValue(QUrl::fromUserInput("qrc:/toolbar/TelemetryRSSIIndicator.qml")));
-        _toolBarIndicatorList.append(QVariant::fromValue(QUrl::fromUserInput("qrc:/toolbar/RCRSSIIndicator.qml")));
-        _toolBarIndicatorList.append(QVariant::fromValue(QUrl::fromUserInput("qrc:/toolbar/BatteryIndicator.qml")));
-        _toolBarIndicatorList.append(QVariant::fromValue(QUrl::fromUserInput("qrc:/toolbar/ModeIndicator.qml")));
+    if(_toolBarIndicators.size() == 0) {
+        _toolBarIndicators.append(QVariant::fromValue(QUrl::fromUserInput("qrc:/toolbar/MessageIndicator.qml")));
+        _toolBarIndicators.append(QVariant::fromValue(QUrl::fromUserInput("qrc:/toolbar/TelemetryRSSIIndicator.qml")));
+        _toolBarIndicators.append(QVariant::fromValue(QUrl::fromUserInput("qrc:/toolbar/RCRSSIIndicator.qml")));
+        _toolBarIndicators.append(QVariant::fromValue(QUrl::fromUserInput("qrc:/toolbar/BatteryIndicator.qml")));
+        _toolBarIndicators.append(QVariant::fromValue(QUrl::fromUserInput("qrc:/toolbar/ModeIndicator.qml")));
     }
-    return _toolBarIndicatorList;
+    return _toolBarIndicators;
 }
diff --git a/src/FirmwarePlugin/APM/ArduSubFirmwarePlugin.h b/src/FirmwarePlugin/APM/ArduSubFirmwarePlugin.h
index f8ca03ba8..e1b8150b6 100644
--- a/src/FirmwarePlugin/APM/ArduSubFirmwarePlugin.h
+++ b/src/FirmwarePlugin/APM/ArduSubFirmwarePlugin.h
@@ -86,9 +86,10 @@ public:
     QString brandImage(const Vehicle* vehicle) const { Q_UNUSED(vehicle); return QStringLiteral("/qmlimages/APM/BrandImageSub"); }
     const FirmwarePlugin::remapParamNameMajorVersionMap_t& paramNameRemapMajorVersionMap(void) const final { return _remapParamName; }
     int remapParamNameHigestMinorVersionNumber(int majorVersionNumber) const final;
-    QVariantList& toolBarIndicators(const Vehicle* vehicle) final;
+    const QVariantList& toolBarIndicators(const Vehicle* vehicle) final;
 
 private:
+    QVariantList _toolBarIndicators;
     static bool _remapParamNameIntialized;
     static FirmwarePlugin::remapParamNameMajorVersionMap_t  _remapParamName;
 };
diff --git a/src/FirmwarePlugin/FirmwarePlugin.cc b/src/FirmwarePlugin/FirmwarePlugin.cc
index ac018b68b..87372a617 100644
--- a/src/FirmwarePlugin/FirmwarePlugin.cc
+++ b/src/FirmwarePlugin/FirmwarePlugin.cc
@@ -341,7 +341,7 @@ QString FirmwarePlugin::vehicleImageCompass(const Vehicle* vehicle) const
     return QStringLiteral("/qmlimages/compassInstrumentArrow.svg");
 }
 
-QVariantList& FirmwarePlugin::toolBarIndicators(const Vehicle* vehicle)
+const QVariantList &FirmwarePlugin::toolBarIndicators(const Vehicle* vehicle)
 {
     Q_UNUSED(vehicle);
     //-- Default list of indicators for all vehicles.
diff --git a/src/FirmwarePlugin/FirmwarePlugin.h b/src/FirmwarePlugin/FirmwarePlugin.h
index 45954d300..e63836d45 100644
--- a/src/FirmwarePlugin/FirmwarePlugin.h
+++ b/src/FirmwarePlugin/FirmwarePlugin.h
@@ -259,7 +259,7 @@ public:
 
     /// Allows the core plugin to override the toolbar indicators
     /// @return A list of QUrl with the indicators (see MainToolBarIndicators.qml)
-    virtual QVariantList& toolBarIndicators(const Vehicle* vehicle);
+    virtual const QVariantList& toolBarIndicators(const Vehicle* vehicle);
 
     /// Returns a list of CameraMetaData objects for available cameras on the vehicle.
     virtual const QVariantList& cameraList(const Vehicle* vehicle);
@@ -267,10 +267,8 @@ public:
     // FIXME: Hack workaround for non pluginize FollowMe support
     static const char* px4FollowMeFlightMode;
 
-protected:
-    QVariantList _toolBarIndicatorList;
-
 private:
+    QVariantList _toolBarIndicatorList;
     static QVariantList _cameraList;    ///< Standard QGC camera list
 
 };
diff --git a/src/Vehicle/Vehicle.cc b/src/Vehicle/Vehicle.cc
index d3fd9db5e..0ea67378c 100644
--- a/src/Vehicle/Vehicle.cc
+++ b/src/Vehicle/Vehicle.cc
@@ -2375,7 +2375,7 @@ QString Vehicle::vehicleImageCompass() const
         return QString();
 }
 
-QVariantList& Vehicle::toolBarIndicators()
+const QVariantList& Vehicle::toolBarIndicators()
 {
     if(_firmwarePlugin) {
         return _firmwarePlugin->toolBarIndicators(this);
diff --git a/src/Vehicle/Vehicle.h b/src/Vehicle/Vehicle.h
index f3e226d2f..e10775014 100644
--- a/src/Vehicle/Vehicle.h
+++ b/src/Vehicle/Vehicle.h
@@ -653,8 +653,8 @@ public:
     QString vehicleImageOutline () const;
     QString vehicleImageCompass () const;
 
-    QVariantList& toolBarIndicators();
-    const QVariantList& cameraList(void) const;
+    const QVariantList& toolBarIndicators   ();
+    const QVariantList& cameraList          (void) const;
 
 
 public slots:
-- 
2.22.0