From e3a1f0169a0bf4c436eed09bea96364d8c9b6173 Mon Sep 17 00:00:00 2001 From: Don Gagne Date: Fri, 2 Dec 2016 15:34:40 -0800 Subject: [PATCH] _requestListNoResponse fixed up and back on --- src/FactSystem/ParameterManagerTest.cc | 7 ++++--- src/FactSystem/ParameterManagerTest.h | 3 +-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/FactSystem/ParameterManagerTest.cc b/src/FactSystem/ParameterManagerTest.cc index ae362f278..9ed18f0cd 100644 --- a/src/FactSystem/ParameterManagerTest.cc +++ b/src/FactSystem/ParameterManagerTest.cc @@ -64,10 +64,12 @@ void ParameterManagerTest::_requestListMissingParamSuccess(void) _noFailureWorker(MockConfiguration::FailMissingParamOnInitialReqest); } -#if 0 // Test no response to param_request_list void ParameterManagerTest::_requestListNoResponse(void) { + // Will pop error about request failure + setExpectedMessageBox(QMessageBox::Ok); + Q_ASSERT(!_mockLink); _mockLink = MockLink::startPX4MockLink(false, MockConfiguration::FailParamNoReponseToRequestList); @@ -93,9 +95,8 @@ void ParameterManagerTest::_requestListNoResponse(void) QCOMPARE(spyParamsReady.wait(40000), false); // User should have been notified - checkMultipleExpectedMessageBox(5); + checkExpectedMessageBox(); } -#endif // MockLink will fail to send a param on initial request, it will also fail to send it on subsequent // param_read requests. diff --git a/src/FactSystem/ParameterManagerTest.h b/src/FactSystem/ParameterManagerTest.h index 7d732169f..374eebba5 100644 --- a/src/FactSystem/ParameterManagerTest.h +++ b/src/FactSystem/ParameterManagerTest.h @@ -22,8 +22,7 @@ class ParameterManagerTest : public UnitTest private slots: void _noFailure(void); - // FIXME: Hack to work around changed no reponse handling - //void _requestListNoResponse(void); + void _requestListNoResponse(void); void _requestListMissingParamSuccess(void); void _requestListMissingParamFail(void); -- 2.22.0