Unverified Commit e17deefa authored by Don Gagne's avatar Don Gagne Committed by GitHub

Merge pull request #7468 from mavlink/pr-win_instant_close

Windows UX improvement: improve the windows 1.5s closing workaround
parents cbed3887 a8e5d076
......@@ -181,36 +181,12 @@ ApplicationWindow {
}
}
//-------------------------------------------------------------------------
//-- Weird hack that has to be fixed elsewhere and have this removed
property bool _forceClose: false
function reallyClose() {
_forceClose = true
mainWindow.close()
}
function finishCloseProcess() {
QGroundControl.linkManager.shutdown()
// The above shutdown causes a flurry of activity as the vehicle components are removed. This in turn
// causes the Windows Version of Qt to crash if you allow the close event to be accepted. In order to prevent
// the crash, we ignore the close event and setup a delayed timer to close the window after things settle down.
if(ScreenTools.isWindows) {
delayedWindowCloseTimer.start()
} else {
reallyClose()
}
}
Timer {
id: delayedWindowCloseTimer
interval: 1500
running: false
repeat: false
onTriggered: {
reallyClose()
}
_forceClose = true
mainWindow.close()
}
MessageDialog {
......@@ -234,6 +210,7 @@ ApplicationWindow {
//-- Check for unsaved missions
onClosing: {
// Check first for unsaved missions and active connections
if (!_forceClose) {
unsavedMissionCloseDialog.check()
close.accepted = false
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment