From d862ec870f37e55fec79ebd3d81a9ab5d4ba6301 Mon Sep 17 00:00:00 2001
From: tstellanova <tstellanova+github@gmail.com>
Date: Fri, 9 Aug 2013 00:03:13 -0700
Subject: [PATCH] rm totalOnboardParameters

---
 src/uas/QGCUASParamManager.cc     | 23 +++--------------------
 src/uas/UASParameterDataModel.cc  |  3 ++-
 src/uas/UASParameterDataModel.h   |  2 --
 src/ui/designer/QGCParamSlider.cc |  3 +++
 4 files changed, 8 insertions(+), 23 deletions(-)

diff --git a/src/uas/QGCUASParamManager.cc b/src/uas/QGCUASParamManager.cc
index 1dd6050c5..c1b29e88f 100644
--- a/src/uas/QGCUASParamManager.cc
+++ b/src/uas/QGCUASParamManager.cc
@@ -8,7 +8,9 @@
 
 QGCUASParamManager::QGCUASParamManager(UASInterface* uas, QWidget *parent) :
     QWidget(parent),
-    mav(uas)
+    mav(uas),
+    paramDataModel(NULL),
+    paramCommsMgr(NULL)
 {
     paramDataModel = uas->getParamDataModel();
     paramCommsMgr = uas->getParamCommsMgr();
@@ -18,25 +20,6 @@ QGCUASParamManager::QGCUASParamManager(UASInterface* uas, QWidget *parent) :
     loadParamMetaInfoCSV();
 
 
-//    // Connect retransmission guard
-//    connect(this, SIGNAL(parameterUpdateRequested(int,QString)),
-//            this, SLOT(requestParameterUpdate(int,QString)));
-
-//    //TODO connect in paramCommsMgr instead
-//    connect(this, SIGNAL(parameterUpdateRequestedById(int,int)),
-//            mav, SLOT(requestParameter(int,int)));
-
-    // New parameters from UAS
-
-    void parameterUpdated(int compId, QString paramName, QVariant value);
-
-
-//    connect(uas, SIGNAL(parameterChanged(int,int,int,int,QString,QVariant)),
-//            this, SLOT(receivedParameterUpdate(int,int,int,int,QString,QVariant)));
-
-
-
-
 
 }
 
diff --git a/src/uas/UASParameterDataModel.cc b/src/uas/UASParameterDataModel.cc
index 9815ce777..96d7479f0 100644
--- a/src/uas/UASParameterDataModel.cc
+++ b/src/uas/UASParameterDataModel.cc
@@ -11,7 +11,8 @@
 UASParameterDataModel::UASParameterDataModel(QObject *parent) :
     QObject(parent)
 {
-
+    onboardParameters.clear();
+    pendingParameters.clear();
 
 }
 
diff --git a/src/uas/UASParameterDataModel.h b/src/uas/UASParameterDataModel.h
index 219eff900..535cc0308 100644
--- a/src/uas/UASParameterDataModel.h
+++ b/src/uas/UASParameterDataModel.h
@@ -14,7 +14,6 @@ public:
     explicit UASParameterDataModel(QObject *parent = 0);
     
 
-    int getTotalOnboardParams() { return totalOnboardParameters; }
     //Parameter meta info
     bool isParamMinKnown(const QString& param) { return paramMin.contains(param); }
     virtual bool isValueLessThanParamMin(const QString& param, double dblVal);
@@ -97,7 +96,6 @@ protected:
     int     uasId; ///< The UAS / MAV to which this data model pertains
     QMap<int, QMap<QString, QVariant>* > pendingParameters; ///< Changed values that have not yet been transmitted to the UAS, by component ID
     QMap<int, QMap<QString, QVariant>* > onboardParameters; ///< All parameters confirmed to be stored onboard the UAS, by component ID
-    int totalOnboardParameters;///< The known count of onboard parameters, may not match onboardParameters until all params are received
 
     // Tooltip data structures
     QMap<QString, QString> paramDescriptions; ///< Tooltip values
diff --git a/src/ui/designer/QGCParamSlider.cc b/src/ui/designer/QGCParamSlider.cc
index e927dea03..32b236a4b 100644
--- a/src/ui/designer/QGCParamSlider.cc
+++ b/src/ui/designer/QGCParamSlider.cc
@@ -175,6 +175,9 @@ void QGCParamSlider::selectParameter(int paramIndex)
 {
     // Set name
     parameterName = ui->editSelectParamComboBox->itemText(paramIndex);
+    if (parameterName.isEmpty()) {
+        return;
+    }
 
     // Update min and max values if available
     if (uas) {
-- 
2.22.0