From ce674f46cd38b070aae2e2b89036c6e40fcd49ec Mon Sep 17 00:00:00 2001 From: Aleksey Kontsevich Date: Mon, 25 May 2020 22:02:19 +0300 Subject: [PATCH] Localize warnings disabling to cpp file only --- src/Vehicle/Vehicle.cc | 29 +++++++++++++++++++++++++++++ src/Vehicle/Vehicle.h | 18 ------------------ src/uas/UAS.h | 18 ------------------ 3 files changed, 29 insertions(+), 36 deletions(-) diff --git a/src/Vehicle/Vehicle.cc b/src/Vehicle/Vehicle.cc index baf2a3952..1e6bed12b 100644 --- a/src/Vehicle/Vehicle.cc +++ b/src/Vehicle/Vehicle.cc @@ -1916,6 +1916,24 @@ void Vehicle::_handleRadioStatus(mavlink_message_t& message) } } +// Ignore warnings from mavlink headers for both GCC/Clang and MSVC +#ifdef __GNUC__ + +#if __GNUC__ > 8 +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Waddress-of-packed-member" +#elif defined(__clang__) +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Waddress-of-packed-member" +#else +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wall" +#endif + +#else +#pragma warning(push, 0) +#endif + void Vehicle::_handleRCChannels(mavlink_message_t& message) { mavlink_rc_channels_t channels; @@ -2003,6 +2021,17 @@ void Vehicle::_handleRCChannelsRaw(mavlink_message_t& message) emit rcChannelsChanged(channelCount, pwmValues); } +// Pop warnings ignoring for mavlink headers for both GCC/Clang and MSVC +#ifdef __GNUC__ + #if defined(__clang__) + #pragma clang diagnostic pop + #else + #pragma GCC diagnostic pop + #endif +#else +#pragma warning(pop, 0) +#endif + void Vehicle::_handleScaledPressure(mavlink_message_t& message) { mavlink_scaled_pressure_t pressure; mavlink_msg_scaled_pressure_decode(&message, &pressure); diff --git a/src/Vehicle/Vehicle.h b/src/Vehicle/Vehicle.h index bd5ac5a55..b86335c35 100644 --- a/src/Vehicle/Vehicle.h +++ b/src/Vehicle/Vehicle.h @@ -9,24 +9,6 @@ #pragma once -// Ignore warnings from mavlink headers for both GCC/Clang and MSVC -#ifdef __GNUC__ - -#if __GNUC__ > 8 -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Waddress-of-packed-member" -#elif defined(__clang__) -#pragma clang diagnostic push -#pragma clang diagnostic ignored "-Waddress-of-packed-member" -#else -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wall" -#endif - -#else -#pragma warning(push, 0) -#endif - #include #include #include diff --git a/src/uas/UAS.h b/src/uas/UAS.h index 6788cbeb6..9a38b6d59 100644 --- a/src/uas/UAS.h +++ b/src/uas/UAS.h @@ -13,24 +13,6 @@ #pragma once -// Ignore warnings from mavlink headers for both GCC/Clang and MSVC -#ifdef __GNUC__ - -#if __GNUC__ > 8 -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Waddress-of-packed-member" -#elif defined(__clang__) -#pragma clang diagnostic push -#pragma clang diagnostic ignored "-Waddress-of-packed-member" -#else -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wall" -#endif - -#else -#pragma warning(push, 0) -#endif - #include "UASInterface.h" #include #include -- 2.22.0