Merge pull request #7783 from DonLakeFlyer/QTFatalWarnings

QT_FATAL_WARNINGS on for unit tests

.travis.yml

@@ -187,6 +187,7 @@ script:
   - if [[ "${SPEC}" = "linux-g++-64" && "${CONFIG}" = "debug" ]]; then
     	mkdir -p ~/.config/QtProject/ &&
         cp ${TRAVIS_BUILD_DIR}/test/qtlogging.ini ~/.config/QtProject/ &&
+        export QT_FATAL_WARNINGS=1 &&
         ./debug/qgroundcontrol-start.sh --unittest;
     fi
 

src/Audio/AudioOutput.cc

@@ -17,9 +17,17 @@
 #include "SettingsManager.h"
 
 AudioOutput::AudioOutput(QGCApplication* app, QGCToolbox* toolbox)
-    : QGCTool(app, toolbox)
-    , _tts(new QTextToSpeech(this))
+    : QGCTool   (app, toolbox)
+    , _tts      (nullptr)
 {
+    if (qgcApp()->runningUnitTests()) {
+        // Cloud based unit tests don't have speech capabilty. If you try to crank up
+        // speech engine it will pop a qWarning which prevents usage of QT_FATAL_WARNINGS
+        return;
+    }
+
+    _tts = new QTextToSpeech(this);
+
     //-- Force TTS engine to English as all incoming messages from the autopilot
     //   are in English and not localized.
 #ifdef Q_OS_LINUX
@@ -28,8 +36,13 @@ AudioOutput::AudioOutput(QGCApplication* app, QGCToolbox* toolbox)
     connect(_tts, &QTextToSpeech::stateChanged, this, &AudioOutput::_stateChanged);
 }
 
-bool AudioOutput::say(const QString& inText)
+void AudioOutput::say(const QString& inText)
 {
+    if (!_tts) {
+        qDebug() << "say" << inText;
+        return;
+    }
+
     bool muted = qgcApp()->toolbox()->settingsManager()->appSettings()->audioMuted()->rawValue().toBool();
     muted |= qgcApp()->runningUnitTests();
     if (!muted && !qgcApp()->runningUnitTests()) {
@@ -46,7 +59,6 @@ bool AudioOutput::say(const QString& inText)
             _tts->say(text);
         }
     }
-    return true;
 }
 
 void AudioOutput::_stateChanged(QTextToSpeech::State state)

src/Audio/AudioOutput.h

@@ -29,7 +29,7 @@ public:
     static QString  fixTextMessageForAudio  (const QString& string);
 
 public slots:
-    bool            say                     (const QString& text);
+    void            say                     (const QString& text);
 
 private slots:
     void            _stateChanged           (QTextToSpeech::State state);

src/PositionManager/PositionManager.cpp

@@ -34,7 +34,13 @@ void QGCPositionManager::setToolbox(QGCToolbox *toolbox)
    QGCTool::setToolbox(toolbox);
    //-- First see if plugin provides a position source
    _defaultSource = toolbox->corePlugin()->createPositionSource(this);
-   if(!_defaultSource) {
+
+   if (qgcApp()->runningUnitTests()) {
+       // Units test on travis fail due to lack of position source
+       return;
+   }
+
+   if (!_defaultSource) {
        //-- Otherwise, create a default one
        _defaultSource = QGeoPositionInfoSource::createDefaultSource(this);
    }

src/QGCApplication.cc

@@ -724,6 +724,9 @@ void QGCApplication::showMessage(const QString& message)
         QVariant varReturn;
         QVariant varMessage = QVariant::fromValue(message);
         QMetaObject::invokeMethod(_rootQmlObject(), "showMessage", Q_RETURN_ARG(QVariant, varReturn), Q_ARG(QVariant, varMessage));
+    } else if (runningUnitTests()) {
+        // Unit tests can run without UI
+        qDebug() << "QGCApplication::showMessage unittest" << message;
     } else {
         qWarning() << "Internal error";
     }

src/QtLocationPlugin/QGCTileCacheWorker.cpp

@@ -1136,7 +1136,7 @@ QGCCacheWorker::_lookupReady(QHostInfo info)
             return;
         }
     }
-    qWarning() << "No Internet Access";
+    qDebug() << "No Internet Access";
     emit internetStatus(false);
 #endif
 }