-Wreorder fixes

qgroundcontrol.pro

@@ -129,7 +129,6 @@ MacBuild | LinuxBuild {
 	QMAKE_CXXFLAGS_WARN_ON += \
         -Wall \
         -Wno-unused-parameter \
-        -Wno-reorder \
         -Wno-unused-variable \
         -Wno-narrowing \
         -Wno-unused-function

src/comm/XbeeLink.cpp

@@ -7,8 +7,14 @@
 #include "XbeeLink.h"
 
 XbeeLink::XbeeLink(QString portName, int baudRate) : 
-	m_xbeeCon(NULL), m_portName(NULL), m_portNameLength(0), m_baudRate(baudRate), m_connected(false), m_id(-1),
-	m_addrHigh(0), m_addrLow(0)
+	m_xbeeCon(NULL),
+    m_id(-1),
+    m_portName(NULL),
+    m_portNameLength(0),
+    m_baudRate(baudRate),
+    m_connected(false),
+	m_addrHigh(0),
+    m_addrLow(0)
 {
 
 	/* setup the xbee */

src/uas/UAS.cc

@@ -115,23 +115,19 @@ UAS::UAS(MAVLinkProtocol* protocol, int id) : UASInterface(),
     altitudeAMSL(0.0),
     altitudeRelative(0.0),
 
-    airSpeed(std::numeric_limits<double>::quiet_NaN()),
-    groundSpeed(std::numeric_limits<double>::quiet_NaN()),
+    globalEstimatorActive(false),
+
+    latitude_gps(0.0),
+    longitude_gps(0.0),
+    altitude_gps(0.0),
 
     speedX(0.0),
     speedY(0.0),
     speedZ(0.0),
 
-    globalEstimatorActive(false),
-    latitude_gps(0.0),
-    longitude_gps(0.0),
-    altitude_gps(0.0),
     nedPosGlobalOffset(0,0,0),
     nedAttGlobalOffset(0,0,0),
 
-    waypointManager(this),
-    paramMgr(this),
-
     #if defined(QGC_PROTOBUF_ENABLED) && defined(QGC_USE_PIXHAWK_MESSAGES)
     receivedOverlayTimestamp(0.0),
     receivedObstacleListTimestamp(0.0),
@@ -140,6 +136,10 @@ UAS::UAS(MAVLinkProtocol* protocol, int id) : UASInterface(),
     receivedRGBDImageTimestamp(0.0),
     #endif
 
+    airSpeed(std::numeric_limits<double>::quiet_NaN()),
+    groundSpeed(std::numeric_limits<double>::quiet_NaN()),
+    waypointManager(this),
+
     attitudeKnown(false),
     attitudeStamped(false),
     lastAttitude(0),
@@ -148,7 +148,12 @@ UAS::UAS(MAVLinkProtocol* protocol, int id) : UASInterface(),
     pitch(0.0),
     yaw(0.0),
 
+    blockHomePositionChanges(false),
+    receivedMode(false),
+
+
     paramsOnceRequested(false),
+    paramMgr(this),
     simulation(0),
 
     // The protected members.
@@ -159,9 +164,7 @@ UAS::UAS(MAVLinkProtocol* protocol, int id) : UASInterface(),
     hilEnabled(false),
     sensorHil(false),
     lastSendTimeGPS(0),
-    lastSendTimeSensors(0),
-    blockHomePositionChanges(false),
-    receivedMode(false)
+    lastSendTimeSensors(0)
 {
     for (unsigned int i = 0; i<255;++i)
     {

src/ui/HUD.cc

@@ -57,6 +57,7 @@ This file is part of the QGROUNDCONTROL project
  */
 HUD::HUD(int width, int height, QWidget* parent)
     : QLabel(parent),
+      image(NULL),
       uas(NULL),
       yawInt(0.0f),
       mode(tr("UNKNOWN MODE")),
@@ -111,11 +112,10 @@ HUD::HUD(int width, int height, QWidget* parent)
       nextOfflineImage(""),
       HUDInstrumentsEnabled(false),
       videoEnabled(true),
+      imageLoggingEnabled(false),
       xImageFactor(1.0),
       yImageFactor(1.0),
-      imageLoggingEnabled(false),
-      imageRequested(false),
-      image(NULL)
+      imageRequested(false)
 {
     Q_UNUSED(width);
     Q_UNUSED(height);

src/ui/MainWindow.cc

@@ -121,13 +121,13 @@ MainWindow::MainWindow(QWidget *parent):
     currentStyle(QGC_MAINWINDOW_STYLE_DARK),
     aboutToCloseFlag(false),
     changingViewsFlag(false),
+    mavlink(new MAVLinkProtocol()),
     centerStackActionGroup(new QActionGroup(this)),
     darkStyleFileName(defaultDarkStyle),
     lightStyleFileName(defaultLightStyle),
     autoReconnect(false),
     simulationLink(NULL),
     lowPowerMode(false),
-    mavlink(new MAVLinkProtocol()),
     customMode(CUSTOM_MODE_NONE),
     menuActionHelper(new MenuActionHelper())
 {

src/ui/QGCBaseParamWidget.cc

@@ -11,8 +11,8 @@
 
 QGCBaseParamWidget::QGCBaseParamWidget(QWidget *parent) :
     QWidget(parent),
-    mav(NULL),
     paramMgr(NULL),
+    mav(NULL),
     updatingParamNameLock("")
 {
 }

src/ui/QGCSettingsWidget.cc

@@ -13,8 +13,8 @@
 
 QGCSettingsWidget::QGCSettingsWidget(QWidget *parent, Qt::WindowFlags flags) :
     QDialog(parent, flags),
-    ui(new Ui::QGCSettingsWidget),
-    mainWindow((MainWindow*)parent)
+    mainWindow((MainWindow*)parent),
+    ui(new Ui::QGCSettingsWidget)
 {
     ui->setupUi(this);
 

src/ui/main/QGCViewModeSelection.cc

@@ -5,8 +5,8 @@
 
 QGCViewModeSelection::QGCViewModeSelection(QWidget *parent) :
     QWidget(parent),
-    selected(false),
-    ui(new Ui::QGCViewModeSelection)
+    ui(new Ui::QGCViewModeSelection),
+    selected(false)
 {
     ui->setupUi(this);
 

src/ui/map/QGCMapToolBar.cc

@@ -7,12 +7,12 @@ QGCMapToolBar::QGCMapToolBar(QWidget *parent) :
     ui(new Ui::QGCMapToolBar),
     map(NULL),
     optionsMenu(this),
-    mapTypesMenu(this),
     trailPlotMenu(this),
     updateTimesMenu(this),
-    mapTypesGroup(new QActionGroup(this)),
+    mapTypesMenu(this),
     trailSettingsGroup(new QActionGroup(this)),
-    updateTimesGroup(new QActionGroup(this))
+    updateTimesGroup(new QActionGroup(this)),
+    mapTypesGroup(new QActionGroup(this))
 {
     ui->setupUi(this);
 }