From c77d8df1ba52cea8d374f77e8adabc2ff9ec2d7f Mon Sep 17 00:00:00 2001
From: Gus Grubba <mavlink@grubba.com>
Date: Wed, 26 Oct 2016 17:47:29 -0400
Subject: [PATCH] Make sure user knows an email is needed for log uploading.

---
 src/ui/preferences/MavlinkSettings.qml | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/src/ui/preferences/MavlinkSettings.qml b/src/ui/preferences/MavlinkSettings.qml
index 3beaa6067..b98e2b5c3 100644
--- a/src/ui/preferences/MavlinkSettings.qml
+++ b/src/ui/preferences/MavlinkSettings.qml
@@ -57,8 +57,8 @@ Rectangle {
         visible:    false
         icon:       StandardIcon.Warning
         standardButtons: StandardButton.Close
-        title:      qsTr("Uploading Log Files")
-        text:       qsTr("Please enter an email address before uploading log files.")
+        title:      qsTr("MAVLink Logging")
+        text:       qsTr("Please enter an email address before uploading MAVLink log files.")
     }
 
     QGCFlickable {
@@ -235,6 +235,11 @@ Rectangle {
                             anchors.verticalCenter: parent.verticalCenter
                             onEditingFinished: {
                                 QGroundControl.mavlinkLogManager.emailAddress = emailField.text
+                                if(emailField.text === "") {
+                                    autoUploadCheck.checked = false
+                                    QGroundControl.mavlinkLogManager.enableAutoUpload = false
+                                    console.log("forcing enableAutoUpload to false")
+                                }
                             }
                         }
                     }
@@ -283,9 +288,14 @@ Rectangle {
                         id:         autoUploadCheck
                         text:       qsTr("Enable automatic log uploads")
                         checked:    QGroundControl.mavlinkLogManager.enableAutoUpload
-                        enabled:    emailField.text !== "" && urlField !== ""
                         onClicked: {
-                            QGroundControl.mavlinkLogManager.enableAutoUpload = checked
+                            QGroundControl.mavlinkLogManager.emailAddress = emailField.text
+                            if(checked && QGroundControl.mavlinkLogManager.emailAddress === "") {
+                                checked = false
+                                emptyEmailDialog.open()
+                            } else {
+                                QGroundControl.mavlinkLogManager.enableAutoUpload = checked
+                            }
                         }
                     }
                     //-----------------------------------------------------------------
@@ -293,7 +303,7 @@ Rectangle {
                     QGCCheckBox {
                         text:       qsTr("Delete log file after uploading")
                         checked:    QGroundControl.mavlinkLogManager.deleteAfterUpload
-                        enabled:    emailField.text !== "" && urlField !== "" && autoUploadCheck.checked
+                        enabled:    autoUploadCheck.checked
                         onClicked: {
                             QGroundControl.mavlinkLogManager.deleteAfterUpload = checked
                         }
-- 
2.22.0