From c30599add013f1ae93b4962235c14e0a177317dc Mon Sep 17 00:00:00 2001 From: Daniel Agar Date: Sun, 13 Mar 2016 21:40:36 -0400 Subject: [PATCH] don't fail updating android version on PRs -fixes #2955 --- .travis.yml | 2 +- android/AndroidManifest.xml | 2 +- tools/update_android_version.sh | 7 +++++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index b42a86b08..b3baae714 100644 --- a/.travis.yml +++ b/.travis.yml @@ -114,7 +114,7 @@ before_script: - if [ "${CONFIG}" != "doxygen" ]; then mkdir ${SHADOW_BUILD_DIR} && cd ${SHADOW_BUILD_DIR} && qmake -r ${TRAVIS_BUILD_DIR}/qgroundcontrol.pro CONFIG+=${CONFIG} CONFIG+=WarningsAsErrorsOn -spec ${SPEC}; fi script: - - cd ${TRAVIS_BUILD_DIR} && ./tools/update_android_version.sh + - if [ "${TRAVIS_OS_NAME}" = "android" ]; then cd ${TRAVIS_BUILD_DIR} && ./tools/update_android_version.sh; fi - echo 'Building QGroundControl' && echo -en 'travis_fold:start:script.1\\r' - if [ "${CONFIG}" != "doxygen" ]; then cd ${SHADOW_BUILD_DIR} && make -j4; fi - if [ "${CONFIG}" = "doxygen" ]; then cd ${TRAVIS_BUILD_DIR}/src && doxygen documentation.dox; fi diff --git a/android/AndroidManifest.xml b/android/AndroidManifest.xml index 251c85ae4..8ad0e2fd1 100644 --- a/android/AndroidManifest.xml +++ b/android/AndroidManifest.xml @@ -1,5 +1,5 @@ - + diff --git a/tools/update_android_version.sh b/tools/update_android_version.sh index 02cdafff5..a8b3b86d1 100755 --- a/tools/update_android_version.sh +++ b/tools/update_android_version.sh @@ -1,5 +1,8 @@ #!/usr/bin/env bash +# this requires `master` in the git tree +# travis-ci branch builds are unable to set the version properly + MANIFEST_FILE=android/AndroidManifest.xml VERSIONCODE=`git rev-list master --first-parent --count` @@ -13,7 +16,7 @@ if [ -n "$VERSIONCODE" ]; then echo "Android version: ${VERSIONCODE}" else echo "Error versionCode empty" - exit 1 + exit 0 # don't cause the build to fail fi if [ -n "$VERSIONNAME" ]; then @@ -21,5 +24,5 @@ if [ -n "$VERSIONNAME" ]; then echo "Android name: ${VERSIONNAME}" else echo "Error versionName empty" - exit 1 + exit 0 # don't cause the build to fail fi -- 2.22.0