Merge pull request #987 from DonLakeFlyer/BugFixes

Bug fixes

files/styles/style-light.css

@@ -309,6 +309,11 @@ QPushButton#flightModeMenuButton, QPushButton#safetyConfigButton {
     background-color: qlineargradient(x1: 0, y1: 0, x2: 0, y2: 1, stop: 0 #BBB, stop: 1 #777);
 }
 
+VehicleSetupButton, VehicleComponentButton {
+    background-color: qlineargradient(x1: 0, y1: 0, x2: 0, y2: 1, stop: 0 #BBB, stop: 1 #777);
+    border-color: #465158;
+}
+
 QPushButton#planePushButton, QPushButton#flyingWingPushButton, QPushButton#quadXPushButton,
 QPushButton#quadPlusPushButton, QPushButton#hexaXPushButton, QPushButton#hexaPlusPushButton,
 QPushButton#octoXPushButton, QPushButton#octoPlusPushButton, QPushButton#hPushButton {

src/qgcunittest/MockUASManager.h

@@ -93,7 +93,6 @@ public slots:
     virtual bool returnActiveUAS() { Q_ASSERT(false); return false; }
     virtual bool stopActiveUAS() { Q_ASSERT(false); return false; }
     virtual bool killActiveUAS() { Q_ASSERT(false); return false; }
-    virtual void configureActiveUAS() { Q_ASSERT(false); }
     virtual bool shutdownActiveUAS() { Q_ASSERT(false); return false; }
     virtual bool setHomePosition(double lat, double lon, double alt)
         { Q_ASSERT(false); Q_UNUSED(lat); Q_UNUSED(lon); Q_UNUSED(alt); return false; }

src/uas/UASManager.cc

@@ -436,14 +436,6 @@ bool UASManager::shutdownActiveUAS()
     return (activeUAS);
 }
 
-void UASManager::configureActiveUAS()
-{
-    UASInterface* actUAS = getActiveUAS();
-    if(actUAS) {
-        // Do something
-    }
-}
-
 UASInterface* UASManager::getUASForId(int id)
 {
     UASInterface* system = NULL;

src/uas/UASManager.h

@@ -227,13 +227,6 @@ public slots:
      */
     bool killActiveUAS();
 
-    /**
-     * @brief Configure the currently active UAS
-     *
-     * This command will bring up the configuration dialog for the particular UAS.
-     */
-    void configureActiveUAS();
-
     /** @brief Shut down the onboard operating system down */
     bool shutdownActiveUAS();
 

src/uas/UASManagerInterface.h

@@ -82,7 +82,6 @@ public slots:
     virtual bool returnActiveUAS() = 0;
     virtual bool stopActiveUAS() = 0;
     virtual bool killActiveUAS() = 0;
-    virtual void configureActiveUAS() = 0;
     virtual bool shutdownActiveUAS() = 0;
     virtual bool setHomePosition(double lat, double lon, double alt) = 0;
     virtual bool setHomePositionAndNotify(double lat, double lon, double alt) = 0;

src/ui/MainWindow.cc

@@ -1237,7 +1237,6 @@ void MainWindow::connectCommonActions()
     connect(ui.actionEmergency_Land, SIGNAL(triggered()), UASManager::instance(), SLOT(stopActiveUAS()));
     connect(ui.actionEmergency_Kill, SIGNAL(triggered()), UASManager::instance(), SLOT(killActiveUAS()));
     connect(ui.actionShutdownMAV, SIGNAL(triggered()), UASManager::instance(), SLOT(shutdownActiveUAS()));
-    connect(ui.actionConfiguration, SIGNAL(triggered()), UASManager::instance(), SLOT(configureActiveUAS()));
 
     // Views actions
     connect(ui.actionFlightView, SIGNAL(triggered()), this, SLOT(loadPilotView()));

src/ui/MainWindow.ui

@@ -181,18 +181,6 @@
     <string>Add Link</string>
    </property>
   </action>
-  <action name="actionConfiguration">
-   <property name="icon">
-    <iconset resource="../../qgroundcontrol.qrc">
-     <normaloff>:/files/images/categories/applications-system.svg</normaloff>:/files/images/categories/applications-system.svg</iconset>
-   </property>
-   <property name="text">
-    <string>Preferences</string>
-   </property>
-   <property name="toolTip">
-    <string>Open UAS Preferences</string>
-   </property>
-  </action>
   <action name="actionJoystickSettings">
    <property name="icon">
     <iconset resource="../../qgroundcontrol.qrc">
@@ -375,6 +363,9 @@
    <property name="toolTip">
     <string>Application settings</string>
    </property>
+   <property name="menuRole">
+    <enum>QAction::PreferencesRole</enum>
+   </property>
   </action>
   <action name="actionFullscreen">
    <property name="checkable">
@@ -442,6 +433,9 @@
    <property name="toolTip">
     <string>Setup of the vehicle</string>
    </property>
+   <property name="menuRole">
+    <enum>QAction::NoRole</enum>
+   </property>
   </action>
   <action name="actionAdvanced_Mode">
    <property name="checkable">