From aca27c21e336416c2b4d3876110616ca636b36be Mon Sep 17 00:00:00 2001 From: Aleksey Kontsevich Date: Tue, 9 Jun 2020 02:56:05 +0300 Subject: [PATCH] Optimize if-statement in selectVertex() method --- src/MissionManager/QGCMapPolygon.cc | 2 +- src/MissionManager/QGCMapPolyline.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/MissionManager/QGCMapPolygon.cc b/src/MissionManager/QGCMapPolygon.cc index acd949a0f..804ab6963 100644 --- a/src/MissionManager/QGCMapPolygon.cc +++ b/src/MissionManager/QGCMapPolygon.cc @@ -632,7 +632,7 @@ void QGCMapPolygon::selectVertex(int index) { if(index == _selectedVertexIndex) return; // do nothing - if((0 <= index && index < count()) || index == -1) { + if(-1 <= index && index < count()) { _selectedVertexIndex = index; } else { qWarning() << "QGCMapPolygon: Selected vertex index is out of bounds!"; diff --git a/src/MissionManager/QGCMapPolyline.cc b/src/MissionManager/QGCMapPolyline.cc index ba37e98a1..aec2a01c1 100644 --- a/src/MissionManager/QGCMapPolyline.cc +++ b/src/MissionManager/QGCMapPolyline.cc @@ -449,7 +449,7 @@ void QGCMapPolyline::selectVertex(int index) { if(index == _selectedVertexIndex) return; // do nothing - if((0 <= index && index < count()) || index == -1) { + if(-1 <= index && index < count()) { _selectedVertexIndex = index; } else { qWarning() << "QGCMapPolyline: Selected vertex index is out of bounds!"; -- 2.22.0