From a8b9a63b44f3aa1d605a3774e169f8e874e5ce4d Mon Sep 17 00:00:00 2001 From: DonLakeFlyer Date: Mon, 29 Jan 2018 13:52:25 -0800 Subject: [PATCH] Fix leaking QNetworkReply --- src/QGCFileDownload.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/QGCFileDownload.cc b/src/QGCFileDownload.cc index 014d5c6fa..153f9b8d8 100644 --- a/src/QGCFileDownload.cc +++ b/src/QGCFileDownload.cc @@ -95,7 +95,8 @@ void QGCFileDownload::_downloadFinished(void) // When an error occurs or the user cancels the download, we still end up here. So bail out in // those cases. - if (reply->error() != QNetworkReply::NoError) { + if (reply->error() != QNetworkReply::NoError) { + reply->deleteLater(); return; } @@ -128,6 +129,8 @@ void QGCFileDownload::_downloadFinished(void) qWarning() << errorMsg; emit error(errorMsg); } + + reply->deleteLater(); } /// @brief Called when an error occurs during download -- 2.22.0