From 9fc0f88a2cad09ce1864689f56fe2ff1d0ea5219 Mon Sep 17 00:00:00 2001 From: Gus Grubba Date: Fri, 12 May 2017 13:12:10 -0400 Subject: [PATCH] Remove all Q_ASSERT instances from map engine. --- .../QMLControl/QGCMapEngineManager.cc | 28 +++++++++---------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/src/QtLocationPlugin/QMLControl/QGCMapEngineManager.cc b/src/QtLocationPlugin/QMLControl/QGCMapEngineManager.cc index cb46026f1..e5cae752c 100644 --- a/src/QtLocationPlugin/QMLControl/QGCMapEngineManager.cc +++ b/src/QtLocationPlugin/QMLControl/QGCMapEngineManager.cc @@ -260,8 +260,9 @@ QGCMapEngineManager::deleteTileSet(QGCCachedTileSet* tileSet) if(tileSet->defaultSet()) { for(int i = 0; i < _tileSets.count(); i++ ) { QGCCachedTileSet* set = qobject_cast(_tileSets.get(i)); - Q_ASSERT(set); - set->setDeleting(true); + if(set) { + set->setDeleting(true); + } } QGCResetTask* task = new QGCResetTask(); connect(task, &QGCResetTask::resetCompleted, this, &QGCMapEngineManager::_resetCompleted); @@ -293,8 +294,7 @@ QGCMapEngineManager::_tileSetDeleted(quint64 setID) int i = 0; for(i = 0; i < _tileSets.count(); i++ ) { QGCCachedTileSet* set = qobject_cast(_tileSets.get(i)); - Q_ASSERT(set); - if (set->setID() == setID) { + if (set && set->setID() == setID) { setToDelete = set; break; } @@ -350,8 +350,7 @@ QGCMapEngineManager::_updateTotals(quint32 totaltiles, quint64 totalsize, quint3 { for(int i = 0; i < _tileSets.count(); i++ ) { QGCCachedTileSet* set = qobject_cast(_tileSets.get(i)); - Q_ASSERT(set); - if (set->defaultSet()) { + if (set && set->defaultSet()) { set->setSavedTileSize(totalsize); set->setSavedTileCount(totaltiles); set->setTotalTileCount(defaulttiles); @@ -368,8 +367,7 @@ QGCMapEngineManager::findName(const QString& name) { for(int i = 0; i < _tileSets.count(); i++ ) { QGCCachedTileSet* set = qobject_cast(_tileSets.get(i)); - Q_ASSERT(set); - if (set->name() == name) { + if (set && set->name() == name) { return true; } } @@ -381,8 +379,9 @@ void QGCMapEngineManager::selectAll() { for(int i = 0; i < _tileSets.count(); i++ ) { QGCCachedTileSet* set = qobject_cast(_tileSets.get(i)); - Q_ASSERT(set); - set->setSelected(true); + if(set) { + set->setSelected(true); + } } } @@ -391,8 +390,9 @@ void QGCMapEngineManager::selectNone() { for(int i = 0; i < _tileSets.count(); i++ ) { QGCCachedTileSet* set = qobject_cast(_tileSets.get(i)); - Q_ASSERT(set); - set->setSelected(false); + if(set) { + set->setSelected(false); + } } } @@ -402,8 +402,7 @@ QGCMapEngineManager::selectedCount() { int count = 0; for(int i = 0; i < _tileSets.count(); i++ ) { QGCCachedTileSet* set = qobject_cast(_tileSets.get(i)); - Q_ASSERT(set); - if(set->selected()) { + if(set && set->selected()) { count++; } } @@ -464,7 +463,6 @@ QGCMapEngineManager::exportSets(QString path) { QVector sets; for(int i = 0; i < _tileSets.count(); i++ ) { QGCCachedTileSet* set = qobject_cast(_tileSets.get(i)); - Q_ASSERT(set); if(set->selected()) { sets.append(set); } -- 2.22.0