From 957e2f3b3b0c6b81cddb7d5e91423b603f534558 Mon Sep 17 00:00:00 2001 From: DonLakeFlyer Date: Sat, 30 Dec 2017 20:08:13 -0800 Subject: [PATCH] Fix dynamic file extension changing Don't close mobile dialog on file delete --- src/QmlControls/QGCFileDialog.qml | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/QmlControls/QGCFileDialog.qml b/src/QmlControls/QGCFileDialog.qml index 256a2c6e1..e770bc714 100644 --- a/src/QmlControls/QGCFileDialog.qml +++ b/src/QmlControls/QGCFileDialog.qml @@ -17,8 +17,8 @@ Item { property var qgcView property string folder property var nameFilters - property string fileExtension // Primary file extension to search for - property string fileExtension2 // Secondary file extension to search for + property string fileExtension // Primary file extension to search for + property string fileExtension2: "" // Secondary file extension to search for property string title property bool selectExisting property bool selectFolder @@ -28,12 +28,16 @@ Item { property bool _mobileDlg: QGroundControl.corePlugin.options.useMobileFileDialog property var _rgExtensions - Component.onCompleted: { - if (fileExtension2 === "") { + Component.onCompleted: setupFileExtensions() + + onFileExtensionChanged: setupFileExtensions() + onFileExtension2Changed: setupFileExtensions() + + function setupFileExtensions() { + if (fileExtension2 == "") { _rgExtensions = [ fileExtension ] } else { _rgExtensions = [ fileExtension, fileExtension2 ] - } } @@ -128,10 +132,7 @@ Item { property string fileToDelete - onAboutToHide: { - fileButton.highlight = false - hideDialog() - } + onAboutToHide: fileButton.highlight = false MenuItem { text: qsTr("Delete") @@ -143,7 +144,7 @@ Item { QGCLabel { text: qsTr("No files") - visible: fileList.model.length == 0 && fileList2.model.length == 0 + visible: fileList.model.length == 0 } } } -- 2.22.0