From 8f2547ded0e360e7ba124ea9f353acca3cc13fb2 Mon Sep 17 00:00:00 2001
From: Don Gagne <don@thegagnes.com>
Date: Mon, 30 Mar 2015 12:47:51 -0700
Subject: [PATCH] Cleanup current link before the link gets deleted

---
 src/ui/DebugConsole.cc | 30 +++++++++++++-----------------
 1 file changed, 13 insertions(+), 17 deletions(-)

diff --git a/src/ui/DebugConsole.cc b/src/ui/DebugConsole.cc
index 086934723..dfc299747 100644
--- a/src/ui/DebugConsole.cc
+++ b/src/ui/DebugConsole.cc
@@ -189,6 +189,19 @@ void DebugConsole::addLink(LinkInterface* link)
 
 void DebugConsole::removeLink(LinkInterface* const link)
 {
+    // Now if this was the current link, clean up some stuff.
+    if (link == currLink)
+    {
+        disconnect(currLink, &LinkInterface::bytesReceived, this, &DebugConsole::receiveBytes);
+        disconnect(currLink, &LinkInterface::connected, this, &DebugConsole::_linkConnected);
+        disconnect(currLink, &LinkInterface::communicationUpdate, this, &DebugConsole::linkStatusUpdate);
+        
+        // Like disable the update time for the UI.
+        snapShotTimer.stop();
+        
+        currLink = NULL;
+    }
+    
     bool found = false;
     int linkIndex;
     for (linkIndex=0; linkIndex<_links.count(); linkIndex++) {
@@ -203,14 +216,6 @@ void DebugConsole::removeLink(LinkInterface* const link)
     
     m_ui->linkComboBox->removeItem(linkIndex);
     
-    // Now if this was the current link, clean up some stuff.
-    if (link == currLink)
-    {
-        // Like disable the update time for the UI.
-        snapShotTimer.stop();
-
-        currLink = NULL;
-    }
 }
 void DebugConsole::linkStatusUpdate(const QString& name,const QString& text)
 {
@@ -222,15 +227,6 @@ void DebugConsole::linkStatusUpdate(const QString& name,const QString& text)
 
 void DebugConsole::linkSelected(int linkIndex)
 {
-    // Disconnect
-    if (currLink)
-    {
-        disconnect(currLink, SIGNAL(bytesReceived(LinkInterface*,QByteArray)), this, SLOT(receiveBytes(LinkInterface*, QByteArray)));
-        disconnect(currLink, &LinkInterface::connected, this, &DebugConsole::_linkConnected);
-        disconnect(currLink,SIGNAL(communicationUpdate(QString,QString)),this,SLOT(linkStatusUpdate(QString,QString)));
-        snapShotTimer.stop();
-    }
-
     // Clear data
     m_ui->receiveText->clear();
 
-- 
2.22.0