From 8e0e785b801f513eecc041d86848839a3a4aa76a Mon Sep 17 00:00:00 2001 From: Don Gagne Date: Fri, 10 Jun 2016 20:07:32 -0700 Subject: [PATCH] Fix bitmask editing --- src/QmlControls/ParameterEditorDialog.qml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/QmlControls/ParameterEditorDialog.qml b/src/QmlControls/ParameterEditorDialog.qml index b8e4f6e41..7e5f732ea 100644 --- a/src/QmlControls/ParameterEditorDialog.qml +++ b/src/QmlControls/ParameterEditorDialog.qml @@ -36,11 +36,10 @@ QGCViewDialog { QGCPalette { id: qgcPal; colorGroupEnabled: true } function accept() { - /* - if (bitmaskEditor.visible) { + if (bitmaskColumn.visible) { var value = 0; for (var i = 0; i < fact.bitmaskValues.length; ++i) { - var checkbox = bitmaskEditor.itemAt(i) + var checkbox = bitmaskRepeater.itemAt(i) if (checkbox.checked) { value |= fact.bitmaskValues[i]; } @@ -48,8 +47,7 @@ QGCViewDialog { fact.value = value; fact.valueChanged(fact.value) hideDialog(); - } - else */ if (factCombo.visible) { + } else if (factCombo.visible) { fact.enumIndex = factCombo.currentIndex hideDialog() } else { @@ -142,11 +140,13 @@ QGCViewDialog { } Column { - spacing: ScreenTools.defaultFontPixelHeight / 2 - visible: fact.bitmaskStrings.length > 0 ? true : false; + id: bitmaskColumn + spacing: ScreenTools.defaultFontPixelHeight / 2 + visible: fact.bitmaskStrings.length > 0 ? true : false; + Repeater { - id: bitmaskEditor - model: fact.bitmaskStrings + id: bitmaskRepeater + model: fact.bitmaskStrings delegate : QGCCheckBox { text : modelData -- 2.22.0