Commit 747c2917 authored by Gus Grubba's avatar Gus Grubba

Fixing build warnings.

parent 23b39123
...@@ -58,7 +58,8 @@ class CrashGenerationClientImpl : public CrashGenerationClient { ...@@ -58,7 +58,8 @@ class CrashGenerationClientImpl : public CrashGenerationClient {
iov.iov_base = const_cast<void*>(blob); iov.iov_base = const_cast<void*>(blob);
iov.iov_len = blob_size; iov.iov_len = blob_size;
struct kernel_msghdr msg = { 0 }; struct kernel_msghdr msg;
memset(&msg, 0, sizeof(kernel_msghdr));
msg.msg_iov = &iov; msg.msg_iov = &iov;
msg.msg_iovlen = 1; msg.msg_iovlen = 1;
char cmsg[kControlMsgSize] = ""; char cmsg[kControlMsgSize] = "";
......
...@@ -471,7 +471,7 @@ bool ExceptionHandler::HandleSignal(int /*sig*/, siginfo_t* info, void* uc) { ...@@ -471,7 +471,7 @@ bool ExceptionHandler::HandleSignal(int /*sig*/, siginfo_t* info, void* uc) {
// This is a public interface to HandleSignal that allows the client to // This is a public interface to HandleSignal that allows the client to
// generate a crash dump. This function may run in a compromised context. // generate a crash dump. This function may run in a compromised context.
bool ExceptionHandler::SimulateSignalDelivery(int sig) { bool ExceptionHandler::SimulateSignalDelivery(int sig) {
siginfo_t siginfo = {}; siginfo_t siginfo;
// Mimic a trusted signal to allow tracing the process (see // Mimic a trusted signal to allow tracing the process (see
// ExceptionHandler::HandleSignal(). // ExceptionHandler::HandleSignal().
siginfo.si_code = SI_USER; siginfo.si_code = SI_USER;
......
...@@ -75,9 +75,10 @@ int writeToCrashLog(const char* buf) { ...@@ -75,9 +75,10 @@ int writeToCrashLog(const char* buf) {
int write(const char* buf, size_t nbytes) { int write(const char* buf, size_t nbytes) {
#if defined(__ANDROID__) #if defined(__ANDROID__)
return __android_log_write(ANDROID_LOG_WARN, kAndroidLogTag, buf); (void)nbytes;
return __android_log_write(ANDROID_LOG_WARN, kAndroidLogTag, buf);
#else #else
return sys_write(2, buf, nbytes); return sys_write(2, buf, nbytes);
#endif #endif
} }
......
...@@ -449,7 +449,8 @@ class MicrodumpWriter { ...@@ -449,7 +449,8 @@ class MicrodumpWriter {
} }
// Copy as many bytes of |identifier| as will fit into a MDGUID // Copy as many bytes of |identifier| as will fit into a MDGUID
MDGUID module_identifier = {0}; MDGUID module_identifier;
memset(&module_identifier, 0, sizeof(MDGUID));
memcpy(&module_identifier, &identifier_bytes[0], memcpy(&module_identifier, &identifier_bytes[0],
std::min(sizeof(MDGUID), identifier_bytes.size())); std::min(sizeof(MDGUID), identifier_bytes.size()));
......
...@@ -874,7 +874,8 @@ bool LinuxDumper::HandleDeletedFileInMapping(char* path) const { ...@@ -874,7 +874,8 @@ bool LinuxDumper::HandleDeletedFileInMapping(char* path) const {
char exe_link[NAME_MAX]; char exe_link[NAME_MAX];
if (!BuildProcPath(exe_link, pid_, "exe")) if (!BuildProcPath(exe_link, pid_, "exe"))
return false; return false;
MappingInfo new_mapping = {0}; MappingInfo new_mapping;
memset(&new_mapping, 0, sizeof(MappingInfo));
if (!SafeReadLink(exe_link, new_mapping.name)) if (!SafeReadLink(exe_link, new_mapping.name))
return false; return false;
char new_path[PATH_MAX]; char new_path[PATH_MAX];
......
...@@ -144,10 +144,10 @@ static QObject* qgroundcontrolQmlGlobalSingletonFactory(QQmlEngine*, QJSEngine*) ...@@ -144,10 +144,10 @@ static QObject* qgroundcontrolQmlGlobalSingletonFactory(QQmlEngine*, QJSEngine*)
// breakpad support // breakpad support
#include "client/linux/handler/exception_handler.h" #include "client/linux/handler/exception_handler.h"
static bool dumpCallback(const google_breakpad::MinidumpDescriptor& descriptor, void* context, bool succeeded) static bool dumpCallback(const google_breakpad::MinidumpDescriptor& descriptor, void* /*context*/, bool succeeded)
{ {
qDebug() << "dumpCallback" << succeeded << descriptor.path(); qDebug() << "dumpCallback" << succeeded << descriptor.path();
return succeeded; return succeeded;
} }
#endif #endif
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment