From 6e4127f89d431f76a28b6bda817248fa324f4249 Mon Sep 17 00:00:00 2001
From: Don Gagne <dongagne@outlook.com>
Date: Thu, 8 Nov 2018 12:41:21 -0800
Subject: [PATCH] Fix reset handling

---
 src/QmlControls/PreFlightCheckGroup.qml |  2 +-
 src/QmlControls/PreFlightCheckList.qml  | 42 ++++++++++++++-----------
 2 files changed, 24 insertions(+), 20 deletions(-)

diff --git a/src/QmlControls/PreFlightCheckGroup.qml b/src/QmlControls/PreFlightCheckGroup.qml
index e1b1dd146..0f5b872dc 100644
--- a/src/QmlControls/PreFlightCheckGroup.qml
+++ b/src/QmlControls/PreFlightCheckGroup.qml
@@ -22,7 +22,7 @@ Column  {
 
     property alias _checked: header.checked
 
-    onPassedChanged: parent.groupPassedChanged(ObjectModel.index)
+    onPassedChanged: parent.groupPassedChanged(ObjectModel.index, passed)
 
     Component.onCompleted: {
         enabled = _checked
diff --git a/src/QmlControls/PreFlightCheckList.qml b/src/QmlControls/PreFlightCheckList.qml
index b37caf126..f36316b95 100644
--- a/src/QmlControls/PreFlightCheckList.qml
+++ b/src/QmlControls/PreFlightCheckList.qml
@@ -23,31 +23,31 @@ Rectangle {
 
     property alias model: checkListRepeater.model
 
-    property bool _passed: false
+    property bool _passed:  false
 
-    // We delay the updates when a group passes so the user can see all items green for a moment prior to hiding
-    Timer {
-        id:         delayedGroupPassed
-        interval:   750
-
-        property int index
-
-        onTriggered: {
+    function _handleGroupPassedChanged(index, passed) {
+        if (passed) {
+            // Collapse current group
             var group = checkListRepeater.itemAt(index)
             group._checked = false
+            // Expand next group
             if (index + 1 < checkListRepeater.count) {
                 group = checkListRepeater.itemAt(index + 1)
                 group.enabled = true
                 group._checked = true
             }
-            for (var i=0; i<checkListRepeater.count; i++) {
-                if (!checkListRepeater.itemAt(i).passed) {
-                    _passed = false
-                    return
-                }
-            }
-            _passed = true
         }
+        _passed = passed
+    }
+
+    // We delay the updates when a group passes so the user can see all items green for a moment prior to hiding
+    Timer {
+        id:         delayedGroupPassed
+        interval:   750
+
+        property int index
+
+        onTriggered: _handleGroupPassedChanged(index, true /* passed */)
     }
 
     Column {
@@ -59,9 +59,13 @@ Rectangle {
         anchors.topMargin:      0.6*ScreenTools.defaultFontPixelWidth
         anchors.leftMargin:     1.5*ScreenTools.defaultFontPixelWidth
 
-        function groupPassedChanged(index) {
-            delayedGroupPassed.index = index
-            delayedGroupPassed.restart()
+        function groupPassedChanged(index, passed) {
+            if (passed) {
+                delayedGroupPassed.index = index
+                delayedGroupPassed.restart()
+            } else {
+                _handleGroupPassedChanged(index, passed)
+            }
         }
 
         // Header/title of checklist
-- 
2.22.0