diff --git a/src/MissionManager/MissionCommandList.cc b/src/MissionManager/MissionCommandList.cc index 7c0e537e67cd87821644ac98f206d8fcac3e0bd8..51eb54e8c4c69a8cd72c2b405eef60088fa19265 100644 --- a/src/MissionManager/MissionCommandList.cc +++ b/src/MissionManager/MissionCommandList.cc @@ -104,7 +104,7 @@ void MissionCommandList::_loadMavCmdInfoJson(const QString& jsonFilename, bool b MissionCommandUIInfo* MissionCommandList::getUIInfo(MAV_CMD command) const { if (!_infoMap.contains(command)) { - return NULL; + return nullptr; } return _infoMap[command]; diff --git a/src/MissionManager/MissionCommandTree.cc b/src/MissionManager/MissionCommandTree.cc index b77f8b7de209718673103a1a1ee240c22c333abe..8f486ead16b7d6db8c055f50e20c029de9a419e6 100644 --- a/src/MissionManager/MissionCommandTree.cc +++ b/src/MissionManager/MissionCommandTree.cc @@ -24,7 +24,7 @@ MissionCommandTree::MissionCommandTree(QGCApplication* app, QGCToolbox* toolbox, bool unitTest) : QGCTool(app, toolbox) , _allCommandsCategory(tr("All commands")) - , _settingsManager(NULL) + , _settingsManager(nullptr) , _unitTest(unitTest) { } diff --git a/src/MissionManager/MissionCommandUIInfo.cc b/src/MissionManager/MissionCommandUIInfo.cc index 3c2747d8190b9cc4602d650d8132cfa546613f11..7fb8e0a2006c143c8f190934fde15ffa423c9341 100644 --- a/src/MissionManager/MissionCommandUIInfo.cc +++ b/src/MissionManager/MissionCommandUIInfo.cc @@ -409,13 +409,13 @@ bool MissionCommandUIInfo::loadJsonInfo(const QJsonObject& jsonObject, bool requ const MissionCmdParamInfo* MissionCommandUIInfo::getParamInfo(int index, bool& showUI) const { - const MissionCmdParamInfo* paramInfo = NULL; + const MissionCmdParamInfo* paramInfo = nullptr; if (_paramInfoMap.contains(index)) { paramInfo = _paramInfoMap[index]; } - showUI = (paramInfo != NULL) && !_paramRemoveList.contains(index); + showUI = (paramInfo != nullptr) && !_paramRemoveList.contains(index); return paramInfo; } diff --git a/src/MissionManager/SimpleMissionItem.cc b/src/MissionManager/SimpleMissionItem.cc index 74a9e7f5b6da288e17aed91e53c8c5485a74dbf6..bbebc91dd3d751c51c23923b41d66bf59acafa61 100644 --- a/src/MissionManager/SimpleMissionItem.cc +++ b/src/MissionManager/SimpleMissionItem.cc @@ -20,12 +20,12 @@ #include "QGroundControlQmlGlobal.h" #include "SettingsManager.h" -FactMetaData* SimpleMissionItem::_altitudeMetaData = NULL; -FactMetaData* SimpleMissionItem::_commandMetaData = NULL; -FactMetaData* SimpleMissionItem::_defaultParamMetaData = NULL; -FactMetaData* SimpleMissionItem::_frameMetaData = NULL; -FactMetaData* SimpleMissionItem::_latitudeMetaData = NULL; -FactMetaData* SimpleMissionItem::_longitudeMetaData = NULL; +FactMetaData* SimpleMissionItem::_altitudeMetaData = nullptr; +FactMetaData* SimpleMissionItem::_commandMetaData = nullptr; +FactMetaData* SimpleMissionItem::_defaultParamMetaData = nullptr; +FactMetaData* SimpleMissionItem::_frameMetaData = nullptr; +FactMetaData* SimpleMissionItem::_latitudeMetaData = nullptr; +FactMetaData* SimpleMissionItem::_longitudeMetaData = nullptr; const char* SimpleMissionItem::_jsonAltitudeModeKey = "AltitudeMode"; const char* SimpleMissionItem::_jsonAltitudeKey = "Altitude"; @@ -152,8 +152,8 @@ SimpleMissionItem::SimpleMissionItem(const SimpleMissionItem& other, bool flyVie , _rawEdit (false) , _dirty (false) , _ignoreDirtyChangeSignals (false) - , _speedSection (NULL) - , _cameraSection (NULL) + , _speedSection (nullptr) + , _cameraSection (nullptr) , _commandTree (qgcApp()->toolbox()->missionCommandTree()) , _supportedCommandFact (0, "Command:", FactMetaData::valueTypeUint32) , _altitudeMode (other._altitudeMode) @@ -595,7 +595,7 @@ void SimpleMissionItem::_rebuildFacts(void) bool SimpleMissionItem::friendlyEditAllowed(void) const { - const MissionCommandUIInfo* uiInfo = _commandTree->getUIInfo(_vehicle, (MAV_CMD)command()); + const MissionCommandUIInfo* uiInfo = _commandTree->getUIInfo(_vehicle, static_cast(command())); if (uiInfo && uiInfo->friendlyEdit()) { if (!_missionItem.autoContinue()) { return false; @@ -607,7 +607,6 @@ bool SimpleMissionItem::friendlyEditAllowed(void) const case MAV_FRAME_GLOBAL: case MAV_FRAME_GLOBAL_RELATIVE_ALT: return true; - break; case MAV_FRAME_GLOBAL_TERRAIN_ALT: return supportsTerrainFrame(); @@ -759,7 +758,7 @@ void SimpleMissionItem::_setDefaultsForCommand(void) _missionItem._param7Fact.setRawValue(0); } - MAV_CMD command = (MAV_CMD)this->command(); + MAV_CMD command = static_cast(this->command()); const MissionCommandUIInfo* uiInfo = _commandTree->getUIInfo(_vehicle, command); if (uiInfo) { for (int i=1; i<=7; i++) { @@ -806,13 +805,13 @@ void SimpleMissionItem::_sendFriendlyEditAllowedChanged(void) QString SimpleMissionItem::category(void) const { - return _commandTree->getUIInfo(_vehicle, (MAV_CMD)command())->category(); + return _commandTree->getUIInfo(_vehicle, static_cast(command()))->category(); } void SimpleMissionItem::setCommand(int command) { - if ((MAV_CMD)command != _missionItem.command()) { - _missionItem.setCommand((MAV_CMD)command); + if (static_cast(command) != _missionItem.command()) { + _missionItem.setCommand(static_cast(command)); _updateOptionalSections(); } } @@ -876,18 +875,18 @@ void SimpleMissionItem::_updateOptionalSections(void) // Remove previous sections if (_cameraSection) { _cameraSection->deleteLater(); - _cameraSection = NULL; + _cameraSection = nullptr; } if (_speedSection) { _speedSection->deleteLater(); - _speedSection = NULL; + _speedSection = nullptr; } // Add new sections _cameraSection = new CameraSection(_vehicle, this); _speedSection = new SpeedSection(_vehicle, this); - if ((MAV_CMD)command() == MAV_CMD_NAV_WAYPOINT) { + if (static_cast(command()) == MAV_CMD_NAV_WAYPOINT) { _cameraSection->setAvailable(true); _speedSection->setAvailable(true); } @@ -938,11 +937,11 @@ void SimpleMissionItem::appendMissionItems(QList& items, QObject* void SimpleMissionItem::applyNewAltitude(double newAltitude) { - MAV_CMD command = (MAV_CMD)this->command(); + MAV_CMD command = static_cast(this->command()); const MissionCommandUIInfo* uiInfo = _commandTree->getUIInfo(_vehicle, command); if (uiInfo->specifiesCoordinate() || uiInfo->specifiesAltitudeOnly()) { - switch ((MAV_CMD)this->command()) { + switch (static_cast(this->command())) { case MAV_CMD_NAV_LAND: case MAV_CMD_NAV_VTOL_LAND: // Leave alone