From 348285b0f9fb50a47e07b328de6f4ac190d8f672 Mon Sep 17 00:00:00 2001 From: Don Gagne Date: Wed, 24 Dec 2014 23:14:46 -0800 Subject: [PATCH] Emit signal after parameter updated Emitting signal beforehand can lead to subtle bugs where code expects value to be updated and it is not. --- src/uas/UASParameterDataModel.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/uas/UASParameterDataModel.cc b/src/uas/UASParameterDataModel.cc index 614edbdb7..760e6303c 100644 --- a/src/uas/UASParameterDataModel.cc +++ b/src/uas/UASParameterDataModel.cc @@ -184,9 +184,8 @@ void UASParameterDataModel::handleParamUpdate(int compId, const QString ¶mNa } } - emit parameterUpdated(compId,paramName,value); setOnboardParam(compId,paramName,value); - + emit parameterUpdated(compId,paramName,value); } bool UASParameterDataModel::getOnboardParamValue(int componentId, const QString& key, QVariant& value) const -- 2.22.0