From 28cc04f13dae006a303f7992f79334501973519b Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Mon, 26 Oct 2015 18:02:45 -0200 Subject: [PATCH] Fix possible crash creating an unknown dock widget if an unknown string was passed to createInnerDockidget, the widget would not be created but a reference to the null pointer would still be saved on the avaliable dock widgets, and thus any code that foreached the list accessing methods could led to a crash. Signed-off-by: Tomaz Canabrava --- src/ui/MainWindow.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ui/MainWindow.cc b/src/ui/MainWindow.cc index 2e9da5c02..ccad87374 100644 --- a/src/ui/MainWindow.cc +++ b/src/ui/MainWindow.cc @@ -389,6 +389,7 @@ void MainWindow::_createInnerDockWidget(const QString& widgetName) widget = pInfoView; } else { qWarning() << "Attempt to create unknown Inner Dock Widget" << widgetName; + return; } _mapName2DockWidget[widgetName] = widget; -- 2.22.0