Commit 1ef980da authored by tstellanova's avatar tstellanova

Respect component id passed to UAS::setParameter

parent eccfcb0a
...@@ -2368,9 +2368,9 @@ void UAS::enableExtra3Transmission(int rate) ...@@ -2368,9 +2368,9 @@ void UAS::enableExtra3Transmission(int rate)
* @param component The component to set the parameter * @param component The component to set the parameter
* @param id Name of the parameter * @param id Name of the parameter
*/ */
void UAS::setParameter(const int component, const QString& id, const QVariant& value) void UAS::setParameter(const int compId, const QString& paramId, const QVariant& value)
{ {
if (!id.isNull()) if (!paramId.isNull())
{ {
mavlink_message_t msg; mavlink_message_t msg;
mavlink_param_set_t p; mavlink_param_set_t p;
...@@ -2431,7 +2431,7 @@ void UAS::setParameter(const int component, const QString& id, const QVariant& v ...@@ -2431,7 +2431,7 @@ void UAS::setParameter(const int component, const QString& id, const QVariant& v
p.param_value = union_value.param_float; p.param_value = union_value.param_float;
p.target_system = (uint8_t)uasId; p.target_system = (uint8_t)uasId;
p.target_component = (uint8_t)component; p.target_component = (uint8_t)compId;
//qDebug() << "SENT PARAM:" << value; //qDebug() << "SENT PARAM:" << value;
...@@ -2439,9 +2439,9 @@ void UAS::setParameter(const int component, const QString& id, const QVariant& v ...@@ -2439,9 +2439,9 @@ void UAS::setParameter(const int component, const QString& id, const QVariant& v
for (unsigned int i = 0; i < sizeof(p.param_id); i++) for (unsigned int i = 0; i < sizeof(p.param_id); i++)
{ {
// String characters // String characters
if ((int)i < id.length()) if ((int)i < paramId.length())
{ {
p.param_id[i] = id.toAscii()[i]; p.param_id[i] = paramId.toAscii()[i];
} }
else else
{ {
...@@ -2449,7 +2449,7 @@ void UAS::setParameter(const int component, const QString& id, const QVariant& v ...@@ -2449,7 +2449,7 @@ void UAS::setParameter(const int component, const QString& id, const QVariant& v
p.param_id[i] = 0; p.param_id[i] = 0;
} }
} }
mavlink_msg_param_set_encode(mavlink->getSystemId(), mavlink->getComponentId(), &msg, &p); mavlink_msg_param_set_encode(mavlink->getSystemId(), compId, &msg, &p);
sendMessage(msg); sendMessage(msg);
} }
} }
......
...@@ -842,7 +842,7 @@ public slots: ...@@ -842,7 +842,7 @@ public slots:
void requestParameter(int component, int id); void requestParameter(int component, int id);
/** @brief Set a system parameter */ /** @brief Set a system parameter */
void setParameter(const int component, const QString& id, const QVariant& value); void setParameter(const int compId, const QString& paramId, const QVariant& value);
/** @brief Write parameters to permanent storage */ /** @brief Write parameters to permanent storage */
void writeParametersToStorage(); void writeParametersToStorage();
......
...@@ -156,11 +156,11 @@ void UASParameterCommsMgr::emitPendingParameterCommit(int compId, const QString& ...@@ -156,11 +156,11 @@ void UASParameterCommsMgr::emitPendingParameterCommit(int compId, const QString&
} }
break; break;
default: default:
qCritical() << "ABORTED PARAM SEND, NO VALID QVARIANT TYPE"; qCritical() << "ABORTED PARAM SEND, INVALID QVARIANT TYPE" << paramType;
return; return;
} }
setParameterStatusMsg(tr("Requested write of: %1: %2").arg(key).arg(value.toDouble())); setParameterStatusMsg(tr("Writing %1: %2 for comp. %3").arg(key).arg(value.toDouble()).arg(compId));
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment