From 15e9a62c187b47e774848ae501d5c1ef1cd12f71 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Mon, 26 Oct 2015 18:10:39 -0200 Subject: [PATCH] Correct usage of foreach with QString: const-ref it. The QString behaves faster if used with const - reference on a QForeach. Signed-off-by: Tomaz Canabrava --- src/ui/MainWindow.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ui/MainWindow.cc b/src/ui/MainWindow.cc index ccad87374..645375d59 100644 --- a/src/ui/MainWindow.cc +++ b/src/ui/MainWindow.cc @@ -644,7 +644,7 @@ void MainWindow::_loadVisibleWidgetsSettings(void) if (!widgets.isEmpty()) { QStringList nameList = widgets.split(","); - foreach (QString name, nameList) { + foreach (const QString &name, nameList) { _showDockWidget(name, true); } } @@ -655,7 +655,7 @@ void MainWindow::_storeVisibleWidgetsSettings(void) QString widgetNames; bool firstWidget = true; - foreach (QString name, _mapName2DockWidget.keys()) { + foreach (const QString &name, _mapName2DockWidget.keys()) { if (_mapName2DockWidget[name]->isVisible()) { if (!firstWidget) { widgetNames += ","; -- 2.22.0