Merge pull request #6659 from DonLakeFlyer/PlanToolOrbitFix

Fix broken Plan tools, fix broken orbit location

src/FlightDisplay/FlightDisplayViewMap.qml

@@ -369,7 +369,7 @@ FlightMap {
                 clickMenu.coord = clickCoord
                 clickMenu.popup()
             } else if (guidedActionsController.showGotoLocation) {
-                _guidedLocationCoordinate = clickCoord
+                gotoLocationItem.show(clickCoord)
                 guidedActionsController.confirmAction(guidedActionsController.actionGoto, clickCoord)
             } else if (guidedActionsController.showOrbit) {
                 orbitMapCircle.show(clickCoord)

src/PlanView/PlanView.qml

@@ -572,15 +572,15 @@ QGCView {
 
                 onClicked: {
                     switch (index) {
-                    case 0:
+                    case 1:
                         _addWaypointOnClick = checked
                         _addROIOnClick = false
                         break
-                    case 1:
+                    case 2:
                         _addROIOnClick = checked
                         _addWaypointOnClick = false
                         break
-                    case 2:
+                    case 3:
                         if (_singleComplexItem) {
                             addComplexItem(_missionController.complexMissionItemNames[0])
                         }

src/Vehicle/Vehicle.cc

@@ -2780,15 +2780,6 @@ void Vehicle::guidedModeOrbit(const QGeoCoordinate& centerCoord, double radius,
         return;
     }
 
-    double lat, lon, alt;
-    if (centerCoord.isValid()) {
-        lat = lon = alt = qQNaN();
-    } else {
-        lat = centerCoord.latitude();
-        lon = centerCoord.longitude();
-        alt = amslAltitude;
-    }
-
     if (capabilityBits() && MAV_PROTOCOL_CAPABILITY_COMMAND_INT) {
         sendMavCommandInt(defaultComponentId(),
                           MAV_CMD_DO_ORBIT,
@@ -2798,7 +2789,7 @@ void Vehicle::guidedModeOrbit(const QGeoCoordinate& centerCoord, double radius,
                           qQNaN(),         // Use default velocity
                           0,               // Vehicle points to center
                           qQNaN(),         // reserved
-                          lat, lon, alt);
+                          centerCoord.latitude(), centerCoord.longitude(), amslAltitude);
     } else {
         sendMavCommand(defaultComponentId(),
                        MAV_CMD_DO_ORBIT,
@@ -2807,7 +2798,7 @@ void Vehicle::guidedModeOrbit(const QGeoCoordinate& centerCoord, double radius,
                        qQNaN(),         // Use default velocity
                        0,               // Vehicle points to center
                        qQNaN(),         // reserved
-                       lat, lon, alt);
+                       centerCoord.latitude(), centerCoord.longitude(), amslAltitude);
     }
 }