Merge pull request #4240 from DonLakeFlyer/RallyPointOptional

RallyPoint support should be optional

src/FirmwarePlugin/APM/APMRallyPointManager.cc

@@ -31,7 +31,7 @@ APMRallyPointManager::~APMRallyPointManager()
 
 void APMRallyPointManager::sendToVehicle(const QList<QGeoCoordinate>& rgPoints)
 {
-    if (_vehicle->isOfflineEditingVehicle()) {
+    if (_vehicle->isOfflineEditingVehicle() || !rallyPointsSupported()) {
         return;
     }
 
@@ -53,7 +53,7 @@ void APMRallyPointManager::sendToVehicle(const QList<QGeoCoordinate>& rgPoints)
 
 void APMRallyPointManager::loadFromVehicle(void)
 {
-    if (_vehicle->isOfflineEditingVehicle() || _readTransactionInProgress) {
+    if (_vehicle->isOfflineEditingVehicle() || !rallyPointsSupported() || _readTransactionInProgress) {
         return;
     }
 
@@ -144,3 +144,8 @@ bool APMRallyPointManager::inProgress(void) const
 {
     return _readTransactionInProgress || _writeTransactionInProgress;
 }
+
+bool APMRallyPointManager::rallyPointsSupported(void) const
+{
+    return _vehicle->parameterManager()->parameterExists(_vehicle->defaultComponentId(), _rallyTotalParam);
+}

src/FirmwarePlugin/APM/APMRallyPointManager.h

@@ -25,7 +25,7 @@ public:
     bool inProgress             (void) const final;
     void loadFromVehicle        (void) final;
     void sendToVehicle          (const QList<QGeoCoordinate>& rgPoints) final;
-    bool rallyPointsSupported   (void) const final { return true; }
+    bool rallyPointsSupported   (void) const final;
 
     QString editorQml(void) const final { return QStringLiteral("qrc:/FirmwarePlugin/APM/APMRallyPointEditor.qml"); }