diff --git a/src/api/QGCCorePlugin.cc b/src/api/QGCCorePlugin.cc index c450528061c8fb262c6a32060ccb6dc718aebc9e..f40fe3d9267a48b764cbcd021d2e9165be2d483f 100644 --- a/src/api/QGCCorePlugin.cc +++ b/src/api/QGCCorePlugin.cc @@ -171,7 +171,7 @@ bool QGCCorePlugin::adjustSettingMetaData(FactMetaData& metaData) } else if (metaData.name() == AppSettings::telemetrySaveName) { #if defined (__mobile__) metaData.setRawDefaultValue(false); - return false; + return true; #else metaData.setRawDefaultValue(true); return true; diff --git a/src/comm/MAVLinkProtocol.cc b/src/comm/MAVLinkProtocol.cc index cdc54fe950d55084a2ede184508e52290c7d5a13..a8c507b83906774a82cd247567d74edf505fbbc4 100644 --- a/src/comm/MAVLinkProtocol.cc +++ b/src/comm/MAVLinkProtocol.cc @@ -102,7 +102,8 @@ void MAVLinkProtocol::setToolbox(QGCToolbox *toolbox) connect(this, &MAVLinkProtocol::saveTelemetryLog, _app, &QGCApplication::saveTelemetryLogOnMainThread); connect(this, &MAVLinkProtocol::checkTelemetrySavePath, _app, &QGCApplication::checkTelemetrySavePathOnMainThread); - connect(_multiVehicleManager->vehicles(), &QmlObjectListModel::countChanged, this, &MAVLinkProtocol::_vehicleCountChanged); + connect(_multiVehicleManager, &MultiVehicleManager::vehicleAdded, this, &MAVLinkProtocol::_vehicleCountChanged); + connect(_multiVehicleManager, &MultiVehicleManager::vehicleRemoved, this, &MAVLinkProtocol::_vehicleCountChanged); emit versionCheckChanged(m_enable_version_check); } @@ -327,8 +328,9 @@ void MAVLinkProtocol::enableVersionCheck(bool enabled) emit versionCheckChanged(enabled); } -void MAVLinkProtocol::_vehicleCountChanged(int count) +void MAVLinkProtocol::_vehicleCountChanged(void) { + int count = _multiVehicleManager->vehicles()->count(); if (count == 0) { // Last vehicle is gone, close out logging _stopLogging(); diff --git a/src/comm/MAVLinkProtocol.h b/src/comm/MAVLinkProtocol.h index 9d3ad1364d8037c07e8be453692922d83e958215..6e2b1d814a15c61314d036400065abf8cfc387b6 100644 --- a/src/comm/MAVLinkProtocol.h +++ b/src/comm/MAVLinkProtocol.h @@ -163,7 +163,7 @@ signals: void checkTelemetrySavePath(void); private slots: - void _vehicleCountChanged(int count); + void _vehicleCountChanged(void); private: bool _closeLogFile(void); diff --git a/src/ui/preferences/GeneralSettings.qml b/src/ui/preferences/GeneralSettings.qml index 41360be8b581470d18bda1e4e6d1d6083b74569b..27dc2dd9ca5c444756b5fa43bc9a5784835b56d9 100644 --- a/src/ui/preferences/GeneralSettings.qml +++ b/src/ui/preferences/GeneralSettings.qml @@ -253,7 +253,7 @@ QGCView { id: promptSaveLog text: qsTr("Save telemetry log after each flight") fact: _telemetrySave - visible: !ScreenTools.isMobile && _telemetrySave.visible + visible: _telemetrySave.visible property Fact _telemetrySave: QGroundControl.settingsManager.appSettings.telemetrySave } //----------------------------------------------------------------- @@ -261,7 +261,7 @@ QGCView { FactCheckBox { text: qsTr("Save telemetry log even if vehicle was not armed") fact: _telemetrySaveNotArmed - visible: !ScreenTools.isMobile && _telemetrySaveNotArmed.visible + visible: _telemetrySaveNotArmed.visible enabled: promptSaveLog.checked property Fact _telemetrySaveNotArmed: QGroundControl.settingsManager.appSettings.telemetrySaveNotArmed }