diff --git a/ChangeLog.md b/ChangeLog.md index 98a47c4f4016f4d426a7e9e66d20571bd047f880..468917cc08288488a4b773a485d8f5dfa4b39a5e 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -9,6 +9,7 @@ Note: This file only contains high level features or important fixes. * Major rewrite and bug fix pass through Structure Scan. Previous version had such bad problems that it can no longer be supported. Plans with Structure Scan will need to be recreated. New QGC will not load old Structure Scan plans. ### 3.5.3 - Not yet released +* Fix crash when clicking on GeoFence polygon vertex * PX4: Fix missing ```MC_YAW_FF``` parameter in PID Tuning * ArduPilot: Fix parameter file save generating bad characters from git hash diff --git a/src/PlanView/GeoFenceMapVisuals.qml b/src/PlanView/GeoFenceMapVisuals.qml index 371a64a4ca546f00aa288da2e7d77c367918e4cc..ad825da4b3b524322fcc65c97e8d7d9dee2de42a 100644 --- a/src/PlanView/GeoFenceMapVisuals.qml +++ b/src/PlanView/GeoFenceMapVisuals.qml @@ -20,6 +20,7 @@ import QGroundControl.FlightMap 1.0 /// GeoFence map visuals Item { + id: _root z: QGroundControl.zOrderMapItems property var map @@ -99,10 +100,15 @@ Item { } } + // By default the parent for Instantiator.delegate item is the Instatiator itself. By there is a bug + // in Qt which will cause a crash if this delete item has Menu item within it. Since the Menu item + // doesn't like having a non-visual item as parent. This is likely related to hybrid QQuickWidtget+QML + // Hence Qt folks are going to care. In order to workaround you have to parent the item to _root Item instead. Instantiator { model: _polygons delegate : QGCMapPolygonVisuals { + parent: _root mapControl: map mapPolygon: object borderWidth: object.inclusion ? _borderWidthInclusion : _borderWidthExclusion @@ -116,6 +122,7 @@ Item { model: _circles delegate : QGCMapCircleVisuals { + parent: _root mapControl: map mapCircle: object borderWidth: object.inclusion ? _borderWidthInclusion : _borderWidthExclusion diff --git a/src/Terrain/TerrainQuery.cc b/src/Terrain/TerrainQuery.cc index b2d1dada9cf3c539581f261fc570ba2d46e411f1..52687493587b0036794cd13261c88229b0df612a 100644 --- a/src/Terrain/TerrainQuery.cc +++ b/src/Terrain/TerrainQuery.cc @@ -489,7 +489,7 @@ void TerrainTileManager::_terrainDone(QByteArray responseBytes, QNetworkReply::N return; } - qWarning() << "Received some bytes of terrain data: " << responseBytes.size(); + qCDebug(TerrainQueryLog) << "Received some bytes of terrain data: " << responseBytes.size(); TerrainTile* terrainTile = new TerrainTile(responseBytes); if (terrainTile->isValid()) {