From b0c57f4b47df8a3bae6e579c657ec83538a2edc7 Mon Sep 17 00:00:00 2001
From: DoinLakeFlyer <don@thegagnes.com>
Date: Thu, 20 Feb 2020 10:37:18 -0800
Subject: [PATCH] Track trace mode in polygon so we can use it to exit wizard
 mode

---
 src/MissionManager/QGCMapPolygon.h          |  3 ++
 src/MissionManager/QGCMapPolygonVisuals.qml | 41 +++++++++++----------
 src/PlanView/SurveyItemEditor.qml           |  2 +-
 3 files changed, 26 insertions(+), 20 deletions(-)

diff --git a/src/MissionManager/QGCMapPolygon.h b/src/MissionManager/QGCMapPolygon.h
index 459ae8deb2..7e103a5457 100644
--- a/src/MissionManager/QGCMapPolygon.h
+++ b/src/MissionManager/QGCMapPolygon.h
@@ -38,6 +38,7 @@ public:
     Q_PROPERTY(bool                 interactive READ interactive    WRITE setInteractive    NOTIFY interactiveChanged)
     Q_PROPERTY(bool                 isValid     READ isValid                                NOTIFY isValidChanged)
     Q_PROPERTY(bool                 empty       READ empty                                  NOTIFY isEmptyChanged)
+    Q_PROPERTY(bool                 traceMode   MEMBER _traceMode                           NOTIFY traceModeChanged)
 
     Q_INVOKABLE void clear(void);
     Q_INVOKABLE void appendVertex(const QGeoCoordinate& coordinate);
@@ -124,6 +125,7 @@ signals:
     void interactiveChanged (bool interactive);
     bool isValidChanged     (void);
     bool isEmptyChanged     (void);
+    void traceModeChanged   (bool traceMode);
 
 private slots:
     void _polygonModelCountChanged(int count);
@@ -146,6 +148,7 @@ private:
     bool                _ignoreCenterUpdates;
     bool                _interactive;
     bool                _resetActive;
+    bool                _traceMode = false;
 };
 
 #endif
diff --git a/src/MissionManager/QGCMapPolygonVisuals.qml b/src/MissionManager/QGCMapPolygonVisuals.qml
index b508dab8a8..12c83cac9b 100644
--- a/src/MissionManager/QGCMapPolygonVisuals.qml
+++ b/src/MissionManager/QGCMapPolygonVisuals.qml
@@ -38,7 +38,6 @@ Item {
     property bool   _circleRadiusDrag:          false
     property var    _circleRadiusDragCoord:     QtPositioning.coordinate()
     property bool   _editCircleRadius:          false
-    property bool   _traceMode:                 false
     property string _instructionText:           _polygonToolsText
     property var    _savedVertices:             [ ]
     property bool   _savedCircleMode
@@ -157,7 +156,7 @@ Item {
             addEditingVisuals()
             addToolbarVisuals()
         } else {
-            _traceMode = false
+            mapPolygon.traceMode = false
             removeEditingVisuals()
             removeToolVisuals()
         }
@@ -183,16 +182,6 @@ Item {
 
     onInteractiveChanged: _handleInteractiveChanged()
 
-    on_TraceModeChanged: {
-        if (_traceMode) {
-            _instructionText = _traceText
-            _objMgrTraceVisuals.createObject(traceMouseAreaComponent, mapControl, false)
-        } else {
-            _instructionText = _polygonToolsText
-            _objMgrTraceVisuals.destroyObjects()
-        }
-    }
-
     on_CircleModeChanged: {
         if (_circleMode) {
             addCircleVisuals()
@@ -201,10 +190,24 @@ Item {
         }
     }
 
+    Connections {
+        target: mapPolygon
+        onTraceModeChanged: {
+            if (mapPolygon.traceMode) {
+                _instructionText = _traceText
+                _objMgrTraceVisuals.createObject(traceMouseAreaComponent, mapControl, false)
+            } else {
+                _instructionText = _polygonToolsText
+                _objMgrTraceVisuals.destroyObjects()
+            }
+        }
+    }
+
     Component.onCompleted: {
         addCommonVisuals()
         _handleInteractiveChanged()
     }
+    Component.onDestruction: map.traceMode = false
 
     QGCDynamicObjectManager { id: _objMgrCommonVisuals }
     QGCDynamicObjectManager { id: _objMgrToolVisuals }
@@ -526,30 +529,30 @@ Item {
             QGCButton {
                 _horizontalPadding: 0
                 text:               qsTr("Basic")
-                visible:            !_traceMode
+                visible:            !mapPolygon.traceMode
                 onClicked:          _resetPolygon()
             }
 
             QGCButton {
                 _horizontalPadding: 0
                 text:               qsTr("Circular")
-                visible:            !_traceMode
+                visible:            !mapPolygon.traceMode
                 onClicked:          _resetCircle()
             }
 
             QGCButton {
                 _horizontalPadding: 0
-                text:               _traceMode ? qsTr("Done Tracing") : qsTr("Trace")
+                text:               mapPolygon.traceMode ? qsTr("Done Tracing") : qsTr("Trace")
                 onClicked: {
-                    if (_traceMode) {
+                    if (mapPolygon.traceMode) {
                         if (mapPolygon.count < 3) {
                             _restorePreviousVertices()
                         }
-                        _traceMode = false
+                        mapPolygon.traceMode = false
                     } else {
                         _saveCurrentVertices()
                         _circleMode = false
-                        _traceMode = true
+                        mapPolygon.traceMode = true
                         mapPolygon.clear();
                     }
                 }
@@ -559,7 +562,7 @@ Item {
                 _horizontalPadding: 0
                 text:               qsTr("Load KML/SHP...")
                 onClicked:          kmlOrSHPLoadDialog.openForLoad()
-                visible:            !_traceMode
+                visible:            !mapPolygon.traceMode
             }
         }
     }
diff --git a/src/PlanView/SurveyItemEditor.qml b/src/PlanView/SurveyItemEditor.qml
index 553e3786e1..b9c1616f18 100644
--- a/src/PlanView/SurveyItemEditor.qml
+++ b/src/PlanView/SurveyItemEditor.qml
@@ -80,7 +80,7 @@ Rectangle {
                 QGCButton {
                     text:               qsTr("Done With Polygon")
                     Layout.fillWidth:   true
-                    enabled:            missionItem.surveyAreaPolygon.isValid
+                    enabled:            missionItem.surveyAreaPolygon.isValid && !missionItem.surveyAreaPolygon.traceMode
                     onClicked: {
                         if (!_presetsAvailable) {
                             missionItem.wizardMode = false
-- 
GitLab