From 28a033254efa4124385f4ca5f329d251c2565478 Mon Sep 17 00:00:00 2001
From: Don Gagne <dongagne@outlook.com>
Date: Sat, 7 Sep 2019 18:07:28 -0700
Subject: [PATCH] No speech during unit tests

---
 src/Audio/AudioOutput.cc | 20 ++++++++++++++++----
 src/Audio/AudioOutput.h  |  2 +-
 2 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/src/Audio/AudioOutput.cc b/src/Audio/AudioOutput.cc
index 4c892b5da4..98e9498ee9 100644
--- a/src/Audio/AudioOutput.cc
+++ b/src/Audio/AudioOutput.cc
@@ -17,9 +17,17 @@
 #include "SettingsManager.h"
 
 AudioOutput::AudioOutput(QGCApplication* app, QGCToolbox* toolbox)
-    : QGCTool(app, toolbox)
-    , _tts(new QTextToSpeech(this))
+    : QGCTool   (app, toolbox)
+    , _tts      (nullptr)
 {
+    if (qgcApp()->runningUnitTests()) {
+        // Cloud based unit tests don't have speech capabilty. If you try to crank up
+        // speech engine it will pop a qWarning which prevents usage of QT_FATAL_WARNINGS
+        return;
+    }
+
+    _tts = new QTextToSpeech(this);
+
     //-- Force TTS engine to English as all incoming messages from the autopilot
     //   are in English and not localized.
 #ifdef Q_OS_LINUX
@@ -28,8 +36,13 @@ AudioOutput::AudioOutput(QGCApplication* app, QGCToolbox* toolbox)
     connect(_tts, &QTextToSpeech::stateChanged, this, &AudioOutput::_stateChanged);
 }
 
-bool AudioOutput::say(const QString& inText)
+void AudioOutput::say(const QString& inText)
 {
+    if (!_tts) {
+        qDebug() << "say" << inText;
+        return;
+    }
+
     bool muted = qgcApp()->toolbox()->settingsManager()->appSettings()->audioMuted()->rawValue().toBool();
     muted |= qgcApp()->runningUnitTests();
     if (!muted && !qgcApp()->runningUnitTests()) {
@@ -46,7 +59,6 @@ bool AudioOutput::say(const QString& inText)
             _tts->say(text);
         }
     }
-    return true;
 }
 
 void AudioOutput::_stateChanged(QTextToSpeech::State state)
diff --git a/src/Audio/AudioOutput.h b/src/Audio/AudioOutput.h
index b97d81f4e9..e6da79c26a 100644
--- a/src/Audio/AudioOutput.h
+++ b/src/Audio/AudioOutput.h
@@ -29,7 +29,7 @@ public:
     static QString  fixTextMessageForAudio  (const QString& string);
 
 public slots:
-    bool            say                     (const QString& text);
+    void            say                     (const QString& text);
 
 private slots:
     void            _stateChanged           (QTextToSpeech::State state);
-- 
GitLab